Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source aws_ses_domain_identity aws_ses_email_identity #22321

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

danquack
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16878

Output from acceptance testing:

$  make testacc TESTARGS="-run=TestAccSESDomainIdentityDataSource_basic" PKG_NAME="./internal/service/ses" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ses/... -v -count 1 -parallel 3 -run=TestAccSESDomainIdentityDataSource_basic TestAccSESEmailIdentityDataSource_basic TestAccSESEmailIdentityDataSource_trailingPeriod -timeout 180m
=== RUN   TestAccSESDomainIdentityDataSource_basic
=== PAUSE TestAccSESDomainIdentityDataSource_basic
=== CONT  TestAccSESDomainIdentityDataSource_basic
--- PASS: TestAccSESDomainIdentityDataSource_basic (23.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	25.080s
$ make testacc TESTARGS="-run=TestAccSESEmailIdentityDataSource_basic" PKG_NAME="./internal/service/ses" ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ses/... -v -count 1 -parallel 3 -run=TestAccSESEmailIdentityDataSource_basic -timeout 180m
=== RUN   TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== CONT  TestAccSESEmailIdentityDataSource_basic
--- PASS: TestAccSESEmailIdentityDataSource_basic (22.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	23.743s
$ make testacc TESTARGS="-run=TestAccSESEmailIdentityDataSource_trailingPeriod" PKG_NAME="./internal/service/ses" ACCTEST_PARALLELISM=3   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ses/... -v -count 1 -parallel 3 -run=TestAccSESEmailIdentityDataSource_trailingPeriod -timeout 180m
=== RUN   TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== CONT  TestAccSESEmailIdentityDataSource_trailingPeriod
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (22.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	23.651s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Dec 22, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 22, 2021
@danquack danquack changed the title data_source ses email/domain identity data_source aws_ses_domain_identity aws_ses_email_identity Dec 22, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 23, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESDomainIdentityDataSource_\|TestAccSESEmailIdentityDataSource_' PKG=ses
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ses/... -v -count 1 -parallel 20 -run=TestAccSESDomainIdentityDataSource_\|TestAccSESEmailIdentityDataSource_ -timeout 180m
=== RUN   TestAccSESDomainIdentityDataSource_basic
=== PAUSE TestAccSESDomainIdentityDataSource_basic
=== RUN   TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== RUN   TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== CONT  TestAccSESDomainIdentityDataSource_basic
=== CONT  TestAccSESEmailIdentityDataSource_basic
=== CONT  TestAccSESEmailIdentityDataSource_trailingPeriod
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (18.94s)
--- PASS: TestAccSESEmailIdentityDataSource_basic (20.00s)
--- PASS: TestAccSESDomainIdentityDataSource_basic (20.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	25.099s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 966a258 into hashicorp:main Dec 23, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 23, 2021
@danquack danquack deleted the ses-identity branch December 23, 2021 13:51
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Sources: aws_ses_domain_identity and aws_ses_email_identity
2 participants