Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_mskconnect_worker_configuration resource #22414

Merged

Conversation

rtim75
Copy link
Contributor

@rtim75 rtim75 commented Jan 5, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20942

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@rtim75 rtim75 force-pushed the f-aws_mskconnect_worker_configuration branch from 238a52f to 1b1bfd4 Compare January 5, 2022 12:13
@rtim75
Copy link
Contributor Author

rtim75 commented Jan 5, 2022

Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Oops, my bad.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 5, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 5, 2022
@rtim75 rtim75 marked this pull request as ready for review January 5, 2022 19:01
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_ -timeout 180m
=== RUN   TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== RUN   TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== PAUSE TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT  TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== CONT  TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT  TestAccKafkaConnectWorkerConfiguration_basic
=== CONT  TestAccKafkaConnectWorkerConfiguration_description
--- PASS: TestAccKafkaConnectWorkerConfiguration_description (23.86s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_basic (26.00s)
--- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (35.51s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_properties_file_content (41.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	48.596s
GovCloud
% make testacc TESTARGS='-run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_ -timeout 180m
=== RUN   TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== RUN   TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== PAUSE TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT  TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== CONT  TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT  TestAccKafkaConnectWorkerConfiguration_basic
=== CONT  TestAccKafkaConnectWorkerConfiguration_description
=== CONT  TestAccKafkaConnectWorkerConfiguration_basic
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
=== CONT  TestAccKafkaConnectWorkerConfigurationDataSource_basic
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_basic (1.38s)
--- SKIP: TestAccKafkaConnectWorkerConfigurationDataSource_basic (1.38s)
=== CONT  TestAccKafkaConnectWorkerConfiguration_properties_file_content
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_properties_file_content (1.38s)
=== CONT  TestAccKafkaConnectWorkerConfiguration_description
    acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_description (1.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	6.872s

@ewbankkit
Copy link
Contributor

@rtim75 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5902887 into hashicorp:main Jan 6, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 6, 2022
@rtim75 rtim75 deleted the f-aws_mskconnect_worker_configuration branch January 6, 2022 14:39
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants