-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_mskconnect_worker_configuration resource #22414
Add aws_mskconnect_worker_configuration resource #22414
Conversation
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
238a52f
to
1b1bfd4
Compare
Oops, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_ -timeout 180m
=== RUN TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== RUN TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== PAUSE TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== CONT TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT TestAccKafkaConnectWorkerConfiguration_basic
=== CONT TestAccKafkaConnectWorkerConfiguration_description
--- PASS: TestAccKafkaConnectWorkerConfiguration_description (23.86s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_basic (26.00s)
--- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (35.51s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_properties_file_content (41.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 48.596s
GovCloud
% make testacc TESTARGS='-run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_' PKG_NAME=internal/service/kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run=TestAccKafkaConnectWorkerConfigurationDataSource_\|TestAccKafkaConnectWorkerConfiguration_ -timeout 180m
=== RUN TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== RUN TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== PAUSE TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== CONT TestAccKafkaConnectWorkerConfiguration_properties_file_content
=== CONT TestAccKafkaConnectWorkerConfiguration_basic
=== CONT TestAccKafkaConnectWorkerConfiguration_description
=== CONT TestAccKafkaConnectWorkerConfiguration_basic
acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
=== CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic
acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_basic (1.38s)
--- SKIP: TestAccKafkaConnectWorkerConfigurationDataSource_basic (1.38s)
=== CONT TestAccKafkaConnectWorkerConfiguration_properties_file_content
acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_properties_file_content (1.38s)
=== CONT TestAccKafkaConnectWorkerConfiguration_description
acctest.go:608: skipping tests; partition aws-us-gov does not support kafkaconnect service
--- SKIP: TestAccKafkaConnectWorkerConfiguration_description (1.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 6.872s
@rtim75 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #20942
Output from acceptance testing: