r/aws_subnet: Resource-based naming is not available in the `ap-southeast-3` region #22531

ewbankkit · 2022-01-11T18:10:46Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Previously:

% AWS_DEFAULT_REGION=ap-southeast-3 make testacc TESTS=TestAccEC2Subnet_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_basic'  -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_basic
    subnet_test.go:25: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating EC2 Subnet: InvalidParameter: The parameter ipv6Native is not recognized
        	status code: 400, request id: 984022b4-35f4-4581-adec-34a058e59131
        
          with aws_subnet.test,
          on terraform_plugin_test.tf line 10, in resource "aws_subnet" "test":
          10: resource "aws_subnet" "test" {
        
--- FAIL: TestAccEC2Subnet_basic (37.39s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	41.076s
FAIL
make: *** [testacc] Error 1

Now

% AWS_DEFAULT_REGION=ap-southeast-3 make testacc TESTS=TestAccEC2Subnet_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_basic'  -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_basic
--- PASS: TestAccEC2Subnet_basic (79.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	83.756s

Also addresses failing CI test:

=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
subnet_test.go:815: Step 1/4 error: Check failed: Check 4/4 error: aws_subnet.test: Attribute 'private_dns_hostname_type_on_launch' expected "resource-name", got "ip-name"
--- FAIL: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (70.15s)

Output from acceptance testing:

`ap-southeast-3`

% AWS_DEFAULT_REGION=ap-southeast-3 make testacc TESTARGS='-run=TestAccEC2Subnet_\|TestAccEC2SubnetDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2Subnet_\|TestAccEC2SubnetDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
    subnet_test.go:820: Resource-based naming is not available in the ap-southeast-3 region
--- SKIP: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (0.00s)
=== RUN   TestAccEC2Subnet_ipv6Native
    subnet_test.go:872: Resource-based naming is not available in the ap-southeast-3 region
--- SKIP: TestAccEC2Subnet_ipv6Native (0.00s)
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1245: skipping acceptance testing: RequestError: send request failed
        caused by: Get "https://outposts.ap-southeast-3.amazonaws.com/outposts": dial tcp: lookup outposts.ap-southeast-3.amazonaws.com: no such host
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (29.07s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1245: skipping acceptance testing: RequestError: send request failed
        caused by: Get "https://outposts.ap-southeast-3.amazonaws.com/outposts": dial tcp: lookup outposts.ap-southeast-3.amazonaws.com: no such host
--- SKIP: TestAccEC2Subnet_outpost (19.68s)
=== CONT  TestAccEC2Subnet_disappears
--- PASS: TestAccEC2SubnetDataSource_basic (73.92s)
=== CONT  TestAccEC2Subnet_availabilityZoneID
--- PASS: TestAccEC2Subnet_disappears (59.87s)
=== CONT  TestAccEC2Subnet_enableIPv6
--- PASS: TestAccEC2Subnet_availabilityZoneID (70.66s)
=== CONT  TestAccEC2Subnet_ipv6
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (169.43s)
=== CONT  TestAccEC2Subnet_ignoreTags
--- PASS: TestAccEC2Subnet_enableIPv6 (172.85s)
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
--- PASS: TestAccEC2Subnet_ignoreTags (138.82s)
=== CONT  TestAccEC2Subnet_enableDNS64
--- PASS: TestAccEC2Subnet_ipv6 (173.50s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (101.74s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (202.83s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEC2Subnet_enableDNS64 (203.98s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (115.67s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (123.49s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (139.31s)
=== CONT  TestAccEC2Subnet_basic
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (126.42s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (108.07s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2Subnet_basic (67.40s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1245: skipping acceptance testing: RequestError: send request failed
        caused by: Get "https://outposts.ap-southeast-3.amazonaws.com/outposts": dial tcp: lookup outposts.ap-southeast-3.amazonaws.com: no such host
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (22.25s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (118.49s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (1.00s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (120.10s)
--- PASS: TestAccEC2Subnet_tags (172.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	892.443s

`us-west-2`

% make testacc TESTARGS='-run=TestAccEC2Subnet_\|TestAccEC2SubnetDataSource_' PKG=ec2 ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2Subnet_\|TestAccEC2SubnetDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2SubnetDataSource_basic (28.96s)
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (45.28s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
--- PASS: TestAccEC2Subnet_ignoreTags (55.39s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (0.82s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (1.18s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.60s)
=== CONT  TestAccEC2Subnet_disappears
--- PASS: TestAccEC2Subnet_tags (63.44s)
=== CONT  TestAccEC2Subnet_ipv6Native
--- PASS: TestAccEC2Subnet_disappears (23.06s)
=== CONT  TestAccEC2Subnet_availabilityZoneID
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (61.87s)
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (53.95s)
=== CONT  TestAccEC2Subnet_enableIPv6
--- PASS: TestAccEC2Subnet_ipv6Native (38.37s)
=== CONT  TestAccEC2Subnet_ipv6
--- PASS: TestAccEC2Subnet_availabilityZoneID (26.68s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEC2Subnet_enableIPv6 (63.82s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (59.10s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccEC2Subnet_ipv6 (65.01s)
=== CONT  TestAccEC2Subnet_basic
--- PASS: TestAccEC2Subnet_basic (25.29s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (43.90s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (55.42s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (41.86s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (0.60s)
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (149.34s)
=== CONT  TestAccEC2Subnet_enableDNS64
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (42.62s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (58.94s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (91.01s)
--- PASS: TestAccEC2Subnet_enableDNS64 (91.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	335.805s

…Pacific (Jakarta) Region.

…ilable in the AWS Asia Pacific (Jakarta) Region.

YakDriver

Looks good! 🎉

--- PASS: TestAccEC2Subnet_basic (23.81s)

… not available in the AWS Asia Pacific (Jakarta) Region." This reverts commit 3cbedba.

ewbankkit · 2022-01-11T21:55:48Z

Reverting the acceptance test changes as we don't experience any failures during usual testing.

github-actions · 2022-01-14T00:01:11Z

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-28T02:27:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 11, 2022

ewbankkit added 3 commits January 11, 2022 13:50

r/aws_subnet: Resource-based naming is not available in the AWS Asia …

f3962f5

…Pacific (Jakarta) Region.

r/aws_subnet: Resource-based naming and IPv6-only subnets are not ava…

3cbedba

…ilable in the AWS Asia Pacific (Jakarta) Region.

Add CHANGELOG entry.

f0a18dc

ewbankkit force-pushed the b-aws_subnet_ipv6_native-ap-southeast-3 branch from 5885d18 to f0a18dc Compare January 11, 2022 18:58

YakDriver self-assigned this Jan 11, 2022

YakDriver approved these changes Jan 11, 2022

View reviewed changes

Revert "r/aws_subnet: Resource-based naming and IPv6-only subnets are…

0d12107

… not available in the AWS Asia Pacific (Jakarta) Region." This reverts commit 3cbedba.

github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 11, 2022

ewbankkit merged commit e2027a3 into main Jan 11, 2022

ewbankkit deleted the b-aws_subnet_ipv6_native-ap-southeast-3 branch January 11, 2022 22:26

github-actions bot added this to the v3.72.0 milestone Jan 11, 2022

github-actions bot pushed a commit that referenced this pull request Jan 11, 2022

Update CHANGELOG.md for #22531

6d5226a

github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_subnet: Resource-based naming is not available in the `ap-southeast-3` region #22531

r/aws_subnet: Resource-based naming is not available in the `ap-southeast-3` region #22531

ewbankkit commented Jan 11, 2022 •

edited

Loading

YakDriver left a comment

ewbankkit commented Jan 11, 2022

github-actions bot commented Jan 14, 2022

github-actions bot commented May 28, 2022

r/aws_subnet: Resource-based naming is not available in the ap-southeast-3 region #22531

r/aws_subnet: Resource-based naming is not available in the ap-southeast-3 region #22531

Conversation

ewbankkit commented Jan 11, 2022 • edited Loading

Community Note

ap-southeast-3

us-west-2

YakDriver left a comment

Choose a reason for hiding this comment

ewbankkit commented Jan 11, 2022

github-actions bot commented Jan 14, 2022

github-actions bot commented May 28, 2022

r/aws_subnet: Resource-based naming is not available in the `ap-southeast-3` region #22531

r/aws_subnet: Resource-based naming is not available in the `ap-southeast-3` region #22531

ewbankkit commented Jan 11, 2022 •

edited

Loading

`ap-southeast-3`

`us-west-2`