-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/dataexchange_data_set - new resource #22697
Conversation
62e722a
to
e09fb45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTS=TestAccDataExchangeDataSet_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeDataSet_' -timeout 180m
=== RUN TestAccDataExchangeDataSet_basic
=== PAUSE TestAccDataExchangeDataSet_basic
=== RUN TestAccDataExchangeDataSet_tags
=== PAUSE TestAccDataExchangeDataSet_tags
=== RUN TestAccDataExchangeDataSet_disappears
=== PAUSE TestAccDataExchangeDataSet_disappears
=== CONT TestAccDataExchangeDataSet_basic
=== CONT TestAccDataExchangeDataSet_disappears
=== CONT TestAccDataExchangeDataSet_tags
--- PASS: TestAccDataExchangeDataSet_disappears (13.68s)
--- PASS: TestAccDataExchangeDataSet_basic (29.12s)
--- PASS: TestAccDataExchangeDataSet_tags (40.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange 44.590s
GovCloud
% make testacc TESTS=TestAccDataExchangeDataSet_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeDataSet_' -timeout 180m
=== RUN TestAccDataExchangeDataSet_basic
=== PAUSE TestAccDataExchangeDataSet_basic
=== RUN TestAccDataExchangeDataSet_tags
=== PAUSE TestAccDataExchangeDataSet_tags
=== RUN TestAccDataExchangeDataSet_disappears
=== PAUSE TestAccDataExchangeDataSet_disappears
=== CONT TestAccDataExchangeDataSet_basic
=== CONT TestAccDataExchangeDataSet_disappears
=== CONT TestAccDataExchangeDataSet_tags
=== CONT TestAccDataExchangeDataSet_basic
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
=== CONT TestAccDataExchangeDataSet_tags
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeDataSet_basic (1.39s)
--- SKIP: TestAccDataExchangeDataSet_tags (1.39s)
=== CONT TestAccDataExchangeDataSet_disappears
acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeDataSet_disappears (1.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange 13.096s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #22237
Output from acceptance testing: