Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/dataexchange_data_set - new resource #22697

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 20, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22237

Output from acceptance testing:

$ make testacc TESTS=TestAccDataExchangeDataSet_ PKG=dataexchange 

--- PASS: TestAccDataExchangeDataSet_disappears (48.21s)
--- PASS: TestAccDataExchangeDataSet_basic (93.39s)
--- PASS: TestAccDataExchangeDataSet_tags (123.72s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/dataexchange Issues and PRs that pertain to the dataexchange service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2022
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 20, 2022
@DrFaust92 DrFaust92 marked this pull request as draft January 20, 2022 21:38
@DrFaust92 DrFaust92 changed the title r/dataexchange_dataset - new resource r/dataexchange_data_set - new resource Jan 20, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 21, 2022 22:41
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. and removed sweeper Pertains to changes to or issues with the sweeper. labels Jan 22, 2022
@DrFaust92 DrFaust92 added the sweeper Pertains to changes to or issues with the sweeper. label Jan 23, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccDataExchangeDataSet_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeDataSet_'  -timeout 180m
=== RUN   TestAccDataExchangeDataSet_basic
=== PAUSE TestAccDataExchangeDataSet_basic
=== RUN   TestAccDataExchangeDataSet_tags
=== PAUSE TestAccDataExchangeDataSet_tags
=== RUN   TestAccDataExchangeDataSet_disappears
=== PAUSE TestAccDataExchangeDataSet_disappears
=== CONT  TestAccDataExchangeDataSet_basic
=== CONT  TestAccDataExchangeDataSet_disappears
=== CONT  TestAccDataExchangeDataSet_tags
--- PASS: TestAccDataExchangeDataSet_disappears (13.68s)
--- PASS: TestAccDataExchangeDataSet_basic (29.12s)
--- PASS: TestAccDataExchangeDataSet_tags (40.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	44.590s
GovCloud
% make testacc TESTS=TestAccDataExchangeDataSet_ PKG=dataexchange
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeDataSet_'  -timeout 180m
=== RUN   TestAccDataExchangeDataSet_basic
=== PAUSE TestAccDataExchangeDataSet_basic
=== RUN   TestAccDataExchangeDataSet_tags
=== PAUSE TestAccDataExchangeDataSet_tags
=== RUN   TestAccDataExchangeDataSet_disappears
=== PAUSE TestAccDataExchangeDataSet_disappears
=== CONT  TestAccDataExchangeDataSet_basic
=== CONT  TestAccDataExchangeDataSet_disappears
=== CONT  TestAccDataExchangeDataSet_tags
=== CONT  TestAccDataExchangeDataSet_basic
    acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
=== CONT  TestAccDataExchangeDataSet_tags
    acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeDataSet_basic (1.39s)
--- SKIP: TestAccDataExchangeDataSet_tags (1.39s)
=== CONT  TestAccDataExchangeDataSet_disappears
    acctest.go:609: skipping tests; partition aws-us-gov does not support dataexchange service
--- SKIP: TestAccDataExchangeDataSet_disappears (1.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	13.096s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 773b3e0 into hashicorp:main Jan 24, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 24, 2022
@DrFaust92 DrFaust92 deleted the dataexchange_data_Set branch January 24, 2022 14:28
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/dataexchange Issues and PRs that pertain to the dataexchange service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants