Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement management of client-ids for aws_iam_openid_connect_provider #23099

Closed
fmasuhr opened this issue Feb 10, 2022 · 3 comments · Fixed by #37612
Closed

Implement management of client-ids for aws_iam_openid_connect_provider #23099

fmasuhr opened this issue Feb 10, 2022 · 3 comments · Fixed by #37612
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@fmasuhr
Copy link
Contributor

fmasuhr commented Feb 10, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently the client_id_list attribute on the aws_iam_openid_connect_provider is implemented as a ForceNew attribute. This is due to the fact that the client_ids can only be specified during creation https://docs.aws.amazon.com/IAM/latest/APIReference/API_CreateOpenIDConnectProvider.html.
For updates of the client_ids it is necessary to use add and delete operations https://docs.aws.amazon.com/IAM/latest/APIReference/API_AddClientIDToOpenIDConnectProvider.html.

The recreation of the resource will result in the same ARN but it still means that there is an unnecessary recreation which might lead to issues of authentication during the recreation.

The same behavior exists for the thumbprint_list but there it has already be implemented https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/iam/openid_connect_provider.go#L127-L137.

New or Affected Resource(s)

  • aws_iam_openid_connect_provider

Potential Terraform Configuration

References

@fmasuhr fmasuhr added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 10, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/iam Issues and PRs that pertain to the iam service. labels Feb 10, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2022
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.51.0 milestone May 21, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
2 participants