Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/api_gateway_authorizer - add arn attribute #23151

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccAPIGatewayAuthorizer_ PKG=apigateway

--- PASS: TestAccAPIGatewayAuthorizer_Cognito_authorizerCredentials (47.95s)
--- PASS: TestAccAPIGatewayAuthorizer_disappears (77.89s)
--- PASS: TestAccAPIGatewayAuthorizer_authTypeValidation (78.14s)
--- PASS: TestAccAPIGatewayAuthorizer_basic (140.18s)
--- PASS: TestAccAPIGatewayAuthorizer_Zero_ttl (176.82s)
--- PASS: TestAccAPIGatewayAuthorizer_switchAuthType (218.59s)
--- PASS: TestAccAPIGatewayAuthorizer_switchAuthorizerTTL (232.19s)
--- PASS: TestAccAPIGatewayAuthorizer_cognito (304.67s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 12, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAPIGatewayAuthorizer_ PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayAuthorizer_'  -timeout 180m
=== RUN   TestAccAPIGatewayAuthorizer_basic
=== PAUSE TestAccAPIGatewayAuthorizer_basic
=== RUN   TestAccAPIGatewayAuthorizer_cognito
=== PAUSE TestAccAPIGatewayAuthorizer_cognito
=== RUN   TestAccAPIGatewayAuthorizer_Cognito_authorizerCredentials
=== PAUSE TestAccAPIGatewayAuthorizer_Cognito_authorizerCredentials
=== RUN   TestAccAPIGatewayAuthorizer_switchAuthType
=== PAUSE TestAccAPIGatewayAuthorizer_switchAuthType
=== RUN   TestAccAPIGatewayAuthorizer_switchAuthorizerTTL
=== PAUSE TestAccAPIGatewayAuthorizer_switchAuthorizerTTL
=== RUN   TestAccAPIGatewayAuthorizer_authTypeValidation
=== PAUSE TestAccAPIGatewayAuthorizer_authTypeValidation
=== RUN   TestAccAPIGatewayAuthorizer_Zero_ttl
=== PAUSE TestAccAPIGatewayAuthorizer_Zero_ttl
=== RUN   TestAccAPIGatewayAuthorizer_disappears
=== PAUSE TestAccAPIGatewayAuthorizer_disappears
=== CONT  TestAccAPIGatewayAuthorizer_basic
=== CONT  TestAccAPIGatewayAuthorizer_switchAuthorizerTTL
=== CONT  TestAccAPIGatewayAuthorizer_Cognito_authorizerCredentials
=== CONT  TestAccAPIGatewayAuthorizer_authTypeValidation
=== CONT  TestAccAPIGatewayAuthorizer_disappears
=== CONT  TestAccAPIGatewayAuthorizer_Zero_ttl
=== CONT  TestAccAPIGatewayAuthorizer_switchAuthType
=== CONT  TestAccAPIGatewayAuthorizer_cognito
--- PASS: TestAccAPIGatewayAuthorizer_cognito (55.35s)
--- PASS: TestAccAPIGatewayAuthorizer_disappears (86.11s)
--- PASS: TestAccAPIGatewayAuthorizer_basic (86.82s)
--- PASS: TestAccAPIGatewayAuthorizer_switchAuthType (151.04s)
--- PASS: TestAccAPIGatewayAuthorizer_switchAuthorizerTTL (183.25s)
--- PASS: TestAccAPIGatewayAuthorizer_authTypeValidation (261.38s)
--- PASS: TestAccAPIGatewayAuthorizer_Cognito_authorizerCredentials (279.40s)
--- PASS: TestAccAPIGatewayAuthorizer_Zero_ttl (457.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	464.292s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 45e3501 into hashicorp:main Feb 13, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 13, 2022
@DrFaust92 DrFaust92 deleted the apigw-auth-arn branch February 14, 2022 07:58
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants