Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_launch_configuration: add no_device option #23152

Merged
merged 7 commits into from
Mar 15, 2022

Conversation

ColtonHerrod
Copy link
Contributor

@ColtonHerrod ColtonHerrod commented Feb 12, 2022

Adding a no_device option to ephemeral block devices in a launch configuration resource. This addresses issue 5464.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5464

Output from acceptance testing:

make testacc TESTS=TestAccAutoScalingLaunchConfiguration_basic PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingLaunchConfiguration_basic'  -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (39.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        39.473s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ColtonHerrod 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAutoScalingLaunchConfiguration_ PKG=autoscaling ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 5 -run='TestAccAutoScalingLaunchConfiguration_'  -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== RUN   TestAccAutoScalingLaunchConfiguration_Name_generated
=== PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated
=== RUN   TestAccAutoScalingLaunchConfiguration_namePrefix
=== PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix
=== RUN   TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== RUN   TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== RUN   TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== RUN   TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== RUN   TestAccAutoScalingLaunchConfiguration_withEncryption
=== PAUSE TestAccAutoScalingLaunchConfiguration_withEncryption
=== RUN   TestAccAutoScalingLaunchConfiguration_withGP3
=== PAUSE TestAccAutoScalingLaunchConfiguration_withGP3
=== RUN   TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== RUN   TestAccAutoScalingLaunchConfiguration_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions
=== RUN   TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== CONT  TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== CONT  TestAccAutoScalingLaunchConfiguration_userData
=== CONT  TestAccAutoScalingLaunchConfiguration_EBS_noDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (47.75s)
=== CONT  TestAccAutoScalingLaunchConfiguration_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (47.77s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (56.02s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withSpotPrice
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (78.96s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (37.73s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
--- PASS: TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices (86.92s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withBlockDevices
--- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (38.30s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (42.62s)
=== CONT  TestAccAutoScalingLaunchConfiguration_namePrefix
--- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (40.65s)
=== CONT  TestAccAutoScalingLaunchConfiguration_Name_generated
--- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (39.06s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withEncryption
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (75.16s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withGP3
--- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (40.26s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withIAMProfile
--- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (39.74s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withEncryption (42.01s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (37.58s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (55.84s)
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (401.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	452.962s

@ewbankkit
Copy link
Contributor

@ColtonHerrod Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8b9d168 into hashicorp:main Mar 15, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 15, 2022
@ColtonHerrod ColtonHerrod deleted the f-aws_launch_config branch March 16, 2022 18:23
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_device support for aws_launch_config device block definition
3 participants