Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for third party S3 #23278

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Improve support for third party S3 #23278

merged 4 commits into from
Feb 18, 2022

Conversation

wilfriedroset
Copy link
Contributor

@wilfriedroset wilfriedroset commented Feb 18, 2022 •
edited by anGie44
Loading

Third party S3 might reply NotImplemented error when creating a
bucket. This error prevent the successful apply of the plan.

Example when checking policy:

╷
│ Error: error getting S3 bucket ([redacted]) policy: NotImplemented: The requested resource is not implemented
│       status code: 501, request id: [redacted], host id: [redacted]
│
│   with aws_s3_bucket.lts,
│   on main.tf line 22, in resource "aws_s3_bucket" "lts":
│   22: resource "aws_s3_bucket" "lts" {
│
╵

Example when checking for payment:

╷
│ Error: error getting S3 Bucket request payment: NotImplemented: The requested resource is not implemented
│       status code: 501, request id: txc25b2f0fe509409081b8b-00620fcb0c, host id: txc25b2f0fe509409081b8b-00620fcb0c
│
│   with aws_s3_bucket.lts,
│   on main.tf line 23, in resource "aws_s3_bucket" "lts":
│   23: resource "aws_s3_bucket" "lts" {
│
╵

Closes #14645
Closes #13726

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

❯ terraform apply -no-color --auto-approve
Warning: Provider development overrides are in effect

The following provider development overrides are set in the CLI configuration:
 - hashicorp/aws in /Users/wroset/workspace/go/src/github.com/hashicorp/terraform-provider-aws

The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_s3_bucket.lts will be created
  + resource "aws_s3_bucket" "lts" {
      + acceleration_status                  = (known after apply)
      + acl                                  = (known after apply)
      + arn                                  = (known after apply)
      + bucket                               = "[redacted]"
      + bucket_domain_name                   = (known after apply)
      + bucket_regional_domain_name          = (known after apply)
      + cors_rule                            = (known after apply)
      + force_destroy                        = false
      + grant                                = (known after apply)
      + hosted_zone_id                       = (known after apply)
      + id                                   = (known after apply)
      + lifecycle_rule                       = (known after apply)
      + logging                              = (known after apply)
      + policy                               = (known after apply)
      + region                               = (known after apply)
      + replication_configuration            = (known after apply)
      + request_payer                        = (known after apply)
      + server_side_encryption_configuration = (known after apply)
      + tags_all                             = (known after apply)
      + versioning                           = (known after apply)
      + website                              = (known after apply)
      + website_domain                       = (known after apply)
      + website_endpoint                     = (known after apply)

      + object_lock_configuration {
          + object_lock_enabled = (known after apply)
          + rule                = (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.
aws_s3_bucket.lts: Creating...
aws_s3_bucket.lts: Creation complete after 1s [id=[redacted]]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
❯ terraform destroy -no-color --auto-approve
Warning: Provider development overrides are in effect

The following provider development overrides are set in the CLI configuration:
 - hashicorp/aws in /Users/wroset/workspace/go/src/github.com/hashicorp/terraform-provider-aws

The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
aws_s3_bucket.lts: Refreshing state... [id=[redacted]]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # aws_s3_bucket.lts will be destroyed
  - resource "aws_s3_bucket" "lts" {
      - acl                                  = "private" -> null
      - arn                                  = "arn::s3:::[redacted]" -> null
      - bucket                               = "[redacted]" -> null
      - bucket_domain_name                   = "[redacted].s3.amazonaws.com" -> null
      - bucket_regional_domain_name          = "[redacted].s3.amazonaws.com" -> null
      - cors_rule                            = [] -> null
      - force_destroy                        = false -> null
      - grant                                = [] -> null
      - hosted_zone_id                       = "Z3AQBSTGFYJSTF" -> null
      - id                                   = "[redacted]" -> null
      - lifecycle_rule                       = [] -> null
      - logging                              = [] -> null
      - region                               = "us-east-1" -> null
      - replication_configuration            = [
          - {
              - role  = null
              - rules = null
            },
        ] -> null
      - server_side_encryption_configuration = [
          - {
              - rule = []
            },
        ] -> null
      - tags                                 = {} -> null
      - tags_all                             = {} -> null
      - versioning                           = [
          - {
              - enabled    = false
              - mfa_delete = false
            },
        ] -> null
      - website                              = [] -> null

      - object_lock_configuration {
          - rule = [] -> null
        }
    }

Plan: 0 to add, 0 to change, 1 to destroy.
aws_s3_bucket.lts: Destroying... [id=[redacted]]
aws_s3_bucket.lts: Destruction complete after 0s

Destroy complete! Resources: 1 destroyed.

@wilfriedroset
Improve support for third party S3
416a958 
Third party S3 might reply `NotImplemented` error when creating a
bucket. This error prevent the successful apply of the plan.

Example when checking policy:
```
╷
│ Error: error getting S3 bucket ([redacted]) policy: NotImplemented: The requested resource is not implemented
│       status code: 501, request id: [redacted], host id: [redacted]
│
│   with aws_s3_bucket.lts,
│   on main.tf line 22, in resource "aws_s3_bucket" "lts":
│   22: resource "aws_s3_bucket" "lts" {
│
╵
```

Example when checking for payment:
```
╷
│ Error: error getting S3 Bucket request payment: NotImplemented: The requested resource is not implemented
│       status code: 501, request id: txc25b2f0fe509409081b8b-00620fcb0c, host id: txc25b2f0fe509409081b8b-00620fcb0c
│
│   with aws_s3_bucket.lts,
│   on main.tf line 23, in resource "aws_s3_bucket" "lts":
│   23: resource "aws_s3_bucket" "lts" {
│
╵
```

Closes: hashicorp#14645, hashicorp#13726

Signed-off-by: Wilfried Roset <[email protected]>
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 18, 2022
@wilfriedroset
Copy link
Contributor Author

I've no AWS account available to run acceptance tests but all unit tests are successful

~/.../github.com/hashicorp/terraform-provider-aws [third-party-s3|✔] $ make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
go: downloading github.com/pquerna/otp v1.3.0
go: downloading github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
?       github.com/hashicorp/terraform-provider-aws     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/acctest    3.309s
?       github.com/hashicorp/terraform-provider-aws/internal/attrmap    [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/conns      0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/create     0.012s
ok      github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable      0.005s
?       github.com/hashicorp/terraform-provider-aws/internal/experimental/sync  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/flex       0.013s
ok      github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters 0.159s
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   0.047s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     0.111s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    0.187s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acm        3.863s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     9.492s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        0.067s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    0.163s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 2.699s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       0.920s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling     0.101s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  0.067s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    0.083s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  0.076s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  0.119s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    0.185s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena     0.120s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        0.088s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans   0.131s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     0.210s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      0.175s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      0.114s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloud9     0.130s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol       0.116s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation     0.155s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 1.208s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2 0.099s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        0.104s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 0.071s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 0.110s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs     0.104s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact       0.129s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  0.096s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecommit 0.168s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codedeploy 0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       0.495s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections        0.079s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications      0.129s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    0.149s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 0.129s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/configservice      0.121s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        0.114s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange       0.115s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       0.137s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   0.111s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dax        0.094s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  0.171s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm 0.184s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      1.005s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dlm        0.172s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        0.124s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdb      0.259s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 0.138s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   0.791s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        18.239s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        0.111s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic  0.104s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        0.171s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        0.077s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        0.538s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        1.363s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk   0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch      0.981s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder  0.093s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        1.226s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      4.617s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        0.093s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     0.107s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   0.087s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        0.663s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        0.093s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   0.106s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glacier    0.097s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  0.157s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       0.322s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/grafana    0.096s
?       github.com/hashicorp/terraform-provider-aws/internal/service/greengrass [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  0.106s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        2.752s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      0.120s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       0.272s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector  0.071s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        0.059s
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics       [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotevents  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      0.118s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect       0.108s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    0.080s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics   0.106s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2 0.071s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo       0.081s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        1.116s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      0.086s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     0.118s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels  0.117s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager     0.100s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  0.337s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie      0.173s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     0.334s
?       github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert       0.127s
?       github.com/hashicorp/terraform-provider-aws/internal/service/medialive  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage       0.148s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediastore 0.077s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   0.090s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       0.265s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 0.150s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       0.248s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    0.099s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    0.189s
?       github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opsworks   0.119s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      0.679s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/outposts   0.161s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint   0.079s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pricing    0.157s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/qldb       0.099s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 0.093s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        0.465s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1.156s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   0.186s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups     0.094s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi   0.082s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    0.361s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig       0.089s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness   0.070s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    0.296s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 1.930s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  0.410s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 0.072s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  0.213s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/schemas    0.119s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     0.420s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        0.461s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo     0.123s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     0.274s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   0.186s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      0.094s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        0.091s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        0.183s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     0.084s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/signer     0.152s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   0.100s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        0.059s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sqs        0.154s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        0.133s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   0.077s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway     0.177s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        0.112s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/swf        0.132s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 0.125s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite    0.089s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   0.139s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/waf        0.135s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafregional        0.109s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      0.149s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/worklink   0.061s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 0.084s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       0.119s
ok      github.com/hashicorp/terraform-provider-aws/internal/tags       0.012s
ok      github.com/hashicorp/terraform-provider-aws/internal/tfresource 26.523s
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys       0.518s
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil  0.001s
ok      github.com/hashicorp/terraform-provider-aws/internal/verify     0.014s
?       github.com/hashicorp/terraform-provider-aws/version     [no test files]

github-actions[bot]
github-actions bot reviewed Feb 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @wilfriedroset 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 18, 2022
@anGie44 anGie44 self-assigned this Feb 18, 2022
@anGie44
Copy link
Contributor

anGie44 commented Feb 18, 2022

Hi @wilfriedroset , thank you for raising this PR! overall it looks great, we just need to add in a changelog file so I'll do so in an upcoming commit and see if we can additionally account for the err code mentioned in #14645 while we are here 😄

@gdavison gdavison added this to the v4.2.0 milestone Feb 18, 2022
anGie44
anGie44 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for this PR @wilfriedroset , LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (20.28s)
--- PASS: TestAccS3Bucket_Basic_basic (22.05s)
--- PASS: TestAccS3Bucket_Manage_objectLock (22.44s)
--- PASS: TestAccS3Bucket_Tags_basic (23.92s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (25.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (18.20s)
--- PASS: TestAccS3Bucket_Basic_generatedName (20.20s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (24.61s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (14.66s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (36.50s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (20.37s)
--- PASS: TestAccS3Bucket_Basic_emptyString (20.77s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (70.26s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (115.82s)

@anGie44 anGie44 merged commit d4b6c38 into hashicorp:main Feb 18, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@rslinckx
Copy link

It seems in my flavor of third-party "S3 compatible" API, the bucket logging returns a not implemented error:

Error: error getting S3 Bucket logging: NotImplemented: A header you provided implies functionality that is not implemented.
status code: 501, request id: 4a27bba2bf46b5272ae4, host id: 4a27bba2bf46b5272ae4

Would it be possible to add the same logic as those other endpoints as well ?

wilfriedroset added a commit to wilfriedroset/terraform-provider-aws that referenced this pull request Feb 26, 2022
@wilfriedroset
Add XNotEmplemented error handling in GetBucketLogging
1489a45 
Relates to hashicorp#23278

Signed-off-by: Wilfried Roset <[email protected]>
@wilfriedroset wilfriedroset mentioned this pull request Feb 26, 2022
Merged
@wilfriedroset
Copy link
Contributor Author

@rslinckx this should do it #23398

This was referenced Mar 11, 2022
Closed
Closed
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.2.0
4 participants
@wilfriedroset @anGie44 @rslinckx @gdavison