Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_ec2_serial_console_access #23443

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Add aws_ec2_serial_console_access #23443

merged 5 commits into from
Mar 3, 2022

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Mar 1, 2022

Based on the aws_ebs_encryption_by_default resource & data source.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18503

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2SerialConsoleAccess PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SerialConsoleAccess'  -timeout 180m
=== RUN   TestAccEC2SerialConsoleAccessDataSource_basic
=== PAUSE TestAccEC2SerialConsoleAccessDataSource_basic
=== RUN   TestAccEC2SerialConsoleAccess_basic
=== PAUSE TestAccEC2SerialConsoleAccess_basic
=== CONT  TestAccEC2SerialConsoleAccessDataSource_basic
=== CONT  TestAccEC2SerialConsoleAccess_basic
--- PASS: TestAccEC2SerialConsoleAccessDataSource_basic (7.00s)
--- PASS: TestAccEC2SerialConsoleAccess_basic (15.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	16.856s

@bodgit
Add aws_ec2_serial_console_access
32227df 
Based on the aws_ebs_encryption_by_default resource & data source.

Fixes hashicorp#18503
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. labels Mar 1, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 1, 2022
@bodgit bodgit mentioned this pull request Mar 1, 2022
Closed
ewbankkit
ewbankkit approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commercial
% make testacc TESTS=TestAccEC2SerialConsoleAccess_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SerialConsoleAccess_'  -timeout 180m
=== RUN   TestAccEC2SerialConsoleAccess_basic
=== PAUSE TestAccEC2SerialConsoleAccess_basic
=== CONT  TestAccEC2SerialConsoleAccess_basic
--- PASS: TestAccEC2SerialConsoleAccess_basic (35.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	40.896s
% make testacc TESTS=TestAccEC2SerialConsoleAccessDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SerialConsoleAccessDataSource_'  -timeout 180m
=== RUN   TestAccEC2SerialConsoleAccessDataSource_basic
=== PAUSE TestAccEC2SerialConsoleAccessDataSource_basic
=== CONT  TestAccEC2SerialConsoleAccessDataSource_basic
--- PASS: TestAccEC2SerialConsoleAccessDataSource_basic (15.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	21.093s
GovCloud
% make testacc TESTS=TestAccEC2SerialConsoleAccess_ PKG=ec2                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SerialConsoleAccess_'  -timeout 180m
=== RUN   TestAccEC2SerialConsoleAccess_basic
=== PAUSE TestAccEC2SerialConsoleAccess_basic
=== CONT  TestAccEC2SerialConsoleAccess_basic
--- PASS: TestAccEC2SerialConsoleAccess_basic (35.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	40.417s
% make testacc TESTS=TestAccEC2SerialConsoleAccessDataSource_ PKG=ec2                                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SerialConsoleAccessDataSource_'  -timeout 180m
=== RUN   TestAccEC2SerialConsoleAccessDataSource_basic
=== PAUSE TestAccEC2SerialConsoleAccessDataSource_basic
=== CONT  TestAccEC2SerialConsoleAccessDataSource_basic
--- PASS: TestAccEC2SerialConsoleAccessDataSource_basic (15.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	21.149s

@ewbankkit
Copy link
Contributor

@bodgit Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added new-data-source Introduces a new data source. new-resource Introduces a new resource. labels Mar 3, 2022
@ewbankkit ewbankkit merged commit 9af0841 into hashicorp:main Mar 3, 2022
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 3, 2022
@bodgit bodgit deleted the issue18503 branch March 4, 2022 13:45
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging this pull request may close these issues.

Enable EC2 Serial Console access
2 participants
@bodgit @ewbankkit