Add resources for ComputeOptimizer Recommendation Preferences

[chrisgilmerproj]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS has a service named AWS Compute Optimizer. It allows you to turn on enhanced infrastructure metrics for EC2 instances and Auto Scaling Groups. To do so you have to use the AWS CLI computeoptimizer put-recommendation-preferences command or manage these preferences manually in the AWS Console. I would like to see a resource in terraform aws provider that let's me manage this.

There is already a Golang API in the SDK for Compute Optimizer.

New or Affected Resource(s)

• aws_computeoptimizer_recommendation_preferences

Potential Terraform Configuration

resource "aws_computeoptimizer_recommendation_preferences" "prefs" {
  enchanced_infrastructure_metrics = "Active" # default
  inferred_workload_types          = "Active" # default
  resource_type                    = "AutoScalingGroup"
  scope = {
    name  = "ResourceARN"
    value = aws_autoscaling_group.web.arn
  }
}

References

• https://awscli.amazonaws.com/v2/documentation/api/latest/reference/compute-optimizer/put-recommendation-preferences.html
• https://docs.aws.amazon.com/sdk-for-go/api/service/computeoptimizer/#ComputeOptimizer.PutRecommendationPreferences
• https://aws.amazon.com/compute-optimizer/

[f0xtek]

Hello.

As per Pull Request 27310, the AWS Compute Optimizer service was added to v4.36.0 of this AWS provider.

However, the change log for that release, or any releases since, don't appear to have added support for that service. The Terraform AWS provider documentation also does not have this service available.

Am I missing something? Or was this functionality not included in the provider?

[iancoralogix]

Hello @f0xtek, I just wanted to confirm that I cannot see this functionality in the v4.57.1 provider, thank you!

[sahaqaa]

Please advice - does Terraform AWS provider supports AWS Compute Optimizer?

[nicolaei]

From what I can see in #27310, @sasidhar-aws didn't actually add any resources 🤔

The PR only adds the Compute Optimizer SDK as a dependency and configures it. The only thing present in the compute optimizer package is a README.md and some generated files.

[hunttom]

I would like to try to solve this.

[hunttom]

Status update - Sorry for the delay. I've opened a PR request, I have some open questions prior to a merge with main branch.

Questions can be seen here: #35349.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.