-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elasticache/aws_elasticache_cluster: Enable auto_minor_version_upgrade
#23996
Conversation
…test and removes `auto_minor_version_upgrade` values from unrelated tests
…plication_group`
2fdb044
to
e59480e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_memcached\|TestAccElastiCacheCluster_Engine_redis_v5\|TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_basic_v5\|TestAccElastiCacheReplicationGroup_uppercase\|TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade' PKG=elasticache ACCTEST_PARALLELISM=2 ACCTEST_TIMEOUT=720m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheCluster_Engine_memcached\|TestAccElastiCacheCluster_Engine_redis_v5\|TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_basic_v5\|TestAccElastiCacheReplicationGroup_uppercase\|TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade -timeout 720m
=== RUN TestAccElastiCacheCluster_Engine_memcached
=== PAUSE TestAccElastiCacheCluster_Engine_memcached
=== RUN TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== RUN TestAccElastiCacheReplicationGroup_basic
=== PAUSE TestAccElastiCacheReplicationGroup_basic
=== RUN TestAccElastiCacheReplicationGroup_basic_v5
=== PAUSE TestAccElastiCacheReplicationGroup_basic_v5
=== RUN TestAccElastiCacheReplicationGroup_uppercase
=== PAUSE TestAccElastiCacheReplicationGroup_uppercase
=== RUN TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== CONT TestAccElastiCacheCluster_Engine_memcached
=== CONT TestAccElastiCacheReplicationGroup_basic_v5
--- PASS: TestAccElastiCacheCluster_Engine_memcached (474.93s)
=== CONT TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (693.76s)
=== CONT TestAccElastiCacheReplicationGroup_basic
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (536.72s)
=== CONT TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheReplicationGroup_basic (704.76s)
=== CONT TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (493.52s)
=== CONT TestAccElastiCacheReplicationGroup_uppercase
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (708.25s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (844.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 2247.896s
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Enables
auto_minor_version_upgrade
foraws_elasticache_cluster
and properly supportsauto_minor_version_upgrade
foraws_elasticache_replication_group
.Relates #22385
Output from acceptance testing: