Iot domain name configuration

[jalavoy]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22654

Output from acceptance testing:
Using an example domain name I can't get the acceptance test to pass, but it's because of AWS returning the following error, which seems specific to them:

Cannot provide a custom domain name for an AWS Managed Domain

However, after building the provider and using it from my production terraform repo, it appears to work fine. Not sure the best way to handle this, as I'm not sure exactly what AWS is testing the domain against.

TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIotDomainNameConfiguration'  -timeout 180m
=== RUN   TestAccIotDomainNameConfiguration
    domain_name_configuration_test.go:14: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating IoT Domain Configuration (test): InvalidRequestException: Cannot provide a custom domain name for an AWS Managed Domain
        
          with aws_iot_domain_name_configuration.iot,
          on terraform_plugin_test.tf line 2, in resource "aws_iot_domain_name_configuration" "iot":
           2:   resource "aws_iot_domain_name_configuration" "iot" {
        
--- FAIL: TestAccIotDomainNameConfiguration (7.53s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/iot        11.062s
FAIL
make: *** [testacc] Error 1

Output from my terraform:

Terraform will perform the following actions:

  # aws_iot_domain_name_configuration.iot will be created
  + resource "aws_iot_domain_name_configuration" "iot" {
      + domain_name             = "REDACTED"
      + id                      = (known after apply)
      + name                    = "REDACTED"
      + server_certificate_arns = [
          + "REDACTED",
        ]
      + service_type            = "DATA"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
aws_iot_domain_name_configuration.iot: Creating...
aws_iot_domain_name_configuration.iot: Creation complete after 0s [id=REDACTED]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

If y'all have any input on how I can improve my test I'm open to it. I'm still new at working on this code. If it's acceptable to remove the test since it works outside of testing I'm fine with that too.

I'm also not positive I did the tagging stuff right. Super open to input on that.

[ewbankkit]

LGTM 🚀.

% ACM_CERTIFICATE_ROOT_DOMAIN=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccIoTDomainConfiguration_' PKG=iot ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 1  -run=TestAccIoTDomainConfiguration_ -timeout 360m
=== RUN   TestAccIoTDomainConfiguration_basic
--- PASS: TestAccIoTDomainConfiguration_basic (108.34s)
=== RUN   TestAccIoTDomainConfiguration_disappears
--- PASS: TestAccIoTDomainConfiguration_disappears (133.20s)
=== RUN   TestAccIoTDomainConfiguration_tags
--- PASS: TestAccIoTDomainConfiguration_tags (175.62s)
=== RUN   TestAccIoTDomainConfiguration_update
--- PASS: TestAccIoTDomainConfiguration_update (152.94s)
=== RUN   TestAccIoTDomainConfiguration_awsManaged
    acctest.go:2450: Environment variable IOT_DOMAIN_CONFIGURATION_TEST_AWS_MANAGED is not set, skipping test
--- SKIP: TestAccIoTDomainConfiguration_awsManaged (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        466.800s

[ewbankkit]

@jalavoy Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.