-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dual stack support to Global Accelerator #26055
Add dual stack support to Global Accelerator #26055
Conversation
…e to reflect all address types
This PR is pending the aws-sdk-go update to 1.44.64 |
…to include second set of IPv4 addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAccelerator_basic\|TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack' PKG=globalaccelerator ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2 -run=TestAccGlobalAcceleratorAccelerator_basic\|TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack -timeout 180m
=== RUN TestAccGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorAccelerator_basic
=== RUN TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== PAUSE TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== CONT TestAccGlobalAcceleratorAccelerator_basic
=== CONT TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
--- PASS: TestAccGlobalAcceleratorAccelerator_basic (68.56s)
--- PASS: TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack (74.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator 78.959s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #26023
Output from acceptance testing: