-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/aws s3 bucket object lock configuration #26520
F/aws s3 bucket object lock configuration #26520
Conversation
@nikhil-goenka, could you please squash this PR, there are 10,000 commits. Also please add a changelog entry |
added changelog |
2f6be13
to
db55129
Compare
…LockConfiguration_noRule'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3BucketObjectLockConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3BucketObjectLockConfiguration_ -timeout 180m
=== RUN TestAccS3BucketObjectLockConfiguration_basic
=== PAUSE TestAccS3BucketObjectLockConfiguration_basic
=== RUN TestAccS3BucketObjectLockConfiguration_disappears
=== PAUSE TestAccS3BucketObjectLockConfiguration_disappears
=== RUN TestAccS3BucketObjectLockConfiguration_update
=== PAUSE TestAccS3BucketObjectLockConfiguration_update
=== RUN TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== RUN TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== RUN TestAccS3BucketObjectLockConfiguration_noRule
=== PAUSE TestAccS3BucketObjectLockConfiguration_noRule
=== CONT TestAccS3BucketObjectLockConfiguration_basic
=== CONT TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== CONT TestAccS3BucketObjectLockConfiguration_noRule
--- PASS: TestAccS3BucketObjectLockConfiguration_noRule (25.62s)
=== CONT TestAccS3BucketObjectLockConfiguration_update
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (25.97s)
=== CONT TestAccS3BucketObjectLockConfiguration_migrate_withChange
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_noChange (38.31s)
=== CONT TestAccS3BucketObjectLockConfiguration_disappears
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (24.64s)
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_withChange (41.05s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (43.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 73.074s
@nikhil-goenka Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25070
Output from acceptance testing: