-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add missing functionality for AppFlow Custom Connector #26766
feat: Add missing functionality for AppFlow Custom Connector #26766
Conversation
Fixes #26665 |
What is needed to move this PR forward? @justinretzolk |
What more is required for this to be merged? |
I was told it isn't priority. We are having luck using the AWS Cloud Control provider. |
Thanks, @dude0001 for the update. Here's a current link for anyone who comes along: https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/appflow_connector_profile |
0718c48
to
1a405ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccAppFlowConnectorProfile_' PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run=TestAccAppFlowConnectorProfile_ -timeout 180m
=== RUN TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT TestAccAppFlowConnectorProfile_basic
=== CONT TestAccAppFlowConnectorProfile_disappears
=== CONT TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (241.82s)
--- PASS: TestAccAppFlowConnectorProfile_update (251.30s)
--- PASS: TestAccAppFlowConnectorProfile_basic (298.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appflow 301.382s
@daniepett thanks for the contribution 👏🏾 🎉 |
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adding functionality of AppFlow Custom Connector to match the docs. In the current state the Custom Connector resource always returns empty values and fails on create.
Community Note
Relates #26665
Closes #26780
Output from acceptance testing: