Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Include terraform support to create Amazon OpenSearch Service-managed VPC endpoint #27978

Closed
luvsaxena1 opened this issue Nov 23, 2022 · 9 comments · Fixed by #33925
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Milestone

Comments

@luvsaxena1
Copy link

Description

This is the request for terraform to support creation of Amazon OpenSearch Service-managed VPC endpoint (link)
and support access to an Amazon OpenSearch Service domain through the use of an interface VPC endpoint.
(linkj)

Affected Resource(s) and/or Data Source(s)

aws_elasticsearch_domain
aws_elasticsearch_domain_saml_options
aws_elasticsearch_domain_policy

Potential Terraform Configuration

resource "aws_elasticsearch_domain" "example" {
  domain_name           = "example"
  elasticsearch_version = "7.10"

  authorize_vpc_endpoint_access {
    domain_name           = "example"
    "AuthorizedPrincipal" = [ 
     "account_id1",
     "account_id2"
   }
  }

resource "aws_elasticsearch_vpc_endpoint" "vpc-endpoint" {
   "DomainArn" = "string",
   vpc_options {
    subnet_ids = [
      "subnet1",
      "subnet2"
    ]
    security_group_ids = [security_group_id]
  }
   }
}

References

Would you like to implement a fix?

No

@luvsaxena1 luvsaxena1 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2022
@github-actions github-actions bot added the service/elasticsearch Issues and PRs that pertain to the elasticsearch service. label Nov 23, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@TheJacobWalters
Copy link

I am interested in working on this.

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Nov 24, 2022
@benclapp
Copy link

I wonder if this enhancement should also be included for the paired/similar aws_opensearch_domain type resources?

@tomfankhaenel
Copy link

It would be very good to have this feature. Currently this part is handled by a null_resource and very buggy.

@raffraffraff
Copy link

@tomfankhaenel would you be happy to share your null_resource solution? I'm working on this right now in a multi-account setup. I can authorize other AWS accounts to access OpenSearch, and I can create OpenSearch VPC endpoints multiple AWS accounts. I haven't worked out the destroy operation yet, but I hope to get that fixed this week, if I get time. I'm happy to share my hack once I get that done. I think it might be worthwhile producing some type of hacky solution because, to be perfectly honest, it doesn't look like this is going to make it into the AWS Provider any time soon.

@mattburgess
Copy link
Collaborator

Looks like this was fixed back in v5.13.0. PR #32435 was marked as resolving the duplicate of this ticket, #29912, but didn't mention this one, so this one's been left as unresolved.

@mikekinlock
Copy link
Contributor

I should have some spare time and will work on this task.

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 13, 2023
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 16, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Projects
None yet
9 participants