Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Managed Rule Group Config functionality to WAFv2 resource #28594

Merged

Conversation

dbell-infra
Copy link

@dbell-infra dbell-infra commented Dec 27, 2022

Description

This PR implements Managed Rule Group Config support for the WAFv2 Resource to enable the usage of ATP and BotControl WAF rules within terraform.

Example Configuration:

    statement {
      managed_rule_group_statement {
        name        = "AWSManagedRulesATPRuleSet"
        vendor_name = "AWS"

        managed_rule_group_config {
          login_path     = "/login-test"
          password_field = "/password"
          payload_type   = "JSON"
          username_field = "/username"
        }
      }

Relations

Closes #23290
Closes #26826
Closes #23287

References

https://docs.aws.amazon.com/waf/latest/developerguide/aws-managed-rule-groups-bot.html
https://docs.aws.amazon.com/waf/latest/developerguide/aws-managed-rule-groups-atp.html
https://docs.aws.amazon.com/waf/latest/APIReference/API_ManagedRuleGroupConfig.html

Output from Acceptance Testing

❯ make testacc PKG=wafv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccWAFV2IPSetDataSource_basic
=== PAUSE TestAccWAFV2IPSetDataSource_basic
=== RUN   TestAccWAFV2IPSet_basic
=== PAUSE TestAccWAFV2IPSet_basic
=== RUN   TestAccWAFV2IPSet_disappears
=== PAUSE TestAccWAFV2IPSet_disappears
=== RUN   TestAccWAFV2IPSet_ipv6
=== PAUSE TestAccWAFV2IPSet_ipv6
=== RUN   TestAccWAFV2IPSet_minimal
=== PAUSE TestAccWAFV2IPSet_minimal
=== RUN   TestAccWAFV2IPSet_changeNameForceNew
=== PAUSE TestAccWAFV2IPSet_changeNameForceNew
=== RUN   TestAccWAFV2IPSet_tags
=== PAUSE TestAccWAFV2IPSet_tags
=== RUN   TestAccWAFV2IPSet_large
=== PAUSE TestAccWAFV2IPSet_large
=== RUN   TestAccWAFV2RegexPatternSetDataSource_basic
=== PAUSE TestAccWAFV2RegexPatternSetDataSource_basic
=== RUN   TestAccWAFV2RegexPatternSet_basic
=== PAUSE TestAccWAFV2RegexPatternSet_basic
=== RUN   TestAccWAFV2RegexPatternSet_disappears
=== PAUSE TestAccWAFV2RegexPatternSet_disappears
=== RUN   TestAccWAFV2RegexPatternSet_minimal
=== PAUSE TestAccWAFV2RegexPatternSet_minimal
=== RUN   TestAccWAFV2RegexPatternSet_changeNameForceNew
=== PAUSE TestAccWAFV2RegexPatternSet_changeNameForceNew
=== RUN   TestAccWAFV2RegexPatternSet_tags
=== PAUSE TestAccWAFV2RegexPatternSet_tags
=== RUN   TestAccWAFV2RuleGroupDataSource_basic
=== PAUSE TestAccWAFV2RuleGroupDataSource_basic
=== RUN   TestAccWAFV2RuleGroup_basic
=== PAUSE TestAccWAFV2RuleGroup_basic
=== RUN   TestAccWAFV2RuleGroup_updateRule
=== PAUSE TestAccWAFV2RuleGroup_updateRule
=== RUN   TestAccWAFV2RuleGroup_updateRuleProperties
=== PAUSE TestAccWAFV2RuleGroup_updateRuleProperties
=== RUN   TestAccWAFV2RuleGroup_byteMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_byteMatchStatement
=== RUN   TestAccWAFV2RuleGroup_ByteMatchStatement_fieldToMatch
=== PAUSE TestAccWAFV2RuleGroup_ByteMatchStatement_fieldToMatch
=== RUN   TestAccWAFV2RuleGroup_changeNameForceNew
=== PAUSE TestAccWAFV2RuleGroup_changeNameForceNew
=== RUN   TestAccWAFV2RuleGroup_changeCapacityForceNew
=== PAUSE TestAccWAFV2RuleGroup_changeCapacityForceNew
=== RUN   TestAccWAFV2RuleGroup_changeMetricNameForceNew
=== PAUSE TestAccWAFV2RuleGroup_changeMetricNameForceNew
=== RUN   TestAccWAFV2RuleGroup_disappears
=== PAUSE TestAccWAFV2RuleGroup_disappears
=== RUN   TestAccWAFV2RuleGroup_RuleLabels
=== PAUSE TestAccWAFV2RuleGroup_RuleLabels
=== RUN   TestAccWAFV2RuleGroup_geoMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_geoMatchStatement
=== RUN   TestAccWAFV2RuleGroup_GeoMatchStatement_forwardedIP
=== PAUSE TestAccWAFV2RuleGroup_GeoMatchStatement_forwardedIP
=== RUN   TestAccWAFV2RuleGroup_LabelMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_LabelMatchStatement
=== RUN   TestAccWAFV2RuleGroup_ipSetReferenceStatement
=== PAUSE TestAccWAFV2RuleGroup_ipSetReferenceStatement
=== RUN   TestAccWAFV2RuleGroup_IPSetReferenceStatement_ipsetForwardedIP
=== PAUSE TestAccWAFV2RuleGroup_IPSetReferenceStatement_ipsetForwardedIP
=== RUN   TestAccWAFV2RuleGroup_logicalRuleStatements
=== PAUSE TestAccWAFV2RuleGroup_logicalRuleStatements
=== RUN   TestAccWAFV2RuleGroup_minimal
=== PAUSE TestAccWAFV2RuleGroup_minimal
=== RUN   TestAccWAFV2RuleGroup_regexMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_regexMatchStatement
=== RUN   TestAccWAFV2RuleGroup_regexPatternSetReferenceStatement
=== PAUSE TestAccWAFV2RuleGroup_regexPatternSetReferenceStatement
=== RUN   TestAccWAFV2RuleGroup_ruleAction
=== PAUSE TestAccWAFV2RuleGroup_ruleAction
=== RUN   TestAccWAFV2RuleGroup_RuleAction_customRequestHandling
=== PAUSE TestAccWAFV2RuleGroup_RuleAction_customRequestHandling
=== RUN   TestAccWAFV2RuleGroup_RuleAction_customResponse
=== PAUSE TestAccWAFV2RuleGroup_RuleAction_customResponse
=== RUN   TestAccWAFV2RuleGroup_sizeConstraintStatement
=== PAUSE TestAccWAFV2RuleGroup_sizeConstraintStatement
=== RUN   TestAccWAFV2RuleGroup_sqliMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_sqliMatchStatement
=== RUN   TestAccWAFV2RuleGroup_tags
=== PAUSE TestAccWAFV2RuleGroup_tags
=== RUN   TestAccWAFV2RuleGroup_xssMatchStatement
=== PAUSE TestAccWAFV2RuleGroup_xssMatchStatement
=== RUN   TestAccWAFV2RuleGroup_rateBasedStatement
=== PAUSE TestAccWAFV2RuleGroup_rateBasedStatement
=== RUN   TestAccWAFV2RuleGroup_RateBased_maxNested
=== PAUSE TestAccWAFV2RuleGroup_RateBased_maxNested
=== RUN   TestAccWAFV2RuleGroup_Operators_maxNested
=== PAUSE TestAccWAFV2RuleGroup_Operators_maxNested
=== RUN   TestAccWAFV2WebACLAssociation_basic
=== PAUSE TestAccWAFV2WebACLAssociation_basic
=== RUN   TestAccWAFV2WebACLAssociation_disappears
=== PAUSE TestAccWAFV2WebACLAssociation_disappears
=== RUN   TestAccWAFV2WebACLDataSource_basic
=== PAUSE TestAccWAFV2WebACLDataSource_basic
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_basic
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_basic
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateSingleHeaderRedactedField
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateSingleHeaderRedactedField
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateMethodRedactedField
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateMethodRedactedField
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateQueryStringRedactedField
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateQueryStringRedactedField
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateURIPathRedactedField
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateURIPathRedactedField
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateMultipleRedactedFields
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateMultipleRedactedFields
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_changeResourceARNForceNew
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_changeResourceARNForceNew
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_changeLogDestinationsForceNew
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_changeLogDestinationsForceNew
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_disappears
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_disappears
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_emptyRedactedFields
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_emptyRedactedFields
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_updateEmptyRedactedFields
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_updateEmptyRedactedFields
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_Disappears_webACL
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_Disappears_webACL
=== RUN   TestAccWAFV2WebACLLoggingConfiguration_loggingFilter
=== PAUSE TestAccWAFV2WebACLLoggingConfiguration_loggingFilter
=== RUN   TestAccWAFV2WebACL_basic
=== PAUSE TestAccWAFV2WebACL_basic
=== RUN   TestAccWAFV2WebACL_Update_rule
=== PAUSE TestAccWAFV2WebACL_Update_rule
=== RUN   TestAccWAFV2WebACL_Update_ruleProperties
=== PAUSE TestAccWAFV2WebACL_Update_ruleProperties
=== RUN   TestAccWAFV2WebACL_Update_nameForceNew
=== PAUSE TestAccWAFV2WebACL_Update_nameForceNew
=== RUN   TestAccWAFV2WebACL_disappears
=== PAUSE TestAccWAFV2WebACL_disappears
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== RUN   TestAccWAFV2WebACL_minimal
=== PAUSE TestAccWAFV2WebACL_minimal
=== RUN   TestAccWAFV2WebACL_RateBased_basic
=== PAUSE TestAccWAFV2WebACL_RateBased_basic
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_basic
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_basic
=== RUN   TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
=== PAUSE TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
=== RUN   TestAccWAFV2WebACL_GeoMatch_basic
=== PAUSE TestAccWAFV2WebACL_GeoMatch_basic
=== RUN   TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== PAUSE TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== RUN   TestAccWAFV2WebACL_LabelMatchStatement
=== PAUSE TestAccWAFV2WebACL_LabelMatchStatement
=== RUN   TestAccWAFV2WebACL_RuleLabels
=== PAUSE TestAccWAFV2WebACL_RuleLabels
=== RUN   TestAccWAFV2WebACL_IPSetReference_basic
=== PAUSE TestAccWAFV2WebACL_IPSetReference_basic
=== RUN   TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== PAUSE TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== RUN   TestAccWAFV2WebACL_RateBased_forwardedIP
=== PAUSE TestAccWAFV2WebACL_RateBased_forwardedIP
=== RUN   TestAccWAFV2WebACL_RuleGroupReference_basic
=== PAUSE TestAccWAFV2WebACL_RuleGroupReference_basic
=== RUN   TestAccWAFV2WebACL_Custom_requestHandling
=== PAUSE TestAccWAFV2WebACL_Custom_requestHandling
=== RUN   TestAccWAFV2WebACL_Custom_response
=== PAUSE TestAccWAFV2WebACL_Custom_response
=== RUN   TestAccWAFV2WebACL_tags
=== PAUSE TestAccWAFV2WebACL_tags
=== RUN   TestAccWAFV2WebACL_RateBased_maxNested
=== PAUSE TestAccWAFV2WebACL_RateBased_maxNested
=== RUN   TestAccWAFV2WebACL_Operators_maxNested
=== PAUSE TestAccWAFV2WebACL_Operators_maxNested
=== CONT  TestAccWAFV2IPSetDataSource_basic
=== CONT  TestAccWAFV2RuleGroup_Operators_maxNested
=== CONT  TestAccWAFV2WebACL_Operators_maxNested
=== CONT  TestAccWAFV2WebACL_RateBased_maxNested
=== CONT  TestAccWAFV2WebACL_tags
=== CONT  TestAccWAFV2WebACL_Custom_response
=== CONT  TestAccWAFV2WebACL_Custom_requestHandling
=== CONT  TestAccWAFV2WebACL_RuleGroupReference_basic
=== CONT  TestAccWAFV2WebACL_RateBased_forwardedIP
=== CONT  TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== CONT  TestAccWAFV2WebACL_IPSetReference_basic
=== CONT  TestAccWAFV2WebACL_RuleLabels
=== CONT  TestAccWAFV2WebACL_LabelMatchStatement
=== CONT  TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateEmptyRedactedFields
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_emptyRedactedFields
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_disappears
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_changeLogDestinationsForceNew
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_changeResourceARNForceNew
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateMultipleRedactedFields
--- PASS: TestAccWAFV2IPSetDataSource_basic (60.03s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateURIPathRedactedField
--- PASS: TestAccWAFV2RuleGroup_Operators_maxNested (162.54s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateQueryStringRedactedField
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (184.04s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateMethodRedactedField
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (196.04s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_updateSingleHeaderRedactedField
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (231.40s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_Disappears_webACL
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_disappears (233.04s)
=== CONT  TestAccWAFV2WebACL_GeoMatch_basic
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_emptyRedactedFields (270.70s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_jsonBody
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (295.91s)
=== CONT  TestAccWAFV2WebACL_ByteMatchStatement_basic
--- PASS: TestAccWAFV2WebACL_RuleLabels (325.06s)
=== CONT  TestAccWAFV2WebACL_RateBased_basic
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (330.15s)
=== CONT  TestAccWAFV2WebACL_minimal
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (331.45s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateEmptyRedactedFields (378.10s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateURIPathRedactedField (331.84s)
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_basic
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_Disappears_webACL (175.81s)
=== CONT  TestAccWAFV2WebACL_disappears
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_changeLogDestinationsForceNew (456.67s)
=== CONT  TestAccWAFV2WebACL_Update_nameForceNew
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (465.64s)
=== CONT  TestAccWAFV2WebACL_Update_ruleProperties
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (470.95s)
=== CONT  TestAccWAFV2WebACL_Update_rule
--- PASS: TestAccWAFV2WebACL_tags (473.69s)
=== CONT  TestAccWAFV2WebACL_basic
--- PASS: TestAccWAFV2WebACL_Custom_response (475.44s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_basic
--- PASS: TestAccWAFV2WebACL_minimal (151.10s)
=== CONT  TestAccWAFV2WebACLLoggingConfiguration_loggingFilter
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateQueryStringRedactedField (329.45s)
=== CONT  TestAccWAFV2WebACLDataSource_basic
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_changeResourceARNForceNew (493.79s)
=== CONT  TestAccWAFV2WebACLAssociation_disappears
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateMultipleRedactedFields (497.38s)
=== CONT  TestAccWAFV2RuleGroup_changeMetricNameForceNew
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateMethodRedactedField (353.59s)
=== CONT  TestAccWAFV2WebACLAssociation_basic
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (307.68s)
=== CONT  TestAccWAFV2RuleGroup_RateBased_maxNested
--- PASS: TestAccWAFV2WebACL_disappears (140.20s)
=== CONT  TestAccWAFV2RuleGroup_rateBasedStatement
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (315.44s)
=== CONT  TestAccWAFV2RuleGroup_xssMatchStatement
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (592.37s)
=== CONT  TestAccWAFV2RuleGroup_logicalRuleStatements
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (310.36s)
=== CONT  TestAccWAFV2RuleGroup_minimal
--- PASS: TestAccWAFV2WebACL_basic (157.78s)
=== CONT  TestAccWAFV2RuleGroup_IPSetReferenceStatement_ipsetForwardedIP
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (308.36s)
=== CONT  TestAccWAFV2RuleGroup_tags
--- PASS: TestAccWAFV2WebACL_RateBased_basic (320.19s)
=== CONT  TestAccWAFV2RuleGroup_sqliMatchStatement
--- PASS: TestAccWAFV2WebACLDataSource_basic (165.77s)
=== CONT  TestAccWAFV2RuleGroup_sizeConstraintStatement
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_updateSingleHeaderRedactedField (474.42s)
=== CONT  TestAccWAFV2RuleGroup_regexPatternSetReferenceStatement
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_basic (210.65s)
=== CONT  TestAccWAFV2RuleGroup_ipSetReferenceStatement
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (310.70s)
=== CONT  TestAccWAFV2RuleGroup_regexMatchStatement
=== CONT  TestAccWAFV2RuleGroup_LabelMatchStatement
--- PASS: TestAccWAFV2RuleGroup_RateBased_maxNested (154.15s)
--- PASS: TestAccWAFV2RuleGroup_minimal (130.27s)
=== CONT  TestAccWAFV2RuleGroup_GeoMatchStatement_forwardedIP
--- PASS: TestAccWAFV2RuleGroup_changeMetricNameForceNew (245.82s)
=== CONT  TestAccWAFV2RuleGroup_geoMatchStatement
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (292.72s)
=== CONT  TestAccWAFV2RuleGroup_RuleLabels
--- PASS: TestAccWAFV2WebACLAssociation_basic (245.66s)
=== CONT  TestAccWAFV2RuleGroup_disappears
--- PASS: TestAccWAFV2WebACL_Update_rule (318.62s)
=== CONT  TestAccWAFV2RegexPatternSet_minimal
--- PASS: TestAccWAFV2RuleGroup_regexPatternSetReferenceStatement (170.71s)
=== CONT  TestAccWAFV2RuleGroup_changeCapacityForceNew
--- PASS: TestAccWAFV2RuleGroup_regexMatchStatement (171.84s)
=== CONT  TestAccWAFV2RuleGroup_changeNameForceNew
--- PASS: TestAccWAFV2RuleGroup_ipSetReferenceStatement (175.52s)
=== CONT  TestAccWAFV2RuleGroup_ByteMatchStatement_fieldToMatch
--- PASS: TestAccWAFV2RegexPatternSet_minimal (85.83s)
=== CONT  TestAccWAFV2RuleGroup_byteMatchStatement
--- PASS: TestAccWAFV2RuleGroup_xssMatchStatement (295.78s)
=== CONT  TestAccWAFV2RuleGroup_updateRuleProperties
--- PASS: TestAccWAFV2WebACLAssociation_disappears (412.56s)
=== CONT  TestAccWAFV2RuleGroup_updateRule
=== CONT  TestAccWAFV2RuleGroup_basic
--- PASS: TestAccWAFV2RuleGroup_disappears (140.42s)
--- PASS: TestAccWAFV2RuleGroup_sqliMatchStatement (309.59s)
=== CONT  TestAccWAFV2RuleGroupDataSource_basic
--- PASS: TestAccWAFV2RuleGroup_sizeConstraintStatement (320.10s)
=== CONT  TestAccWAFV2RegexPatternSet_tags
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (533.09s)
=== CONT  TestAccWAFV2IPSet_tags
--- PASS: TestAccWAFV2RuleGroup_LabelMatchStatement (309.83s)
=== CONT  TestAccWAFV2RegexPatternSet_changeNameForceNew
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (634.62s)
=== CONT  TestAccWAFV2RuleGroup_ruleAction
--- PASS: TestAccWAFV2RuleGroup_tags (412.79s)
=== CONT  TestAccWAFV2RuleGroup_RuleAction_customResponse
--- PASS: TestAccWAFV2RuleGroup_GeoMatchStatement_forwardedIP (317.86s)
=== CONT  TestAccWAFV2RuleGroup_RuleAction_customRequestHandling
--- PASS: TestAccWAFV2RuleGroup_logicalRuleStatements (464.23s)
=== CONT  TestAccWAFV2RegexPatternSet_disappears
--- PASS: TestAccWAFV2RuleGroup_geoMatchStatement (325.14s)
=== CONT  TestAccWAFV2IPSet_large
--- PASS: TestAccWAFV2RuleGroup_RuleLabels (326.23s)
=== CONT  TestAccWAFV2IPSet_ipv6
--- PASS: TestAccWAFV2RuleGroup_basic (172.78s)
=== CONT  TestAccWAFV2IPSet_minimal
--- PASS: TestAccWAFV2WebACLLoggingConfiguration_loggingFilter (639.78s)
=== CONT  TestAccWAFV2IPSet_changeNameForceNew
--- PASS: TestAccWAFV2RuleGroupDataSource_basic (178.38s)
=== CONT  TestAccWAFV2RegexPatternSetDataSource_basic
--- PASS: TestAccWAFV2RegexPatternSet_disappears (79.04s)
=== CONT  TestAccWAFV2IPSet_disappears
--- PASS: TestAccWAFV2RuleGroup_rateBasedStatement (601.69s)
=== CONT  TestAccWAFV2IPSet_basic
--- PASS: TestAccWAFV2RegexPatternSet_changeNameForceNew (157.00s)
=== CONT  TestAccWAFV2RegexPatternSet_basic
--- PASS: TestAccWAFV2RuleGroup_changeCapacityForceNew (321.09s)
--- PASS: TestAccWAFV2IPSet_large (109.69s)
--- PASS: TestAccWAFV2IPSet_ipv6 (105.22s)
--- PASS: TestAccWAFV2RuleGroup_changeNameForceNew (321.56s)
--- PASS: TestAccWAFV2IPSet_minimal (101.15s)
--- PASS: TestAccWAFV2IPSet_disappears (73.45s)
--- PASS: TestAccWAFV2RegexPatternSet_tags (244.64s)
--- PASS: TestAccWAFV2RegexPatternSetDataSource_basic (93.61s)
--- PASS: TestAccWAFV2RuleGroup_byteMatchStatement (352.95s)
--- PASS: TestAccWAFV2IPSet_tags (239.52s)
--- PASS: TestAccWAFV2RuleGroup_IPSetReferenceStatement_ipsetForwardedIP (611.93s)
--- PASS: TestAccWAFV2RuleGroup_updateRule (340.91s)
--- PASS: TestAccWAFV2IPSet_changeNameForceNew (132.51s)
--- PASS: TestAccWAFV2IPSet_basic (123.88s)
--- PASS: TestAccWAFV2RegexPatternSet_basic (114.05s)
--- PASS: TestAccWAFV2RuleGroup_updateRuleProperties (407.58s)
--- PASS: TestAccWAFV2RuleGroup_RuleAction_customRequestHandling (236.69s)
--- PASS: TestAccWAFV2RuleGroup_ruleAction (288.07s)
--- PASS: TestAccWAFV2RuleGroup_RuleAction_customResponse (264.81s)
--- PASS: TestAccWAFV2RuleGroup_ByteMatchStatement_fieldToMatch (661.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      1523.486s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 27, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dbell-infra 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@dbell-infra dbell-infra force-pushed the f-add-wafv2-managed-rule-group-configs branch from 4228f6a to 818a072 Compare December 27, 2022 19:38
@johnsonaj johnsonaj self-assigned this Jan 3, 2023
@johnsonaj johnsonaj force-pushed the f-add-wafv2-managed-rule-group-configs branch from 756bf04 to 42f818e Compare January 3, 2023 17:53
@github-actions github-actions bot removed the linter Pertains to changes to or issues with the various linters. label Jan 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jan 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jan 3, 2023
@johnsonaj johnsonaj added documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. labels Jan 3, 2023
@johnsonaj johnsonaj self-requested a review January 3, 2023 21:47
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccWAFV2WebACL_' PKG=wafv2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20  -run=TestAccWAFV2WebACL_ -timeout 180m
--- PASS: TestAccWAFV2WebACL_disappears (32.47s)
--- PASS: TestAccWAFV2WebACL_basic (34.13s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (39.54s)
--- PASS: TestAccWAFV2WebACL_minimal (51.11s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_basic (70.94s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (78.47s)
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (83.86s)
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (84.95s)
--- PASS: TestAccWAFV2WebACL_RateBased_basic (85.00s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (94.97s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (99.62s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (106.16s)
--- PASS: TestAccWAFV2WebACL_Update_rule (112.48s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (114.14s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_ManagedRuleGroupConfig (114.44s)
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (45.32s)
--- PASS: TestAccWAFV2WebACL_RuleLabels (77.50s)
--- PASS: TestAccWAFV2WebACL_tags (119.28s)
--- PASS: TestAccWAFV2WebACL_Custom_response (120.40s)
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (71.72s)
--- PASS: TestAccWAFV2WebACL_ByteMatchStatement_jsonBody (126.52s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (132.34s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (135.81s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (112.27s)
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (113.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	150.797s

@johnsonaj
Copy link
Contributor

@dbell-infra thanks for the contribution 👏🏾 🎉

I made some changes to the PR to better align with the behavior of AWS API.

@johnsonaj johnsonaj merged commit f7cf135 into hashicorp:main Jan 4, 2023
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kaykhan
Copy link
Contributor

kaykhan commented Jan 16, 2023

This does not appear to be working correctly: #28878

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants