Network Firewall Ipv6 - Updated Subnet Mapping to include IP address type for ipv6 support #29010

sabinayakc · 2023-01-20T14:40:28Z

Description

To support Network Firewall IPV6, we need to make changes to the subnet_mapping. This change adds an additional field to the subnet_mapping argument called ip_address_type which can have two values IPV4 | DUALSTACK. Defaults to IPV4.

Note: You cannot change the address type once the firewall subnet is configured.

Relations

Closes #28990.
Closes #28816.

References

Checkout this upstream commit for AWS GO SDK.
aws/aws-sdk-go@ab31958#diff-405306222bf0c8cb0e0e30582f45b1fafacf57db292c868fa6eac2984ebfc112

Output from Acceptance Testing

$ make testacc TESTS=TestAccNetworkFirewallFirewall PKG=networkfirewall

> Unfortunately, at the moment I don't have the right environment/setup to run this test. 
...

…type for ipv6 support

github-actions · 2023-01-20T14:40:45Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkFirewallFirewall_' PKG=networkfirewall ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3 -run=TestAccNetworkFirewallFirewall_ -timeout 180m === RUN TestAccNetworkFirewallFirewall_basic === PAUSE TestAccNetworkFirewallFirewall_basic === RUN TestAccNetworkFirewallFirewall_dualstackSubnet === PAUSE TestAccNetworkFirewallFirewall_dualstackSubnet === RUN TestAccNetworkFirewallFirewall_description === PAUSE TestAccNetworkFirewallFirewall_description === RUN TestAccNetworkFirewallFirewall_deleteProtection === PAUSE TestAccNetworkFirewallFirewall_deleteProtection === RUN TestAccNetworkFirewallFirewall_encryptionConfiguration === PAUSE TestAccNetworkFirewallFirewall_encryptionConfiguration === RUN TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet === PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet === RUN TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets === PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets === RUN TestAccNetworkFirewallFirewall_tags === PAUSE TestAccNetworkFirewallFirewall_tags === RUN TestAccNetworkFirewallFirewall_disappears === PAUSE TestAccNetworkFirewallFirewall_disappears === CONT TestAccNetworkFirewallFirewall_basic === CONT TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet === CONT TestAccNetworkFirewallFirewall_tags --- PASS: TestAccNetworkFirewallFirewall_basic (1081.68s) === CONT TestAccNetworkFirewallFirewall_disappears --- PASS: TestAccNetworkFirewallFirewall_tags (1168.33s) === CONT TestAccNetworkFirewallFirewall_deleteProtection --- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet (2080.36s) === CONT TestAccNetworkFirewallFirewall_encryptionConfiguration --- PASS: TestAccNetworkFirewallFirewall_disappears (1102.95s) === CONT TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets --- PASS: TestAccNetworkFirewallFirewall_deleteProtection (1094.30s) === CONT TestAccNetworkFirewallFirewall_description --- PASS: TestAccNetworkFirewallFirewall_encryptionConfiguration (1259.22s) === CONT TestAccNetworkFirewallFirewall_dualstackSubnet --- PASS: TestAccNetworkFirewallFirewall_description (1179.48s) --- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets (2086.90s) --- PASS: TestAccNetworkFirewallFirewall_dualstackSubnet (1149.24s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 4494.310s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewall_' PKG=networkfirewall ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallFirewall_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewall_basic
=== PAUSE TestAccNetworkFirewallFirewall_basic
=== RUN   TestAccNetworkFirewallFirewall_dualstackSubnet
=== PAUSE TestAccNetworkFirewallFirewall_dualstackSubnet
=== RUN   TestAccNetworkFirewallFirewall_description
=== PAUSE TestAccNetworkFirewallFirewall_description
=== RUN   TestAccNetworkFirewallFirewall_deleteProtection
=== PAUSE TestAccNetworkFirewallFirewall_deleteProtection
=== RUN   TestAccNetworkFirewallFirewall_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallFirewall_encryptionConfiguration
=== RUN   TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== RUN   TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
=== PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
=== RUN   TestAccNetworkFirewallFirewall_tags
=== PAUSE TestAccNetworkFirewallFirewall_tags
=== RUN   TestAccNetworkFirewallFirewall_disappears
=== PAUSE TestAccNetworkFirewallFirewall_disappears
=== CONT  TestAccNetworkFirewallFirewall_basic
=== CONT  TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== CONT  TestAccNetworkFirewallFirewall_tags
--- PASS: TestAccNetworkFirewallFirewall_basic (1081.68s)
=== CONT  TestAccNetworkFirewallFirewall_disappears
--- PASS: TestAccNetworkFirewallFirewall_tags (1168.33s)
=== CONT  TestAccNetworkFirewallFirewall_deleteProtection
--- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet (2080.36s)
=== CONT  TestAccNetworkFirewallFirewall_encryptionConfiguration
--- PASS: TestAccNetworkFirewallFirewall_disappears (1102.95s)
=== CONT  TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
--- PASS: TestAccNetworkFirewallFirewall_deleteProtection (1094.30s)
=== CONT  TestAccNetworkFirewallFirewall_description
--- PASS: TestAccNetworkFirewallFirewall_encryptionConfiguration (1259.22s)
=== CONT  TestAccNetworkFirewallFirewall_dualstackSubnet
--- PASS: TestAccNetworkFirewallFirewall_description (1179.48s)
--- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets (2086.90s)
--- PASS: TestAccNetworkFirewallFirewall_dualstackSubnet (1149.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	4494.310s
% make testacc TESTARGS='-run=TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall ACCTEST_PARALLELISM=3            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (147.09s)
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (168.99s)
=== CONT  TestAccNetworkFirewallRuleGroup_encryptionConfiguration
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (171.67s)
=== CONT  TestAccNetworkFirewallRuleGroup_tags
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (139.30s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
--- PASS: TestAccNetworkFirewallRuleGroup_tags (146.05s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
--- PASS: TestAccNetworkFirewallRuleGroup_encryptionConfiguration (181.34s)
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (164.23s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (158.00s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (161.14s)
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (164.20s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (175.81s)
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (143.33s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (133.36s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (165.30s)
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (304.75s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (163.78s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (156.15s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_referenceSets
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets (159.56s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (134.22s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_referenceSets (175.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1157.527s
% make testacc TESTARGS='-run=TestAccNetworkFirewallResourcePolicy_' PKG=networkfirewall ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallResourcePolicy_ -timeout 180m
=== RUN   TestAccNetworkFirewallResourcePolicy_basic
=== PAUSE TestAccNetworkFirewallResourcePolicy_basic
=== RUN   TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== PAUSE TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== RUN   TestAccNetworkFirewallResourcePolicy_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_ruleGroup
=== RUN   TestAccNetworkFirewallResourcePolicy_disappears
=== PAUSE TestAccNetworkFirewallResourcePolicy_disappears
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_basic
=== CONT  TestAccNetworkFirewallResourcePolicy_disappears
=== CONT  TestAccNetworkFirewallResourcePolicy_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_disappears
    acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-1528447249112802803): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions.
        
          with aws_networkfirewall_resource_policy.test,
          on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test":
          14: resource "aws_networkfirewall_resource_policy" "test" {
        
=== CONT  TestAccNetworkFirewallResourcePolicy_basic
    acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-7406445290865164320): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions.
        
          with aws_networkfirewall_resource_policy.test,
          on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test":
          14: resource "aws_networkfirewall_resource_policy" "test" {
        
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (30.54s)
=== CONT  TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
    acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-5626394035760764984): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions.
        
          with aws_networkfirewall_resource_policy.test,
          on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test":
          14: resource "aws_networkfirewall_resource_policy" "test" {
        
--- SKIP: TestAccNetworkFirewallResourcePolicy_basic (155.84s)
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
--- SKIP: TestAccNetworkFirewallResourcePolicy_disappears (156.09s)
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
    acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-9156454242165754813): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions.
        
          with aws_networkfirewall_resource_policy.test,
          on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test":
          14: resource "aws_networkfirewall_resource_policy" "test" {
        
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (17.08s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (154.00s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (145.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	306.353s
% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicy_' PKG=networkfirewall ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallFirewallPolicy_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_tags
=== PAUSE TestAccNetworkFirewallFirewallPolicy_tags
=== RUN   TestAccNetworkFirewallFirewallPolicy_disappears
=== PAUSE TestAccNetworkFirewallFirewallPolicy_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged
--- PASS: TestAccNetworkFirewallFirewallPolicy_basic (144.48s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged (146.17s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference (169.17s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference (156.33s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference (163.34s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences (160.81s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulEngineOption (142.97s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference (146.66s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessCustomAction (143.51s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences (178.43s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption (301.05s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_disappears
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference (171.66s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
--- PASS: TestAccNetworkFirewallFirewallPolicy_tags (153.75s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
--- PASS: TestAccNetworkFirewallFirewallPolicy_disappears (149.27s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions (136.41s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction (299.67s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions (290.79s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference (167.54s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction (561.96s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference (170.74s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration (180.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1428.366s

…eptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3 -run=TestAccNetworkFirewallRuleGroup_ -timeout 180m === RUN TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList === PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList === RUN TestAccNetworkFirewallRuleGroup_Basic_referenceSets === PAUSE TestAccNetworkFirewallRuleGroup_Basic_referenceSets === RUN TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets === PAUSE TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets === RUN TestAccNetworkFirewallRuleGroup_Basic_statefulRule === PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule === RUN TestAccNetworkFirewallRuleGroup_Basic_statelessRule === PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule === RUN TestAccNetworkFirewallRuleGroup_Basic_rules === PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules === RUN TestAccNetworkFirewallRuleGroup_statefulRuleOptions === PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions === RUN TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions === PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions === RUN TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction === PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction === RUN TestAccNetworkFirewallRuleGroup_updateRules === PAUSE TestAccNetworkFirewallRuleGroup_updateRules === RUN TestAccNetworkFirewallRuleGroup_updateRulesSourceList === PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList === RUN TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables === PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables === RUN TestAccNetworkFirewallRuleGroup_updateStatefulRule === PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule === RUN TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules === PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules === RUN TestAccNetworkFirewallRuleGroup_StatefulRule_action === PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action === RUN TestAccNetworkFirewallRuleGroup_StatefulRule_header === PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header === RUN TestAccNetworkFirewallRuleGroup_updateStatelessRule === PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule === RUN TestAccNetworkFirewallRuleGroup_tags === PAUSE TestAccNetworkFirewallRuleGroup_tags === RUN TestAccNetworkFirewallRuleGroup_encryptionConfiguration === PAUSE TestAccNetworkFirewallRuleGroup_encryptionConfiguration === RUN TestAccNetworkFirewallRuleGroup_disappears === PAUSE TestAccNetworkFirewallRuleGroup_disappears === CONT TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList === CONT TestAccNetworkFirewallRuleGroup_updateRulesSourceList === CONT TestAccNetworkFirewallRuleGroup_StatefulRule_header --- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (147.09s) === CONT TestAccNetworkFirewallRuleGroup_disappears --- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (168.99s) === CONT TestAccNetworkFirewallRuleGroup_encryptionConfiguration --- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (171.67s) === CONT TestAccNetworkFirewallRuleGroup_tags --- PASS: TestAccNetworkFirewallRuleGroup_disappears (139.30s) === CONT TestAccNetworkFirewallRuleGroup_updateStatelessRule --- PASS: TestAccNetworkFirewallRuleGroup_tags (146.05s) === CONT TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules --- PASS: TestAccNetworkFirewallRuleGroup_encryptionConfiguration (181.34s) === CONT TestAccNetworkFirewallRuleGroup_StatefulRule_action --- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (164.23s) === CONT TestAccNetworkFirewallRuleGroup_Basic_rules --- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (158.00s) === CONT TestAccNetworkFirewallRuleGroup_updateRules --- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (161.14s) === CONT TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction --- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (164.20s) === CONT TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions --- PASS: TestAccNetworkFirewallRuleGroup_updateRules (175.81s) === CONT TestAccNetworkFirewallRuleGroup_statefulRuleOptions --- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (143.33s) === CONT TestAccNetworkFirewallRuleGroup_updateStatefulRule --- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (133.36s) === CONT TestAccNetworkFirewallRuleGroup_Basic_statelessRule --- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (165.30s) === CONT TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables --- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (304.75s) === CONT TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets --- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (163.78s) === CONT TestAccNetworkFirewallRuleGroup_Basic_statefulRule --- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (156.15s) === CONT TestAccNetworkFirewallRuleGroup_Basic_referenceSets --- PASS: TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets (159.56s) --- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (134.22s) --- PASS: TestAccNetworkFirewallRuleGroup_Basic_referenceSets (175.89s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 1157.527s % make testacc TESTARGS='-run=TestAccNetworkFirewallResourcePolicy_' PKG=networkfirewall ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3 -run=TestAccNetworkFirewallResourcePolicy_ -timeout 180m === RUN TestAccNetworkFirewallResourcePolicy_basic === PAUSE TestAccNetworkFirewallResourcePolicy_basic === RUN TestAccNetworkFirewallResourcePolicy_ignoreEquivalent === PAUSE TestAccNetworkFirewallResourcePolicy_ignoreEquivalent === RUN TestAccNetworkFirewallResourcePolicy_ruleGroup === PAUSE TestAccNetworkFirewallResourcePolicy_ruleGroup === RUN TestAccNetworkFirewallResourcePolicy_disappears === PAUSE TestAccNetworkFirewallResourcePolicy_disappears === RUN TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy === PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy === RUN TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup === PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup === CONT TestAccNetworkFirewallResourcePolicy_basic === CONT TestAccNetworkFirewallResourcePolicy_disappears === CONT TestAccNetworkFirewallResourcePolicy_ruleGroup === CONT TestAccNetworkFirewallResourcePolicy_disappears acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1 Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-1528447249112802803): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions. with aws_networkfirewall_resource_policy.test, on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test": 14: resource "aws_networkfirewall_resource_policy" "test" { === CONT TestAccNetworkFirewallResourcePolicy_basic acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1 Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-7406445290865164320): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions. with aws_networkfirewall_resource_policy.test, on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test": 14: resource "aws_networkfirewall_resource_policy" "test" { --- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (30.54s) === CONT TestAccNetworkFirewallResourcePolicy_ignoreEquivalent acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1 Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-5626394035760764984): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions. with aws_networkfirewall_resource_policy.test, on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test": 14: resource "aws_networkfirewall_resource_policy" "test" { --- SKIP: TestAccNetworkFirewallResourcePolicy_basic (155.84s) === CONT TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup --- SKIP: TestAccNetworkFirewallResourcePolicy_disappears (156.09s) === CONT TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy acctest.go:1136: skipping test for aws/us-west-2: Error running apply: exit status 1 Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-9156454242165754813): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions. with aws_networkfirewall_resource_policy.test, on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test": 14: resource "aws_networkfirewall_resource_policy" "test" { --- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (17.08s) --- SKIP: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (154.00s) --- SKIP: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (145.13s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 306.353s % make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicy_' PKG=networkfirewall ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3 -run=TestAccNetworkFirewallFirewallPolicy_ -timeout 180m === RUN TestAccNetworkFirewallFirewallPolicy_basic === PAUSE TestAccNetworkFirewallFirewallPolicy_basic === RUN TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration === PAUSE TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration === RUN TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions === RUN TestAccNetworkFirewallFirewallPolicy_statefulEngineOption === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulEngineOption === RUN TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption === PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption === RUN TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference === RUN TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged === RUN TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference === PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference === RUN TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences === PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences === RUN TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference === RUN TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference === RUN TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference === PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference === RUN TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference === PAUSE TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference === RUN TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference === PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference === RUN TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences === PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences === RUN TestAccNetworkFirewallFirewallPolicy_statelessCustomAction === PAUSE TestAccNetworkFirewallFirewallPolicy_statelessCustomAction === RUN TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction === PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction === RUN TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions === PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions === RUN TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction === PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction === RUN TestAccNetworkFirewallFirewallPolicy_tags === PAUSE TestAccNetworkFirewallFirewallPolicy_tags === RUN TestAccNetworkFirewallFirewallPolicy_disappears === PAUSE TestAccNetworkFirewallFirewallPolicy_disappears === CONT TestAccNetworkFirewallFirewallPolicy_basic === CONT TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference === CONT TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged --- PASS: TestAccNetworkFirewallFirewallPolicy_basic (144.48s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceManaged (146.17s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference --- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference (169.17s) === CONT TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference (156.33s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulEngineOption --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupOverrideActionReference (163.34s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference --- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences (160.81s) === CONT TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulEngineOption (142.97s) === CONT TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference (146.66s) === CONT TestAccNetworkFirewallFirewallPolicy_statelessCustomAction --- PASS: TestAccNetworkFirewallFirewallPolicy_statelessCustomAction (143.51s) === CONT TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference --- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences (178.43s) === CONT TestAccNetworkFirewallFirewallPolicy_tags --- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption (301.05s) === CONT TestAccNetworkFirewallFirewallPolicy_disappears --- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference (171.66s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions --- PASS: TestAccNetworkFirewallFirewallPolicy_tags (153.75s) === CONT TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction --- PASS: TestAccNetworkFirewallFirewallPolicy_disappears (149.27s) === CONT TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions (136.41s) === CONT TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions --- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction (299.67s) === CONT TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference --- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions (290.79s) === CONT TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference --- PASS: TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference (167.54s) === CONT TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration --- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction (561.96s) --- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference (170.74s) --- PASS: TestAccNetworkFirewallFirewallPolicy_encryptionConfiguration (180.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 1428.366s

ewbankkit · 2023-02-07T23:26:18Z

@sabinayakc Thanks for the contribution 🎉 👏.

github-actions · 2023-02-09T23:34:36Z

This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-03-12T02:18:56Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Network Firewall Ipv6 - Updated Subnet Mapping to include IP address …

7e976f3

…type for ipv6 support

github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. labels Jan 20, 2023

Added Tests

0eca78d

github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 20, 2023

sabinayakc marked this pull request as ready for review January 20, 2023 18:28

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2023

ewbankkit added 2 commits February 6, 2023 17:08

Merge branch 'main' into HEAD

9ffd3eb

ewbankkit approved these changes Feb 7, 2023

View reviewed changes

github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 7, 2023

ewbankkit added 3 commits February 7, 2023 12:25

Ignore golangci-lint 'ineffassign'.

1f3370b

Fix golangci-lint 'staticcheck'.

81ad483

ewbankkit merged commit 8991a74 into hashicorp:main Feb 7, 2023

github-actions bot added this to the v4.54.0 milestone Feb 7, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network Firewall Ipv6 - Updated Subnet Mapping to include IP address type for ipv6 support #29010

Network Firewall Ipv6 - Updated Subnet Mapping to include IP address type for ipv6 support #29010

sabinayakc commented Jan 20, 2023 •

edited by ewbankkit

Loading

github-actions bot commented Jan 20, 2023

ewbankkit left a comment •

edited

Loading

ewbankkit commented Feb 7, 2023

github-actions bot commented Feb 9, 2023

github-actions bot commented Mar 12, 2023

Network Firewall Ipv6 - Updated Subnet Mapping to include IP address type for ipv6 support #29010

Network Firewall Ipv6 - Updated Subnet Mapping to include IP address type for ipv6 support #29010

Conversation

sabinayakc commented Jan 20, 2023 • edited by ewbankkit Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jan 20, 2023

Community Note

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Feb 7, 2023

github-actions bot commented Feb 9, 2023

github-actions bot commented Mar 12, 2023

sabinayakc commented Jan 20, 2023 •

edited by ewbankkit

Loading

ewbankkit left a comment •

edited

Loading