-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casting bitrate for eac3 #29809
Fix casting bitrate for eac3 #29809
Conversation
Hey @LasseEmilHildebrandt 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
Community NoteVoting for Prioritization
For Submitters
|
We are aware of this issue, and are currently unable to fix it. |
@LasseEmilHildebrandt thanks for the contribution! Overall the PR looks good. Before I run test, can you merge/rebase this PR with main? A few dependencies have been added since last week. |
Thanks for the review, @johnsonaj - The PR has been rebased unto master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_' -timeout 180m
--- PASS: TestAccMediaLiveChannel_disappears (67.83s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (75.41s)
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (83.97s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (87.95s)
--- PASS: TestAccMediaLiveChannel_hls (133.48s)
--- PASS: TestAccMediaLiveChannel_basic (145.75s)
--- PASS: TestAccMediaLiveChannel_updateTags (173.07s)
--- PASS: TestAccMediaLiveChannel_status (184.81s)
--- PASS: TestAccMediaLiveChannel_update (206.50s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 209.499s
@LasseEmilHildebrandt thank you for the contribution! 🎉 |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Bitrate was missing for ac3 encodings.
Relations
Relates to #29807
Relates #27824
References
Output from Acceptance Testing