Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth output audio_only_timecode_control typo #29917

Conversation

LasseEmilHildebrandt
Copy link
Contributor

Description

Fixed typo regarding audio_only_timecodec_control -> audio_only_timecode_control.

While testing, I also found that the event_id field was denoted as an Integer.

Running the test without commit 4c192178a5f695e45ae711ab8383648b13ecd84f yields the following output:

make testacc TESTS=TestAccMediaLiveChannel_MsSmooth_outputSettings PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_MsSmooth_outputSettings'  -timeout 180m
=== RUN   TestAccMediaLiveChannel_MsSmooth_outputSettings
=== PAUSE TestAccMediaLiveChannel_MsSmooth_outputSettings
=== CONT  TestAccMediaLiveChannel_MsSmooth_outputSettings
panic: encoder_settings.0.output_groups.0.output_group_settings.0.ms_smooth_group_settings.0.event_id: '' expected type 'int', got unconvertible type 'string', value: ''

Relations

Resolves #29159

References

The documentation also states that the event_id field is a string:
https://docs.aws.amazon.com/medialive/latest/apireference/channels.html#channels-model-smoothgroupeventidmode

Output from Acceptance Testing

$ make testacc TESTS=TestAccMediaLiveChannel_MsSmooth_outputSettings PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_MsSmooth_outputSettings'  -timeout 180m
=== RUN   TestAccMediaLiveChannel_MsSmooth_outputSettings
=== PAUSE TestAccMediaLiveChannel_MsSmooth_outputSettings
=== CONT  TestAccMediaLiveChannel_MsSmooth_outputSettings
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (84.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	86.306s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/medialive Issues and PRs that pertain to the medialive service. labels Mar 10, 2023
@LasseEmilHildebrandt LasseEmilHildebrandt changed the title B smooth output audio only timecode control typo Smooth output audio_only_timecode_control typo Mar 10, 2023
@github-actions github-actions bot added service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 10, 2023
@johnsonaj
Copy link
Contributor

@LasseEmilHildebrandt thanks for the contribution! Overall the PR looks good. Before I run test, can you merge/rebase this PR with main? A few dependencies have been added since this was open.

@johnsonaj johnsonaj added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023
@LasseEmilHildebrandt
Copy link
Contributor Author

Thanks for the review, @johnsonaj - The PR has been rebased unto master.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 14, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Mar 14, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 180m
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (71.81s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (89.50s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (100.13s)
--- PASS: TestAccMediaLiveChannel_update (127.39s)
--- PASS: TestAccMediaLiveChannel_updateTags (135.02s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (150.57s)
--- PASS: TestAccMediaLiveChannel_basic (154.98s)
--- PASS: TestAccMediaLiveChannel_disappears (162.11s)
--- PASS: TestAccMediaLiveChannel_hls (198.13s)
--- PASS: TestAccMediaLiveChannel_status (317.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	320.641s

@johnsonaj
Copy link
Contributor

@LasseEmilHildebrandt thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 33151ab into hashicorp:main Mar 14, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: medialive encodersettings
2 participants