-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth output audio_only_timecode_control typo #29917
Smooth output audio_only_timecode_control typo #29917
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@LasseEmilHildebrandt thanks for the contribution! Overall the PR looks good. Before I run test, can you merge/rebase this PR with main? A few dependencies have been added since this was open. |
Thanks for the review, @johnsonaj - The PR has been rebased unto master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_' -timeout 180m
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (71.81s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (89.50s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (100.13s)
--- PASS: TestAccMediaLiveChannel_update (127.39s)
--- PASS: TestAccMediaLiveChannel_updateTags (135.02s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (150.57s)
--- PASS: TestAccMediaLiveChannel_basic (154.98s)
--- PASS: TestAccMediaLiveChannel_disappears (162.11s)
--- PASS: TestAccMediaLiveChannel_hls (198.13s)
--- PASS: TestAccMediaLiveChannel_status (317.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 320.641s
@LasseEmilHildebrandt thank you for the contribution! 🎉 |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixed typo regarding
audio_only_timecodec_control
->audio_only_timecode_control
.While testing, I also found that the
event_id
field was denoted as an Integer.Running the test without commit
4c192178a5f695e45ae711ab8383648b13ecd84f
yields the following output:Relations
Resolves #29159
References
The documentation also states that the
event_id
field is a string:https://docs.aws.amazon.com/medialive/latest/apireference/channels.html#channels-model-smoothgroupeventidmode
Output from Acceptance Testing