Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: aws_sagemaker_monitoring_schedule #30684

Merged

Conversation

wrbooth
Copy link

@wrbooth wrbooth commented Apr 12, 2023

Description

Adds a new resource:

  • aws_sagemaker_monitoring_schedule: A schedule that regularly starts Amazon SageMaker Processing Jobs to monitor the data captured for an Amazon SageMaker Endpoint or Batch Transform Job

Relations

Closes #29768

References

CreateMonitoringSchedule Documentation

Output from Acceptance Testing

❯ make testacc TESTS=TestAccSageMakerMonitoringSchedule PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerMonitoringSchedule'  -timeout 180m
=== RUN   TestAccSageMakerMonitoringSchedule_basic
=== PAUSE TestAccSageMakerMonitoringSchedule_basic
=== RUN   TestAccSageMakerMonitoringSchedule_tags
=== PAUSE TestAccSageMakerMonitoringSchedule_tags
=== RUN   TestAccSageMakerMonitoringSchedule_scheduleExpression
=== PAUSE TestAccSageMakerMonitoringSchedule_scheduleExpression
=== RUN   TestAccSageMakerMonitoringSchedule_disappears
=== PAUSE TestAccSageMakerMonitoringSchedule_disappears
=== CONT  TestAccSageMakerMonitoringSchedule_basic
=== CONT  TestAccSageMakerMonitoringSchedule_scheduleExpression
=== CONT  TestAccSageMakerMonitoringSchedule_tags
=== CONT  TestAccSageMakerMonitoringSchedule_disappears
--- PASS: TestAccSageMakerMonitoringSchedule_disappears (62.98s)
--- PASS: TestAccSageMakerMonitoringSchedule_basic (77.69s)
--- PASS: TestAccSageMakerMonitoringSchedule_tags (104.63s)
--- PASS: TestAccSageMakerMonitoringSchedule_scheduleExpression (148.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	151.251s
❯

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. generators Relates to code generators. labels Apr 12, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 12, 2023
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 12, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerMonitoringSchedule_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2  -run=TestAccSageMakerMonitoringSchedule_ -timeout 180m
=== RUN   TestAccSageMakerMonitoringSchedule_basic
=== PAUSE TestAccSageMakerMonitoringSchedule_basic
=== RUN   TestAccSageMakerMonitoringSchedule_tags
=== PAUSE TestAccSageMakerMonitoringSchedule_tags
=== RUN   TestAccSageMakerMonitoringSchedule_scheduleExpression
=== PAUSE TestAccSageMakerMonitoringSchedule_scheduleExpression
=== RUN   TestAccSageMakerMonitoringSchedule_disappears
=== PAUSE TestAccSageMakerMonitoringSchedule_disappears
=== CONT  TestAccSageMakerMonitoringSchedule_basic
=== CONT  TestAccSageMakerMonitoringSchedule_scheduleExpression
--- PASS: TestAccSageMakerMonitoringSchedule_basic (49.38s)
=== CONT  TestAccSageMakerMonitoringSchedule_disappears
--- PASS: TestAccSageMakerMonitoringSchedule_disappears (55.75s)
=== CONT  TestAccSageMakerMonitoringSchedule_tags
--- PASS: TestAccSageMakerMonitoringSchedule_scheduleExpression (139.32s)
--- PASS: TestAccSageMakerMonitoringSchedule_tags (113.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	231.726s

@ewbankkit
Copy link
Contributor

@wrbooth Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 347c6cf into hashicorp:main Apr 12, 2023
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 12, 2023
@wrbooth wrbooth deleted the f-aws_sagemaker_monitoring_schedule_pr3 branch April 13, 2023 04:42
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_sagemaker_monitoring_schedule
4 participants