-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add launch_template to aws_eks_node_group data source #30780
Add launch_template to aws_eks_node_group data source #30780
Conversation
Community NoteVoting for Prioritization
For Submitters
|
b29979d
to
cc8bade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @marsavela 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSNodeGroupDataSource_' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSNodeGroupDataSource_ -timeout 180m
=== RUN TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (994.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 1003.066s
@marsavela Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
launch_template
attribute to theaws_eks_node_group
data source.Relations
No issue that I could find relating to this.
References
https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html
Output from Acceptance Testing
I was not able to run the tests, since I don't have access to any account with enough privileges. If someone could run them for me I'll appreciate it.
The state file shows the launch template from a real-life node group though.