Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch_template to aws_eks_node_group data source #30780

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

marsavela
Copy link
Contributor

Description

This PR adds the launch_template attribute to the aws_eks_node_group data source.

Relations

No issue that I could find relating to this.

References

https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

Output from Acceptance Testing

I was not able to run the tests, since I don't have access to any account with enough privileges. If someone could run them for me I'll appreciate it.

$ make testacc TESTS=TestAccEKSNodeGroupDataSource_ PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSNodeGroupDataSource_'  -timeout 180m
=== RUN   TestAccEKSNodeGroupDataSource_basic
    node_group_data_source_test.go:20: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating IAM Role (tf-acc-test-7930464169323842931-cluster): AccessDenied: User:  XXXXXXXXXXXXX
        .....................
...

The state file shows the launch template from a real-life node group though.

$ terraform state show 'data.aws_eks_node_group.this["cluster01-aps2-nprd-performance-NodeGroup-0"]'
# data.aws_eks_node_group.this["cluster01-aps2-nprd-performance-NodeGroup-0"]:
data "aws_eks_node_group" "this" {
    .................................
    launch_template = [
        {
            id      = "lt-0ba654897hge12f"
            name    = "cluster01-aps2-nprd-performance-NodeGroup-0"
            version = "16"
        },
    ]
    .................................

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2023
@marsavela marsavela force-pushed the f-eks_node_group_data_source branch from b29979d to cc8bade Compare April 18, 2023 06:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @marsavela 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 18, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSNodeGroupDataSource_' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSNodeGroupDataSource_ -timeout 180m
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (994.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1003.066s

@ewbankkit
Copy link
Contributor

@marsavela Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2d36769 into hashicorp:main Apr 18, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 18, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@marsavela marsavela deleted the f-eks_node_group_data_source branch April 21, 2023 01:09
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants