Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add copy_tags_to_snapshot argument to resource/aws_docdb_cluster_instance #31022

Merged

Conversation

tamiros
Copy link
Contributor

@tamiros tamiros commented Apr 27, 2023

Description

This PR adds the argument copy_tags_to_snapshot to the resource aws_docdb_cluster_instance.

This feature flag seems to be available/visible only via CLI, API and CloudFormation. Can't seem to find it in the Web Console.

Relations

Closes #31018.

References

Output from Acceptance Testing

make testacc TESTS='TestAccDocDBClusterInstance_copyTagsToSnapshot' PKG=docdb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run='TestAccDocDBClusterInstance_copyTagsToSnapshot'  -timeout 180m
=== RUN   TestAccDocDBClusterInstance_copyTagsToSnapshot
=== PAUSE TestAccDocDBClusterInstance_copyTagsToSnapshot
=== CONT  TestAccDocDBClusterInstance_copyTagsToSnapshot
--- PASS: TestAccDocDBClusterInstance_copyTagsToSnapshot (825.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdb      825.085s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 27, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 27, 2023
@skoulouris-dpg
Copy link

👍

1 similar comment
@DaanVleugels
Copy link

👍

@WaleedAshraf
Copy link

Hi,

Thanks for fixing this issue.
Can this be merged? Or is there rough timeline?

@Villaver
Copy link

Villaver commented Sep 5, 2023

👍

% make testacc TESTARGS='-run=TestAccDocDBClusterInstance_basic' PKG=docdb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20  -run=TestAccDocDBClusterInstance_basic -timeout 360m
=== RUN   TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== CONT  TestAccDocDBClusterInstance_basic
--- PASS: TestAccDocDBClusterInstance_basic (1190.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	1195.872s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDocDBClusterInstance_' PKG=docdb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 3  -run=TestAccDocDBClusterInstance_ -timeout 720m
=== RUN   TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN   TestAccDocDBClusterInstance_performanceInsights
=== PAUSE TestAccDocDBClusterInstance_performanceInsights
=== RUN   TestAccDocDBClusterInstance_az
=== PAUSE TestAccDocDBClusterInstance_az
=== RUN   TestAccDocDBClusterInstance_namePrefix
=== PAUSE TestAccDocDBClusterInstance_namePrefix
=== RUN   TestAccDocDBClusterInstance_generatedName
=== PAUSE TestAccDocDBClusterInstance_generatedName
=== RUN   TestAccDocDBClusterInstance_kmsKey
=== PAUSE TestAccDocDBClusterInstance_kmsKey
=== RUN   TestAccDocDBClusterInstance_disappears
=== PAUSE TestAccDocDBClusterInstance_disappears
=== RUN   TestAccDocDBClusterInstance_copyTagsToSnapshot
=== PAUSE TestAccDocDBClusterInstance_copyTagsToSnapshot
=== CONT  TestAccDocDBClusterInstance_basic
=== CONT  TestAccDocDBClusterInstance_generatedName
=== CONT  TestAccDocDBClusterInstance_az
--- PASS: TestAccDocDBClusterInstance_az (1069.26s)
=== CONT  TestAccDocDBClusterInstance_disappears
--- PASS: TestAccDocDBClusterInstance_basic (1088.30s)
=== CONT  TestAccDocDBClusterInstance_copyTagsToSnapshot
--- PASS: TestAccDocDBClusterInstance_generatedName (1127.13s)
=== CONT  TestAccDocDBClusterInstance_performanceInsights
--- PASS: TestAccDocDBClusterInstance_disappears (1092.69s)
=== CONT  TestAccDocDBClusterInstance_kmsKey
--- PASS: TestAccDocDBClusterInstance_copyTagsToSnapshot (1076.12s)
=== CONT  TestAccDocDBClusterInstance_namePrefix
--- PASS: TestAccDocDBClusterInstance_performanceInsights (1443.29s)
--- PASS: TestAccDocDBClusterInstance_kmsKey (1016.71s)
--- PASS: TestAccDocDBClusterInstance_namePrefix (1126.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	3296.191s

@ewbankkit
Copy link
Contributor

@tamiros Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c48bf62 into hashicorp:main Oct 11, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 11, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/docdb Issues and PRs that pertain to the docdb service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: copy_tags_to_snapshot on docdb_cluster_instance
7 participants