-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add argument grafana_version
to r/aws_grafana_workspace
#31083
Conversation
… in the web console it is the newer. go figure
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace' PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run=TestAccGrafana_serial/Workspace -timeout 180m
=== RUN TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT TestAccGrafana_serial
=== RUN TestAccGrafana_serial/Workspace
=== RUN TestAccGrafana_serial/Workspace/saml
=== RUN TestAccGrafana_serial/Workspace/organization
acctest.go:924: this AWS account must be the management account of an AWS Organization
=== RUN TestAccGrafana_serial/Workspace/dataSources
=== RUN TestAccGrafana_serial/Workspace/notificationDestinations
=== RUN TestAccGrafana_serial/Workspace/tags
=== RUN TestAccGrafana_serial/Workspace/networkAccess
=== RUN TestAccGrafana_serial/Workspace/sso
acctest.go:944: skipping tests: AccessDeniedException: User: arn:aws:sts::187416307283:assumed-role/terraform_team1_dev-developer/[email protected] is not authorized to perform: sso:ListInstances
=== RUN TestAccGrafana_serial/Workspace/disappears
=== RUN TestAccGrafana_serial/Workspace/permissionType
=== RUN TestAccGrafana_serial/Workspace/vpc
=== RUN TestAccGrafana_serial/Workspace/configuration
=== RUN TestAccGrafana_serial/Workspace/version
--- PASS: TestAccGrafana_serial (4982.28s)
--- PASS: TestAccGrafana_serial/Workspace (4982.28s)
--- PASS: TestAccGrafana_serial/Workspace/saml (334.30s)
--- SKIP: TestAccGrafana_serial/Workspace/organization (0.56s)
--- PASS: TestAccGrafana_serial/Workspace/dataSources (281.91s)
--- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (326.80s)
--- PASS: TestAccGrafana_serial/Workspace/tags (310.09s)
--- PASS: TestAccGrafana_serial/Workspace/networkAccess (522.63s)
--- SKIP: TestAccGrafana_serial/Workspace/sso (0.49s)
--- PASS: TestAccGrafana_serial/Workspace/disappears (309.29s)
--- PASS: TestAccGrafana_serial/Workspace/permissionType (328.12s)
--- PASS: TestAccGrafana_serial/Workspace/vpc (1194.63s)
--- PASS: TestAccGrafana_serial/Workspace/configuration (1060.75s)
--- PASS: TestAccGrafana_serial/Workspace/version (312.71s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 4987.797s
@tamiros Thanks for the contribution 🎉 👏. |
Big thanks to everyone involved ! ❤️ |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the optional argument
grafana_version
to be used during creation of a workspace.As of now, the supported versions are "8.4" and "9.4". Any other version will throw an error by the API call with an appropriate error.
Also, it seems you cannot upgrade/update the Managed Grafana workspace version once you provision so you must re-create it (tried via the Web Console and also couldn't support for it in the API nor official documentation.
AWS provides a migration tool that takes a source and destination workspace, meaning the 9.4 must be up and running as the tools just copies content into it and not actually provisioning one.
Relations
Closes #31078
Depends on #31079 (requires AWS Go SDK v1.44.253 as this property for Create method was introduced there)
References
https://github.com/aws/aws-sdk-go/blob/main/service/managedgrafana/api.go
https://aws.amazon.com/blogs/mt/announcing-amazon-managed-grafana-workspace-version-selection-with-version-9-4-support/
https://github.com/aws-observability/amazon-managed-grafana-migrator
Output from Acceptance Testing