r/aws_quicksight: convert calculated_fields to set type

[jar-b]

Description

Converts the definition.0.calculated_fields argument in the Analysis, Dashboard, and Template resources to a set type.

Relations

Closes #32997

References

Output from Acceptance Testing

% make testacc PKG=quicksight TESTARGS="-run TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20  -run TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_ -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightTemplate_basic (84.83s)
--- PASS: TestAccQuickSightDashboard_disappears (93.99s)
--- PASS: TestAccQuickSightAnalysis_disappears (94.02s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (94.21s)
--- PASS: TestAccQuickSightTemplate_disappears (94.62s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (97.54s)
--- PASS: TestAccQuickSightTemplate_barChart (99.17s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (103.25s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (104.28s)
--- PASS: TestAccQuickSightAnalysis_basic (104.35s)
--- PASS: TestAccQuickSightDashboard_basic (104.76s)
--- PASS: TestAccQuickSightAnalysis_Definition_calculatedFields (104.89s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (107.74s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (110.11s)
--- PASS: TestAccQuickSightTemplate_table (123.68s)
--- PASS: TestAccQuickSightTemplate_update (138.46s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (145.02s)
--- PASS: TestAccQuickSightAnalysis_update (146.36s)
--- PASS: TestAccQuickSightTemplate_tags (158.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 161.125s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_' PKG=quicksight ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 3  -run=TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_ -timeout 180m
?   	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	[no test files]
=== RUN   TestAccQuickSightAnalysis_basic
=== PAUSE TestAccQuickSightAnalysis_basic
=== RUN   TestAccQuickSightAnalysis_disappears
=== PAUSE TestAccQuickSightAnalysis_disappears
=== RUN   TestAccQuickSightAnalysis_sourceEntity
=== PAUSE TestAccQuickSightAnalysis_sourceEntity
=== RUN   TestAccQuickSightAnalysis_update
=== PAUSE TestAccQuickSightAnalysis_update
=== RUN   TestAccQuickSightAnalysis_parametersConfig
=== PAUSE TestAccQuickSightAnalysis_parametersConfig
=== RUN   TestAccQuickSightAnalysis_forceDelete
=== PAUSE TestAccQuickSightAnalysis_forceDelete
=== RUN   TestAccQuickSightAnalysis_Definition_calculatedFields
=== PAUSE TestAccQuickSightAnalysis_Definition_calculatedFields
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== RUN   TestAccQuickSightTemplate_basic
=== PAUSE TestAccQuickSightTemplate_basic
=== RUN   TestAccQuickSightTemplate_disappears
=== PAUSE TestAccQuickSightTemplate_disappears
=== RUN   TestAccQuickSightTemplate_barChart
=== PAUSE TestAccQuickSightTemplate_barChart
=== RUN   TestAccQuickSightTemplate_table
=== PAUSE TestAccQuickSightTemplate_table
=== RUN   TestAccQuickSightTemplate_sourceEntity
=== PAUSE TestAccQuickSightTemplate_sourceEntity
=== RUN   TestAccQuickSightTemplate_tags
=== PAUSE TestAccQuickSightTemplate_tags
=== RUN   TestAccQuickSightTemplate_update
=== PAUSE TestAccQuickSightTemplate_update
=== CONT  TestAccQuickSightAnalysis_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightAnalysis_forceDelete
--- PASS: TestAccQuickSightAnalysis_basic (65.89s)
=== CONT  TestAccQuickSightTemplate_table
--- PASS: TestAccQuickSightAnalysis_forceDelete (69.87s)
=== CONT  TestAccQuickSightTemplate_update
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (118.87s)
=== CONT  TestAccQuickSightTemplate_tags
--- PASS: TestAccQuickSightTemplate_table (91.68s)
=== CONT  TestAccQuickSightTemplate_sourceEntity
--- PASS: TestAccQuickSightTemplate_update (105.06s)
=== CONT  TestAccQuickSightAnalysis_update
--- PASS: TestAccQuickSightTemplate_sourceEntity (61.20s)
=== CONT  TestAccQuickSightAnalysis_parametersConfig
--- PASS: TestAccQuickSightTemplate_tags (127.38s)
=== CONT  TestAccQuickSightTemplate_disappears
--- PASS: TestAccQuickSightAnalysis_parametersConfig (62.21s)
=== CONT  TestAccQuickSightTemplate_barChart
--- PASS: TestAccQuickSightAnalysis_update (116.70s)
=== CONT  TestAccQuickSightAnalysis_sourceEntity
--- PASS: TestAccQuickSightTemplate_disappears (48.16s)
=== CONT  TestAccQuickSightDashboard_disappears
--- PASS: TestAccQuickSightTemplate_barChart (52.06s)
=== CONT  TestAccQuickSightDashboard_sourceEntity
--- PASS: TestAccQuickSightDashboard_disappears (56.11s)
=== CONT  TestAccQuickSightAnalysis_disappears
--- PASS: TestAccQuickSightAnalysis_sourceEntity (74.61s)
=== CONT  TestAccQuickSightDashboard_basic
--- PASS: TestAccQuickSightDashboard_sourceEntity (71.87s)
=== CONT  TestAccQuickSightTemplate_basic
--- PASS: TestAccQuickSightAnalysis_disappears (56.12s)
=== CONT  TestAccQuickSightAnalysis_Definition_calculatedFields
--- PASS: TestAccQuickSightDashboard_basic (63.72s)
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
--- PASS: TestAccQuickSightTemplate_basic (52.07s)
--- PASS: TestAccQuickSightAnalysis_Definition_calculatedFields (63.14s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (60.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	495.422s

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.