Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation for servicediscovery etc. #33371

Merged
merged 12 commits into from
Sep 8, 2023
Merged

Fix validation for servicediscovery etc. #33371

merged 12 commits into from
Sep 8, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 8, 2023 •
edited
Loading

Description

Relations

Closes #33368
Relates #33359

References

Output from Acceptance Testing

% make t T=TestAccServiceDiscovery K=servicediscovery 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20 -run='TestAccServiceDiscovery'  -timeout 180m
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== RUN   TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_disappears
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_disappears
=== RUN   TestAccServiceDiscoveryHTTPNamespace_description
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_description
=== RUN   TestAccServiceDiscoveryHTTPNamespace_tags
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_tags
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== RUN   TestAccServiceDiscoveryInstance_public
=== PAUSE TestAccServiceDiscoveryInstance_public
=== RUN   TestAccServiceDiscoveryInstance_http
=== PAUSE TestAccServiceDiscoveryInstance_http
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryServiceDataSource_basic
=== PAUSE TestAccServiceDiscoveryServiceDataSource_basic
=== RUN   TestAccServiceDiscoveryServiceDataSource_private
=== PAUSE TestAccServiceDiscoveryServiceDataSource_private
=== RUN   TestAccServiceDiscoveryServiceDataSource_public
=== PAUSE TestAccServiceDiscoveryServiceDataSource_public
=== RUN   TestAccServiceDiscoveryService_private
=== PAUSE TestAccServiceDiscoveryService_private
=== RUN   TestAccServiceDiscoveryService_public
=== PAUSE TestAccServiceDiscoveryService_public
=== RUN   TestAccServiceDiscoveryService_private_http
=== PAUSE TestAccServiceDiscoveryService_private_http
=== RUN   TestAccServiceDiscoveryService_http
=== PAUSE TestAccServiceDiscoveryService_http
=== RUN   TestAccServiceDiscoveryService_disappears
=== PAUSE TestAccServiceDiscoveryService_disappears
=== RUN   TestAccServiceDiscoveryService_tags
=== PAUSE TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryInstance_private
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== CONT  TestAccServiceDiscoveryServiceDataSource_public
=== CONT  TestAccServiceDiscoveryHTTPNamespace_disappears
=== CONT  TestAccServiceDiscoveryService_private
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_basic
=== CONT  TestAccServiceDiscoveryServiceDataSource_private
=== CONT  TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== CONT  TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryService_disappears
=== CONT  TestAccServiceDiscoveryService_private_http
=== CONT  TestAccServiceDiscoveryService_public
=== CONT  TestAccServiceDiscoveryServiceDataSource_basic
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_description
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== CONT  TestAccServiceDiscoveryService_http
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_disappears (141.31s)
=== CONT  TestAccServiceDiscoveryInstance_http
--- PASS: TestAccServiceDiscoveryHTTPNamespace_disappears (141.32s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_disappears (152.10s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespaceDataSource_basic (154.99s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_description
--- PASS: TestAccServiceDiscoveryServiceDataSource_basic (156.57s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_tags
--- PASS: TestAccServiceDiscoveryServiceDataSource_public (156.60s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_description
--- PASS: TestAccServiceDiscoveryService_disappears (156.89s)
=== CONT  TestAccServiceDiscoveryInstance_public
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_private (159.98s)
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_public
--- PASS: TestAccServiceDiscoveryServiceDataSource_private (159.99s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_basic (161.85s)
--- PASS: TestAccServiceDiscoveryService_http (162.04s)
--- PASS: TestAccServiceDiscoveryService_private_http (165.77s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_description (190.79s)
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap (206.39s)
--- PASS: TestAccServiceDiscoveryService_private (214.26s)
--- PASS: TestAccServiceDiscoveryInstance_private (222.67s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_tags (227.12s)
--- PASS: TestAccServiceDiscoveryService_tags (229.48s)
--- PASS: TestAccServiceDiscoveryService_public (230.21s)
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_tags (233.32s)
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_basic (129.23s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_basic (130.38s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_description (129.98s)
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_public (125.08s)
--- PASS: TestAccServiceDiscoveryInstance_http (163.28s)
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_description (153.06s)
--- PASS: TestAccServiceDiscoveryInstance_public (158.12s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_tags (167.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	325.575s
% make t T=TestAccELBV2ListenerRule_ K=elbv2 P=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 4 -run='TestAccELBV2ListenerRule_'  -timeout 180m
=== RUN   TestAccELBV2ListenerRule_basic
=== PAUSE TestAccELBV2ListenerRule_basic
=== RUN   TestAccELBV2ListenerRule_disappears
=== PAUSE TestAccELBV2ListenerRule_disappears
=== RUN   TestAccELBV2ListenerRule_tags
=== PAUSE TestAccELBV2ListenerRule_tags
=== RUN   TestAccELBV2ListenerRule_forwardWeighted
=== PAUSE TestAccELBV2ListenerRule_forwardWeighted
=== RUN   TestAccELBV2ListenerRule_backwardsCompatibility
=== PAUSE TestAccELBV2ListenerRule_backwardsCompatibility
=== RUN   TestAccELBV2ListenerRule_redirect
=== PAUSE TestAccELBV2ListenerRule_redirect
=== RUN   TestAccELBV2ListenerRule_fixedResponse
=== PAUSE TestAccELBV2ListenerRule_fixedResponse
=== RUN   TestAccELBV2ListenerRule_updateFixedResponse
=== PAUSE TestAccELBV2ListenerRule_updateFixedResponse
=== RUN   TestAccELBV2ListenerRule_updateRulePriority
=== PAUSE TestAccELBV2ListenerRule_updateRulePriority
=== RUN   TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== PAUSE TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== RUN   TestAccELBV2ListenerRule_priority
=== PAUSE TestAccELBV2ListenerRule_priority
=== RUN   TestAccELBV2ListenerRule_cognito
=== PAUSE TestAccELBV2ListenerRule_cognito
=== RUN   TestAccELBV2ListenerRule_oidc
=== PAUSE TestAccELBV2ListenerRule_oidc
=== RUN   TestAccELBV2ListenerRule_Action_order
=== PAUSE TestAccELBV2ListenerRule_Action_order
=== RUN   TestAccELBV2ListenerRule_ActionOrder_recreates
=== PAUSE TestAccELBV2ListenerRule_ActionOrder_recreates
=== RUN   TestAccELBV2ListenerRule_conditionAttributesCount
=== PAUSE TestAccELBV2ListenerRule_conditionAttributesCount
=== RUN   TestAccELBV2ListenerRule_conditionHostHeader
=== PAUSE TestAccELBV2ListenerRule_conditionHostHeader
=== RUN   TestAccELBV2ListenerRule_conditionHTTPHeader
=== PAUSE TestAccELBV2ListenerRule_conditionHTTPHeader
=== RUN   TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
=== PAUSE TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
=== RUN   TestAccELBV2ListenerRule_conditionHTTPRequestMethod
=== PAUSE TestAccELBV2ListenerRule_conditionHTTPRequestMethod
=== RUN   TestAccELBV2ListenerRule_conditionPathPattern
=== PAUSE TestAccELBV2ListenerRule_conditionPathPattern
=== RUN   TestAccELBV2ListenerRule_conditionQueryString
=== PAUSE TestAccELBV2ListenerRule_conditionQueryString
=== RUN   TestAccELBV2ListenerRule_conditionSourceIP
=== PAUSE TestAccELBV2ListenerRule_conditionSourceIP
=== RUN   TestAccELBV2ListenerRule_conditionUpdateMixed
=== PAUSE TestAccELBV2ListenerRule_conditionUpdateMixed
=== RUN   TestAccELBV2ListenerRule_conditionMultiple
=== PAUSE TestAccELBV2ListenerRule_conditionMultiple
=== RUN   TestAccELBV2ListenerRule_conditionUpdateMultiple
=== PAUSE TestAccELBV2ListenerRule_conditionUpdateMultiple
=== CONT  TestAccELBV2ListenerRule_basic
=== CONT  TestAccELBV2ListenerRule_Action_order
=== CONT  TestAccELBV2ListenerRule_updateFixedResponse
=== CONT  TestAccELBV2ListenerRule_conditionPathPattern
--- PASS: TestAccELBV2ListenerRule_basic (174.42s)
=== CONT  TestAccELBV2ListenerRule_conditionUpdateMixed
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (182.75s)
=== CONT  TestAccELBV2ListenerRule_conditionUpdateMultiple
--- PASS: TestAccELBV2ListenerRule_Action_order (199.64s)
=== CONT  TestAccELBV2ListenerRule_conditionHTTPRequestMethod
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (222.97s)
=== CONT  TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (1.55s)
=== CONT  TestAccELBV2ListenerRule_conditionHTTPHeader
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (187.29s)
=== CONT  TestAccELBV2ListenerRule_conditionHostHeader
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (213.36s)
=== CONT  TestAccELBV2ListenerRule_conditionAttributesCount
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (197.25s)
=== CONT  TestAccELBV2ListenerRule_ActionOrder_recreates
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMixed (257.64s)
=== CONT  TestAccELBV2ListenerRule_backwardsCompatibility
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (41.83s)
=== CONT  TestAccELBV2ListenerRule_fixedResponse
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (186.69s)
=== CONT  TestAccELBV2ListenerRule_conditionMultiple
--- PASS: TestAccELBV2ListenerRule_ActionOrder_recreates (198.56s)
=== CONT  TestAccELBV2ListenerRule_priority
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (197.22s)
=== CONT  TestAccELBV2ListenerRule_oidc
--- PASS: TestAccELBV2ListenerRule_fixedResponse (204.68s)
=== CONT  TestAccELBV2ListenerRule_redirect
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (187.20s)
=== CONT  TestAccELBV2ListenerRule_cognito
--- PASS: TestAccELBV2ListenerRule_oidc (177.20s)
=== CONT  TestAccELBV2ListenerRule_tags
--- PASS: TestAccELBV2ListenerRule_redirect (253.08s)
=== CONT  TestAccELBV2ListenerRule_forwardWeighted
--- PASS: TestAccELBV2ListenerRule_cognito (177.66s)
=== CONT  TestAccELBV2ListenerRule_conditionQueryString
--- PASS: TestAccELBV2ListenerRule_priority (364.44s)
=== CONT  TestAccELBV2ListenerRule_disappears
--- PASS: TestAccELBV2ListenerRule_tags (221.94s)
=== CONT  TestAccELBV2ListenerRule_conditionSourceIP
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (180.50s)
=== CONT  TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (239.52s)
=== CONT  TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_disappears (176.52s)
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (194.67s)
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (192.95s)
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (217.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	1354.550s
% make t T=TestAccS3BucketACL_ K=s3              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketACL_'  -timeout 180m
=== RUN   TestAccS3BucketACL_basic
=== PAUSE TestAccS3BucketACL_basic
=== RUN   TestAccS3BucketACL_disappears
=== PAUSE TestAccS3BucketACL_disappears
=== RUN   TestAccS3BucketACL_migrate_aclNoChange
=== PAUSE TestAccS3BucketACL_migrate_aclNoChange
=== RUN   TestAccS3BucketACL_migrate_aclWithChange
=== PAUSE TestAccS3BucketACL_migrate_aclWithChange
=== RUN   TestAccS3BucketACL_migrate_grantsWithChange
=== PAUSE TestAccS3BucketACL_migrate_grantsWithChange
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketACL_updateGrant
=== PAUSE TestAccS3BucketACL_updateGrant
=== RUN   TestAccS3BucketACL_ACLToGrant
=== PAUSE TestAccS3BucketACL_ACLToGrant
=== RUN   TestAccS3BucketACL_grantToACL
=== PAUSE TestAccS3BucketACL_grantToACL
=== CONT  TestAccS3BucketACL_basic
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3BucketACL_migrate_aclWithChange
=== CONT  TestAccS3BucketACL_ACLToGrant
=== CONT  TestAccS3BucketACL_grantToACL
=== CONT  TestAccS3BucketACL_updateGrant
=== CONT  TestAccS3BucketACL_migrate_aclNoChange
=== CONT  TestAccS3BucketACL_disappears
=== CONT  TestAccS3BucketACL_migrate_grantsWithChange
--- PASS: TestAccS3BucketACL_disappears (37.85s)
--- PASS: TestAccS3BucketACL_basic (50.74s)
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (71.25s)
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (71.67s)
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (73.25s)
--- PASS: TestAccS3BucketACL_updateACL (78.97s)
--- PASS: TestAccS3BucketACL_grantToACL (79.44s)
--- PASS: TestAccS3BucketACL_ACLToGrant (79.85s)
--- PASS: TestAccS3BucketACL_updateGrant (84.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	86.236s
% make t T=TestAccEventsTarget_ K=events P=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 4 -run='TestAccEventsTarget_'  -timeout 180m
=== RUN   TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== RUN   TestAccEventsTarget_disappears
=== PAUSE TestAccEventsTarget_disappears
=== RUN   TestAccEventsTarget_eventBusName
=== PAUSE TestAccEventsTarget_eventBusName
=== RUN   TestAccEventsTarget_eventBusARN
=== PAUSE TestAccEventsTarget_eventBusARN
=== RUN   TestAccEventsTarget_generatedTargetID
=== PAUSE TestAccEventsTarget_generatedTargetID
=== RUN   TestAccEventsTarget_RetryPolicy_deadLetter
=== PAUSE TestAccEventsTarget_RetryPolicy_deadLetter
=== RUN   TestAccEventsTarget_full
=== PAUSE TestAccEventsTarget_full
=== RUN   TestAccEventsTarget_ssmDocument
=== PAUSE TestAccEventsTarget_ssmDocument
=== RUN   TestAccEventsTarget_http
=== PAUSE TestAccEventsTarget_http
=== RUN   TestAccEventsTarget_http_params
=== PAUSE TestAccEventsTarget_http_params
=== RUN   TestAccEventsTarget_ecs
=== PAUSE TestAccEventsTarget_ecs
=== RUN   TestAccEventsTarget_redshift
=== PAUSE TestAccEventsTarget_redshift
=== RUN   TestAccEventsTarget_ecsWithoutLaunchType
=== PAUSE TestAccEventsTarget_ecsWithoutLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankLaunchType
=== PAUSE TestAccEventsTarget_ecsWithBlankLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankTaskCount
=== PAUSE TestAccEventsTarget_ecsWithBlankTaskCount
=== RUN   TestAccEventsTarget_ecsFull
=== PAUSE TestAccEventsTarget_ecsFull
=== RUN   TestAccEventsTarget_ecsCapacityProvider
=== PAUSE TestAccEventsTarget_ecsCapacityProvider
=== RUN   TestAccEventsTarget_ecsPlacementStrategy
=== PAUSE TestAccEventsTarget_ecsPlacementStrategy
=== RUN   TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== RUN   TestAccEventsTarget_kinesis
=== PAUSE TestAccEventsTarget_kinesis
=== RUN   TestAccEventsTarget_sqs
=== PAUSE TestAccEventsTarget_sqs
=== RUN   TestAccEventsTarget_sageMakerPipeline
=== PAUSE TestAccEventsTarget_sageMakerPipeline
=== RUN   TestAccEventsTarget_Input_transformer
=== PAUSE TestAccEventsTarget_Input_transformer
=== RUN   TestAccEventsTarget_inputTransformerJSONString
=== PAUSE TestAccEventsTarget_inputTransformerJSONString
=== RUN   TestAccEventsTarget_partnerEventBus
    target_test.go:948: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)
=== RUN   TestAccEventsTarget_ecsNoPropagateTags
=== PAUSE TestAccEventsTarget_ecsNoPropagateTags
=== CONT  TestAccEventsTarget_basic
=== CONT  TestAccEventsTarget_ecsWithBlankLaunchType
=== CONT  TestAccEventsTarget_ssmDocument
=== CONT  TestAccEventsTarget_ecsNoPropagateTags
--- PASS: TestAccEventsTarget_ssmDocument (30.83s)
=== CONT  TestAccEventsTarget_ecs
--- PASS: TestAccEventsTarget_basic (46.20s)
=== CONT  TestAccEventsTarget_ecsWithoutLaunchType
--- PASS: TestAccEventsTarget_ecs (42.59s)
=== CONT  TestAccEventsTarget_redshift
=== CONT  TestAccEventsTarget_http_params
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (94.55s)
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (91.89s)
=== CONT  TestAccEventsTarget_http
--- PASS: TestAccEventsTarget_http_params (50.48s)
=== CONT  TestAccEventsTarget_generatedTargetID
--- PASS: TestAccEventsTarget_generatedTargetID (27.03s)
=== CONT  TestAccEventsTarget_full
--- PASS: TestAccEventsTarget_http (55.04s)
=== CONT  TestAccEventsTarget_kinesis
--- PASS: TestAccEventsTarget_full (56.28s)
=== CONT  TestAccEventsTarget_RetryPolicy_deadLetter
--- PASS: TestAccEventsTarget_kinesis (56.79s)
=== CONT  TestAccEventsTarget_inputTransformerJSONString
--- PASS: TestAccEventsTarget_ecsNoPropagateTags (274.34s)
=== CONT  TestAccEventsTarget_ecsCapacityProvider
--- PASS: TestAccEventsTarget_inputTransformerJSONString (38.49s)
=== CONT  TestAccEventsTarget_Input_transformer
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (63.10s)
=== CONT  TestAccEventsTarget_batch
--- PASS: TestAccEventsTarget_redshift (250.90s)
=== CONT  TestAccEventsTarget_ecsPlacementStrategy
--- PASS: TestAccEventsTarget_Input_transformer (44.15s)
=== CONT  TestAccEventsTarget_ecsFull
--- PASS: TestAccEventsTarget_ecsCapacityProvider (86.36s)
=== CONT  TestAccEventsTarget_ecsWithBlankTaskCount
--- PASS: TestAccEventsTarget_ecsFull (42.52s)
=== CONT  TestAccEventsTarget_eventBusName
--- PASS: TestAccEventsTarget_eventBusName (26.69s)
=== CONT  TestAccEventsTarget_eventBusARN
--- PASS: TestAccEventsTarget_ecsPlacementStrategy (96.18s)
=== CONT  TestAccEventsTarget_sqs
--- PASS: TestAccEventsTarget_eventBusARN (26.45s)
=== CONT  TestAccEventsTarget_sageMakerPipeline
--- PASS: TestAccEventsTarget_batch (141.03s)
=== CONT  TestAccEventsTarget_disappears
--- PASS: TestAccEventsTarget_disappears (23.53s)
--- PASS: TestAccEventsTarget_sageMakerPipeline (28.23s)
--- PASS: TestAccEventsTarget_sqs (54.38s)
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (270.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	633.040s
% make t T=TestAccIPAMPoolCIDRAllocation_ K=ipam  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolCIDRAllocation_'  -timeout 180m
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMPoolCIDRAllocation_disappears
=== PAUSE TestAccIPAMPoolCIDRAllocation_disappears
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPoolCIDRAllocation_multiple
=== PAUSE TestAccIPAMPoolCIDRAllocation_multiple
=== RUN   TestAccIPAMPoolCIDRAllocation_differentRegion
=== PAUSE TestAccIPAMPoolCIDRAllocation_differentRegion
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== CONT  TestAccIPAMPoolCIDRAllocation_multiple
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== CONT  TestAccIPAMPoolCIDRAllocation_disappears
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== CONT  TestAccIPAMPoolCIDRAllocation_differentRegion
    ipam_pool_cidr_allocation_test.go:188: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating IPAM: ResourceLimitExceeded: You've reached the limit for ipams. You have created 5 ipams and you are limited to 1.
        	status code: 400, request id: b30c1558-f474-4a65-a332-90df9c3d3f37
        
          with aws_vpc_ipam.test,
          on terraform_plugin_test.tf line 6, in resource "aws_vpc_ipam" "test":
           6: resource "aws_vpc_ipam" "test" {
        
--- FAIL: TestAccIPAMPoolCIDRAllocation_differentRegion (16.47s)
--- PASS: TestAccIPAMPoolCIDRAllocation_disappears (102.21s)
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR (102.55s)
--- PASS: TestAccIPAMPoolCIDRAllocation_multiple (102.69s)
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (110.08s)
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (110.52s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	112.555s
% make t T=TestAccDataSyncTask_ K=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_'  -timeout 180m
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_disappears
=== PAUSE TestAccDataSyncTask_disappears
=== RUN   TestAccDataSyncTask_schedule
=== PAUSE TestAccDataSyncTask_schedule
=== RUN   TestAccDataSyncTask_cloudWatchLogGroupARN
=== PAUSE TestAccDataSyncTask_cloudWatchLogGroupARN
=== RUN   TestAccDataSyncTask_excludes
=== PAUSE TestAccDataSyncTask_excludes
=== RUN   TestAccDataSyncTask_includes
=== PAUSE TestAccDataSyncTask_includes
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_gid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_gid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_uid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_uid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== RUN   TestAccDataSyncTask_tags
=== PAUSE TestAccDataSyncTask_tags
=== CONT  TestAccDataSyncTask_basic
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags
=== CONT  TestAccDataSyncTask_tags
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== CONT  TestAccDataSyncTask_cloudWatchLogGroupARN
=== CONT  TestAccDataSyncTask_schedule
=== CONT  TestAccDataSyncTask_excludes
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_uid
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_gid
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== CONT  TestAccDataSyncTask_includes
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_posixPermissions (251.73s)
=== CONT  TestAccDataSyncTask_disappears
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (276.21s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (276.93s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (290.89s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (296.51s)
--- PASS: TestAccDataSyncTask_includes (303.92s)
--- PASS: TestAccDataSyncTask_basic (303.96s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (311.37s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (319.38s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (320.40s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (323.36s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDevices (335.11s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (338.20s)
--- PASS: TestAccDataSyncTask_tags (342.88s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_overwriteMode (345.43s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (361.57s)
--- PASS: TestAccDataSyncTask_schedule (368.51s)
--- PASS: TestAccDataSyncTask_excludes (395.75s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (411.84s)
--- PASS: TestAccDataSyncTask_disappears (199.77s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags (3185.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	3187.208s
% make t T=TestAccImageBuilderImagePipeline_basic K=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderImagePipeline_basic'  -timeout 180m
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== CONT  TestAccImageBuilderImagePipeline_basic
--- PASS: TestAccImageBuilderImagePipeline_basic (40.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	42.597s
% make t T=TestAccMQBroker_ K=mq     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 20 -run='TestAccMQBroker_'  -timeout 180m
=== RUN   TestAccMQBroker_basic
=== PAUSE TestAccMQBroker_basic
=== RUN   TestAccMQBroker_disappears
=== PAUSE TestAccMQBroker_disappears
=== RUN   TestAccMQBroker_tags
=== PAUSE TestAccMQBroker_tags
=== RUN   TestAccMQBroker_throughputOptimized
=== PAUSE TestAccMQBroker_throughputOptimized
=== RUN   TestAccMQBroker_AllFields_defaultVPC
=== PAUSE TestAccMQBroker_AllFields_defaultVPC
=== RUN   TestAccMQBroker_AllFields_customVPC
=== PAUSE TestAccMQBroker_AllFields_customVPC
=== RUN   TestAccMQBroker_EncryptionOptions_kmsKeyID
=== PAUSE TestAccMQBroker_EncryptionOptions_kmsKeyID
=== RUN   TestAccMQBroker_EncryptionOptions_managedKeyDisabled
=== PAUSE TestAccMQBroker_EncryptionOptions_managedKeyDisabled
=== RUN   TestAccMQBroker_EncryptionOptions_managedKeyEnabled
=== PAUSE TestAccMQBroker_EncryptionOptions_managedKeyEnabled
=== RUN   TestAccMQBroker_Update_users
=== PAUSE TestAccMQBroker_Update_users
=== RUN   TestAccMQBroker_Update_securityGroup
=== PAUSE TestAccMQBroker_Update_securityGroup
=== RUN   TestAccMQBroker_Update_engineVersion
=== PAUSE TestAccMQBroker_Update_engineVersion
=== RUN   TestAccMQBroker_Update_hostInstanceType
=== PAUSE TestAccMQBroker_Update_hostInstanceType
=== RUN   TestAccMQBroker_RabbitMQ_basic
=== PAUSE TestAccMQBroker_RabbitMQ_basic
=== RUN   TestAccMQBroker_RabbitMQ_logs
=== PAUSE TestAccMQBroker_RabbitMQ_logs
=== RUN   TestAccMQBroker_RabbitMQ_validationAuditLog
=== PAUSE TestAccMQBroker_RabbitMQ_validationAuditLog
=== RUN   TestAccMQBroker_RabbitMQ_cluster
=== PAUSE TestAccMQBroker_RabbitMQ_cluster
=== RUN   TestAccMQBroker_ldap
=== PAUSE TestAccMQBroker_ldap
=== CONT  TestAccMQBroker_basic
=== CONT  TestAccMQBroker_Update_users
=== CONT  TestAccMQBroker_RabbitMQ_logs
=== CONT  TestAccMQBroker_Update_hostInstanceType
=== CONT  TestAccMQBroker_Update_engineVersion
=== CONT  TestAccMQBroker_RabbitMQ_basic
=== CONT  TestAccMQBroker_Update_securityGroup
=== CONT  TestAccMQBroker_RabbitMQ_validationAuditLog
=== CONT  TestAccMQBroker_EncryptionOptions_kmsKeyID
=== CONT  TestAccMQBroker_AllFields_defaultVPC
=== CONT  TestAccMQBroker_throughputOptimized
=== CONT  TestAccMQBroker_disappears
=== CONT  TestAccMQBroker_ldap
=== CONT  TestAccMQBroker_EncryptionOptions_managedKeyDisabled
=== CONT  TestAccMQBroker_RabbitMQ_cluster
=== CONT  TestAccMQBroker_AllFields_customVPC
=== CONT  TestAccMQBroker_tags
=== CONT  TestAccMQBroker_EncryptionOptions_managedKeyEnabled
=== NAME  TestAccMQBroker_RabbitMQ_logs
    broker_test.go:1137: Step 1/2 error: Check failed: Check 2/11 error: aws_mq_broker.test: Attribute 'configuration.#' expected "0", got "1"
--- FAIL: TestAccMQBroker_RabbitMQ_logs (698.15s)
--- PASS: TestAccMQBroker_RabbitMQ_validationAuditLog (737.29s)
=== NAME  TestAccMQBroker_RabbitMQ_basic
    broker_test.go:1091: Step 1/2 error: Check failed: Check 2/11 error: aws_mq_broker.test: Attribute 'configuration.#' expected "0", got "1"
--- PASS: TestAccMQBroker_throughputOptimized (833.17s)
--- FAIL: TestAccMQBroker_RabbitMQ_basic (902.17s)
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyEnabled (1019.32s)
--- PASS: TestAccMQBroker_basic (1027.24s)
--- PASS: TestAccMQBroker_ldap (1045.07s)
--- PASS: TestAccMQBroker_tags (1049.69s)
--- PASS: TestAccMQBroker_EncryptionOptions_kmsKeyID (1050.10s)
--- PASS: TestAccMQBroker_RabbitMQ_cluster (1056.02s)
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyDisabled (1101.06s)
--- PASS: TestAccMQBroker_disappears (1106.98s)
--- PASS: TestAccMQBroker_Update_securityGroup (1192.27s)
--- PASS: TestAccMQBroker_Update_engineVersion (1225.48s)
--- PASS: TestAccMQBroker_Update_users (1495.41s)
--- PASS: TestAccMQBroker_Update_hostInstanceType (1577.92s)
--- PASS: TestAccMQBroker_AllFields_customVPC (1670.39s)
--- PASS: TestAccMQBroker_AllFields_defaultVPC (1696.58s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/mq	1698.717s

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Sep 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 8, 2023
@ewbankkit ewbankkit self-assigned this Sep 8, 2023
ewbankkit
ewbankkit approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceDiscoveryInstance_private' PKG=servicediscovery
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20  -run=TestAccServiceDiscoveryInstance_private -timeout 180m
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== CONT  TestAccServiceDiscoveryInstance_private
--- PASS: TestAccServiceDiscoveryInstance_private (152.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	157.989s

@ewbankkit ewbankkit added this to the v5.16.1 milestone Sep 8, 2023
@ewbankkit ewbankkit changed the title Fix validation for servicediscovery Fix validation for servicediscovery etc. Sep 8, 2023
@ewbankkit ewbankkit changed the title Fix validation for servicediscovery etc. Fix validation for servicediscovery etc. Sep 8, 2023
@github-actions github-actions bot added service/athena Issues and PRs that pertain to the athena service. service/shield Issues and PRs that pertain to the shield service. service/datasync Issues and PRs that pertain to the datasync service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/evidently Issues and PRs that pertain to the evidently service. labels Sep 8, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 8, 2023
@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. service/ipam Issues and PRs that pertain to the ipam service. labels Sep 8, 2023
@YakDriver YakDriver merged commit 482f69e into main Sep 8, 2023
45 checks passed
@YakDriver YakDriver deleted the b-fix-regexps branch September 8, 2023 20:00
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
Update CHANGELOG.md for #33371
36d6c95
@dim13
Copy link

dim13 commented Sep 8, 2023

Author of #33368 here. I'm impressed. Didn't expect that fast response and turnaround. Bravo!

@ewbankkit ewbankkit mentioned this pull request Sep 11, 2023
Closed
@github-actions
Copy link

This functionality has been released in v5.16.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/athena Issues and PRs that pertain to the athena service. service/datasync Issues and PRs that pertain to the datasync service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/ipam Issues and PRs that pertain to the ipam service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/shield Issues and PRs that pertain to the shield service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.16.1
Development

Successfully merging this pull request may close these issues.

[Bug]: regression in regexp validation
3 participants
@YakDriver @dim13 @ewbankkit