FindSecurityGroupRulesBySecurityGroupID is failing for certain regions

[barbacbd]

Description

FindSecurityGroupRulesBySecurityGroupID is failing as Not Supported for SC2S regions with

Error: reading Security Group (sg-xxxxxx) Rules: UnsupportedOperation: The functionality you requested is not available in this region. 

Similar to other checks, skip this check if it is a govcloud or AWS China region.

Relations

Closes #33474

References

https://issues.redhat.com/browse/OCPBUGS-18830

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @barbacbd 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_egress$$\|TestAccVPCSecurityGroupRule_Ingress_vpc' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCSecurityGroupRule_egress$\|TestAccVPCSecurityGroupRule_Ingress_vpc -timeout 360m
=== RUN   TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN   TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== CONT  TestAccVPCSecurityGroupRule_Ingress_vpc
=== CONT  TestAccVPCSecurityGroupRule_egress
=== NAME  TestAccVPCSecurityGroupRule_Ingress_vpc
    vpc_security_group_rule_test.go:124: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"description": "",
          }
=== NAME  TestAccVPCSecurityGroupRule_egress
    vpc_security_group_rule_test.go:327: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"description": "",
          }
--- FAIL: TestAccVPCSecurityGroupRule_Ingress_vpc (26.61s)
--- FAIL: TestAccVPCSecurityGroupRule_egress (26.88s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	37.731s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

[ewbankkit]

@barbacbd Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.