Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support setting schedule timezone in aws_backup_plan #33605

Closed
peterv-work opened this issue Sep 24, 2023 · 5 comments · Fixed by #33653
Closed

[Enhancement]: Support setting schedule timezone in aws_backup_plan #33605

peterv-work opened this issue Sep 24, 2023 · 5 comments · Fixed by #33653
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service.
Milestone

Comments

@peterv-work
Copy link

Description

The aws_backup_plan lets you set the cron schedule in the rule block, but does not allow you to set which timezone the cron schedule should be evaluated in, which means that it defaults to UTC. The AWS console and the AWS CLI both support setting the timezone.

Affected Resource(s) and/or Data Source(s)

  • aws_backup_plan

Potential Terraform Configuration

resource "aws_backup_plan" "example" {
  name = "tf_example_backup_plan"

  rule {
    rule_name         = "tf_example_backup_rule"
    target_vault_name = aws_backup_vault.test.name
    schedule          = "cron(0 12 * * ? *)"
    schedule_timezone = "Pacific/Fiji"

    lifecycle {
      delete_after = 14
    }
  }

  advanced_backup_setting {
    backup_options = {
      WindowsVSS = "enabled"
    }
    resource_type = "EC2"
  }
}

References

https://docs.aws.amazon.com/cli/latest/reference/backup/create-backup-plan.html

Would you like to implement a fix?

None

@peterv-work peterv-work added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 24, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Sep 24, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 24, 2023
@autotune
Copy link
Contributor

autotune commented Sep 27, 2023

I'd like to work on this issue, it is about 75 percent done just need to add tests and verify a few things.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 26, 2023
@mbailey-eh
Copy link

Is this still going to be added? Thank you

Copy link

github-actions bot commented Oct 7, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.71.0 milestone Oct 7, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants