Rectify inconsistencies in DMS event subscription code and documentation

[saraogivinay]

Description

DMS event subscription has some inconsistencies as listed below:

1. source_type is defined as optional but can only take 2 valid values i.e. replication-instance or replication-task. In addition there is no default value set when optional resulting in terraform plan failure when undefined.
2. source_ids is defined as Required in the docs but is set to Optional in the code

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=dms

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @saraogivinay 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[saraogivinay]

Can any of the reviewers please review this PR ?

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEventSubscription_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSEventSubscription_ -timeout 360m
=== RUN   TestAccDMSEventSubscription_basic
=== PAUSE TestAccDMSEventSubscription_basic
=== RUN   TestAccDMSEventSubscription_disappears
=== PAUSE TestAccDMSEventSubscription_disappears
=== RUN   TestAccDMSEventSubscription_enabled
=== PAUSE TestAccDMSEventSubscription_enabled
=== RUN   TestAccDMSEventSubscription_eventCategories
=== PAUSE TestAccDMSEventSubscription_eventCategories
=== RUN   TestAccDMSEventSubscription_tags
=== PAUSE TestAccDMSEventSubscription_tags
=== CONT  TestAccDMSEventSubscription_basic
=== CONT  TestAccDMSEventSubscription_eventCategories
--- PASS: TestAccDMSEventSubscription_basic (1111.61s)
=== CONT  TestAccDMSEventSubscription_tags
--- PASS: TestAccDMSEventSubscription_eventCategories (1253.37s)
=== CONT  TestAccDMSEventSubscription_enabled
--- PASS: TestAccDMSEventSubscription_tags (1287.78s)
=== CONT  TestAccDMSEventSubscription_disappears
--- PASS: TestAccDMSEventSubscription_enabled (1216.22s)
--- PASS: TestAccDMSEventSubscription_disappears (1595.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	4000.743s

[ewbankkit]

@saraogivinay Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.