Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource bot version and add flattener for bot #33858

Merged
merged 16 commits into from
Nov 17, 2023
Merged

New resource bot version and add flattener for bot #33858

merged 16 commits into from
Nov 17, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Oct 10, 2023

Description

Add new resource bot version and add bot member flattener for bot

Relations

Relates #21375

Output from Acceptance Testing

> make testacc TESTS=TestAccLexV2ModelsBotVersion_ PKG=lexv2models
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBotVersion_'  -timeout 360m
=== RUN   TestAccLexV2ModelsBotVersion_basic
=== PAUSE TestAccLexV2ModelsBotVersion_basic
=== RUN   TestAccLexV2ModelsBotVersion_disappears
=== PAUSE TestAccLexV2ModelsBotVersion_disappears
=== CONT  TestAccLexV2ModelsBotVersion_basic
=== CONT  TestAccLexV2ModelsBotVersion_disappears
--- PASS: TestAccLexV2ModelsBotVersion_disappears (34.06s)
--- PASS: TestAccLexV2ModelsBotVersion_basic (35.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        38.944s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lexv2models Issues and PRs that pertain to the lexv2models service. labels Oct 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 10, 2023
Copy link

github-actions bot commented Nov 8, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@nam054 nam054 marked this pull request as ready for review November 16, 2023 01:30
@github-actions github-actions bot added the generators Relates to code generators. label Nov 16, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 🚀 . Just some small suggestions

$ make testacc TESTS=TestAccLexV2ModelsBotVersion_ PKG=lexv2models

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBotVersion_'  -timeout 360m
=== RUN   TestAccLexV2ModelsBotVersion_basic
=== PAUSE TestAccLexV2ModelsBotVersion_basic
=== RUN   TestAccLexV2ModelsBotVersion_disappears
=== PAUSE TestAccLexV2ModelsBotVersion_disappears
=== CONT  TestAccLexV2ModelsBotVersion_basic
=== CONT  TestAccLexV2ModelsBotVersion_disappears
--- PASS: TestAccLexV2ModelsBotVersion_disappears (152.55s)
--- PASS: TestAccLexV2ModelsBotVersion_basic (153.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	156.587s

internal/service/lexv2models/bot.go Outdated Show resolved Hide resolved
internal/service/lexv2models/bot_version.go Outdated Show resolved Hide resolved
internal/service/lexv2models/bot_version.go Outdated Show resolved Hide resolved
@nam054 nam054 merged commit e313e8f into main Nov 17, 2023
44 checks passed
@nam054 nam054 deleted the f-bot-version branch November 17, 2023 01:16
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 17, 2023
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants