-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_elasticache_replication_group: Fix error incorrectly forcing recreation when changing version from 6.x
to 6.2
#33954
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_EngineVersion_update\|TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheReplicationGroup_EngineVersion_update\|TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion -timeout 720m
=== RUN TestAccElastiCacheReplicationGroup_EngineVersion_update
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_update
=== RUN TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== CONT TestAccElastiCacheReplicationGroup_EngineVersion_update
=== CONT TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (1013.33s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (6628.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 6635.618s
This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The resource
aws_elasticache_replication_group
incorrectly identifies switching from version6.x
to6.2
as a downgrade, which requires a re-creation of the resource.Relations
Closes #28011
Supersedes #28877
Output from Acceptance Testing
TestAccElastiCacheReplicationGroup_tagWithOtherModification
is an unrelated error