Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws_identitystore_group update description attribute #34037

Merged

Conversation

Frezyy123
Copy link
Contributor

Description

Small bugfix for updatingaws_identitystore_group description attribute

Relations

Closes #28093

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccIdentityStoreGroup_descriptionChange PKG=identitystore
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroup_descriptionChange'  -timeout 360m
=== RUN   TestAccIdentityStoreGroup_descriptionChange
=== PAUSE TestAccIdentityStoreGroup_descriptionChange
=== CONT  TestAccIdentityStoreGroup_descriptionChange
--- PASS: TestAccIdentityStoreGroup_descriptionChange (69.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	71.409s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/identitystore Issues and PRs that pertain to the identitystore service. labels Oct 20, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 20, 2023
@Frezyy123 Frezyy123 force-pushed the f-aws_identitystore_group_description branch from c115ac3 to e116804 Compare October 20, 2023 19:48
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Frezyy123 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 23, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreGroup_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroup_ -timeout 360m
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== RUN   TestAccIdentityStoreGroup_descriptionChange
=== PAUSE TestAccIdentityStoreGroup_descriptionChange
=== CONT  TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroup_descriptionChange
--- PASS: TestAccIdentityStoreGroup_basic (27.99s)
=== CONT  TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_descriptionChange (42.81s)
--- PASS: TestAccIdentityStoreGroup_disappears (20.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	54.328s

@ewbankkit ewbankkit merged commit d96332a into hashicorp:main Oct 23, 2023
30 of 34 checks passed
@github-actions github-actions bot added this to the v5.23.0 milestone Oct 23, 2023
@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/identitystore Issues and PRs that pertain to the identitystore service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_identitystore_group description not updating
2 participants