-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aws_identitystore_group update description attribute #34037
fix: aws_identitystore_group update description attribute #34037
Conversation
Community NoteVoting for Prioritization
For Submitters
|
add changelog
c115ac3
to
e116804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Frezyy123 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIdentityStoreGroup_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2 -run=TestAccIdentityStoreGroup_ -timeout 360m
=== RUN TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== RUN TestAccIdentityStoreGroup_descriptionChange
=== PAUSE TestAccIdentityStoreGroup_descriptionChange
=== CONT TestAccIdentityStoreGroup_basic
=== CONT TestAccIdentityStoreGroup_descriptionChange
--- PASS: TestAccIdentityStoreGroup_basic (27.99s)
=== CONT TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_descriptionChange (42.81s)
--- PASS: TestAccIdentityStoreGroup_disappears (20.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/identitystore 54.328s
This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Small bugfix for updating
aws_identitystore_group
description attributeRelations
Closes #28093
References
Output from Acceptance Testing