[aws_dms_s3_endpoint] Remove the default value of false for add_trailing_padding_character

[sodle]

Description

Removes the default add_trailing_padding_character attribute for aws_dms_s3_endpoint resources. This default was previously false, but will now result in no value being specified (relying AWS's server-side default of false).

This fixes an incompatibility with old versions of the DMS engine (<3.4.7), which raise an error when this attribute is defined. Behavior will remain unchanged for DMS versions >=3.4.7.

Relations

Closes #32698

References

• AWS DMS release notes, showing the addition of the AddTrailingPaddingCharacter option in 3.4.7.

• AWS DMS S3Settings documentation, showing the default value of false if no AddTrailingPaddingCharacter option is specified.

Output from Acceptance Testing

% make testacc TESTS='TestAccDMSS3Endpoint*' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint*'  -timeout 360m
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== RUN   TestAccDMSS3Endpoint_update
=== PAUSE TestAccDMSS3Endpoint_update
=== RUN   TestAccDMSS3Endpoint_simple
=== PAUSE TestAccDMSS3Endpoint_simple
=== RUN   TestAccDMSS3Endpoint_sourceSimple
=== PAUSE TestAccDMSS3Endpoint_sourceSimple
=== RUN   TestAccDMSS3Endpoint_source
=== PAUSE TestAccDMSS3Endpoint_source
=== RUN   TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSS3Endpoint_basic
=== CONT  TestAccDMSS3Endpoint_sourceSimple
=== CONT  TestAccDMSS3Endpoint_simple
=== CONT  TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSS3Endpoint_source
=== CONT  TestAccDMSS3Endpoint_update
--- PASS: TestAccDMSS3Endpoint_basic (338.94s)
--- PASS: TestAccDMSS3Endpoint_simple (363.90s)
--- PASS: TestAccDMSS3Endpoint_sourceSimple (371.75s)
--- PASS: TestAccDMSS3Endpoint_source (423.80s)
--- PASS: TestAccDMSS3Endpoint_update (467.55s)
--- PASS: TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet (539.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        541.464s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSS3Endpoint_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSS3Endpoint_ -timeout 360m
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== RUN   TestAccDMSS3Endpoint_update
=== PAUSE TestAccDMSS3Endpoint_update
=== RUN   TestAccDMSS3Endpoint_simple
=== PAUSE TestAccDMSS3Endpoint_simple
=== RUN   TestAccDMSS3Endpoint_sourceSimple
=== PAUSE TestAccDMSS3Endpoint_sourceSimple
=== RUN   TestAccDMSS3Endpoint_source
=== PAUSE TestAccDMSS3Endpoint_source
=== RUN   TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSS3Endpoint_basic
=== CONT  TestAccDMSS3Endpoint_sourceSimple
--- PASS: TestAccDMSS3Endpoint_basic (45.12s)
=== CONT  TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
--- PASS: TestAccDMSS3Endpoint_sourceSimple (52.92s)
=== CONT  TestAccDMSS3Endpoint_source
--- PASS: TestAccDMSS3Endpoint_source (65.33s)
=== CONT  TestAccDMSS3Endpoint_simple
--- PASS: TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet (105.01s)
=== CONT  TestAccDMSS3Endpoint_update
--- PASS: TestAccDMSS3Endpoint_simple (63.45s)
--- PASS: TestAccDMSS3Endpoint_update (72.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	227.661s

[ewbankkit]

@sodle Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.