[Enhancement]: r/aws_redshift_cluster: Support managed master passwords

[jar-b]

Description

The Redshift [Create|Modify]Cluster API's include a ManageMasterPassword argument, which is not implemented in the corresponding Terraform resource. Support should be added similar to the implementation for aws_db_instance.

ManageMasterPassword
If true, Amazon Redshift uses AWS Secrets Manager to manage this cluster's admin credentials. You can't use MasterUserPassword if ManageMasterPassword is true. If ManageMasterPassword is false or not set, Amazon Redshift uses MasterUserPassword for the admin user account's password.

Type: Boolean

Required: No

Affected Resource(s) and/or Data Source(s)

• aws_redshift_cluster

Potential Terraform Configuration

resource "aws_redshift_cluster" "example" {
  cluster_identifier = "tf-redshift-cluster"
  database_name      = "mydb"
  master_username    = "exampleuser"
  node_type          = "dc1.large"
  cluster_type       = "single-node"

  manage_master_password = true
}

References

• https://docs.aws.amazon.com/redshift/latest/APIReference/API_CreateCluster.html
• https://docs.aws.amazon.com/redshift/latest/APIReference/API_ModifyCluster.html
• https://docs.aws.amazon.com/redshift/latest/mgmt/redshift-secrets-manager-integration.html
• Relates Support for AWS::SecretsManager::SecretTargetAttachment #9183

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[DrFaust92]

taking a look

[jar-b]

@DrFaust92 - Apologies, I've started on this but forgot to assign myself. Should have a PR up in a bit.

[DrFaust92]

@jar-b NP, good thing i didnt start running tests as it would've taken a while

[github-actions]

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.