Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the update of KxCluster databases and code configuration #34220

Merged

Conversation

matthiasweaser
Copy link
Contributor

@matthiasweaser matthiasweaser commented Nov 2, 2023

Description

This pull request introduces changes that allow users to update KxCluster databases and code configuration without having to destroy and recreate a KxCluster resource.

Testing

For acceptance tests relating to these changes, environment deletion is triggered immediately after cluster deletion since cluster deletion no longer waits for the deletion workflow to complete before being marked as "deleted". We are working on a fix for this but essentially this bug is on our side and non-terraform related other than breaking all our existing cluster acceptance tests.

This results in our acceptance tests successfully updating the cluster resource but failing at the resource cleanup step. All other steps of the tests completed successfully.

Acceptance Tests updated:

  • TestAccFinSpaceKxCluster_commandLineArgs
  • TestAccFinSpaceKxCluster_initializationScript
  • TestAccFinSpaceKxCluster_code

Manual testing has been done in place to ensure that the behavior of cluster updates are as desired.

References

API documentation for UpdateKxClusterDatabases: https://docs.aws.amazon.com/cli/latest/reference/finspace/update-kx-cluster-databases.html

Copy link

github-actions bot commented Nov 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/finspace Issues and PRs that pertain to the finspace service. labels Nov 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @matthiasweaser 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 2, 2023
@jar-b jar-b self-assigned this Nov 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 2, 2023
@jar-b jar-b merged commit 6d7cde6 into hashicorp:main Nov 2, 2023
43 checks passed
@jar-b
Copy link
Member

jar-b commented Nov 2, 2023

Thanks for your contribution, @matthiasweaser! 👏

@github-actions github-actions bot added this to the v5.24.0 milestone Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/finspace Issues and PRs that pertain to the finspace service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants