Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_mq_engine_versions + add sdkv2 client for mq #34232

Merged
merged 9 commits into from
Dec 22, 2023

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Nov 2, 2023

Description

Adds Data lookup for Engine Versions

Relations

Closes #34168

References

Output from Acceptance Testing

% make testacc TESTS=TestAccMQEngineVersionsDataSource_ PKG=mq                                                                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 20 -run='TestAccMQEngineVersionsDataSource_'  -timeout 360m
=== RUN   TestAccMQEngineVersionsDataSource_basic
=== PAUSE TestAccMQEngineVersionsDataSource_basic
=== CONT  TestAccMQEngineVersionsDataSource_basic
--- PASS: TestAccMQEngineVersionsDataSource_basic (16.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 19.028s

Notes to maintainers:

  • It doesn't looks like there's a v2 client to use sdkv2, so I just used the existing conn.
  • I created a filters block. Im happy to remove that and just have engine_type in the root of the schema to better align with the sdk, since there's technically no filters, but this way more aligned to how other resources are setup.

Copy link

github-actions bot commented Nov 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mq Issues and PRs that pertain to the mq service. generators Relates to code generators. labels Nov 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2023
@danquack danquack changed the title d/ mq broker versions d/aws_mq_engine_versions Nov 2, 2023
Copy link

github-actions bot commented Nov 3, 2023

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@danquack danquack changed the title d/aws_mq_engine_versions d/aws_mq_engine_versions + add sdkv2 client for mq Nov 3, 2023
@github-actions github-actions bot added the client-connections Pertains to the AWS Client and service connections. label Nov 3, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2023
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Dec 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMQBrokerEngineTypesDataSource_' PKG=mq
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 20  -run=TestAccMQBrokerEngineTypesDataSource_ -timeout 360m
=== RUN   TestAccMQBrokerEngineTypesDataSource_basic
=== PAUSE TestAccMQBrokerEngineTypesDataSource_basic
=== CONT  TestAccMQBrokerEngineTypesDataSource_basic
--- PASS: TestAccMQBrokerEngineTypesDataSource_basic (12.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	17.498s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.
I renamed the data source to aws_mq_broker_engine_types, matching the underlying AWS API.

@ewbankkit ewbankkit merged commit e65a530 into hashicorp:main Dec 22, 2023
50 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 22, 2023
@danquack danquack deleted the 34168 branch December 22, 2023 17:19
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-data-source Introduces a new data source. service/mq Issues and PRs that pertain to the mq service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for engine versions
4 participants