-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde support to csv_classifier #34251
Add serde support to csv_classifier #34251
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
To ensure that this PR had good hygiene for merge, I rebased (since it's been open for a while), and squashed the commits into one. Let me know if there's anything else I can do to help facilitate review and merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccGlueClassifier_' PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlueClassifier_ -timeout 360m
--- PASS: TestAccGlueClassifier_disappears (52.46s)
--- PASS: TestAccGlueClassifier_GrokClassifier_customPatterns (83.48s)
--- PASS: TestAccGlueClassifier_grokClassifier (84.00s)
--- PASS: TestAccGlueClassifier_jsonClassifier (84.00s)
--- PASS: TestAccGlueClassifier_xmlClassifier (84.43s)
--- PASS: TestAccGlueClassifier_CSVClassifier_custom (84.44s)
--- PASS: TestAccGlueClassifier_csvClassifier (84.47s)
--- PASS: TestAccGlueClassifier_CSVClassifier_quoteSymbol (84.61s)
--- PASS: TestAccGlueClassifier_csvClassifierCustomSerde (86.25s)
--- PASS: TestAccGlueClassifier_typeChange (113.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 117.490s
@PatrickRice-KSC thank you for the contribution! 🎉 |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for defining the
serde
attribute when creating aaws_glue_classifier
with acsv_classifier
block, allowing users to define the exact serde they want to use for a classifier instead of relying on Glue's inferrence.Relations
Closes #33787
References
Output from Acceptance Testing
Pending