Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_sagemaker_user_profile: Fix crash #34418

Merged
merged 2 commits into from
Nov 15, 2023
Merged

r/aws_sagemaker_user_profile: Fix crash #34418

merged 2 commits into from
Nov 15, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 15, 2023 •
edited
Loading

Description

Changes default_user_settings.canvas_app_settings.identity_provider_oauth_settings from TypeSet to TypeList, preventing interface conversion: interface {} is *schema.Set, not []interface {} panics.

Relations

Closes #34366.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccSageMaker_serial/Domain\|TestAccSageMaker_serial/UserProfile' PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/Domain\|TestAccSageMaker_serial/UserProfile -timeout 720m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/identityProviderOauthSettings
=== RUN   TestAccSageMaker_serial/Domain/directDeploySettings
=== RUN   TestAccSageMaker_serial/Domain/rSessionAppSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/code
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kms
=== RUN   TestAccSageMaker_serial/Domain/workspaceSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage
    domain_test.go:661: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage
    domain_test.go:700: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/securityGroup
=== RUN   TestAccSageMaker_serial/Domain/sharingSettings
=== RUN   TestAccSageMaker_serial/Domain/canvas
=== RUN   TestAccSageMaker_serial/Domain/modelRegisterSettings
=== RUN   TestAccSageMaker_serial/Domain/kendraSettings
=== RUN   TestAccSageMaker_serial/Domain/domainSettings
=== RUN   TestAccSageMaker_serial/Domain/basic
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProAppSettings
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated
=== RUN   TestAccSageMaker_serial/Domain/disappears
=== RUN   TestAccSageMaker_serial/Domain/tags
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/basic
--- PASS: TestAccSageMaker_serial (8337.58s)
    --- PASS: TestAccSageMaker_serial/Domain (6150.77s)
        --- PASS: TestAccSageMaker_serial/Domain/identityProviderOauthSettings (261.21s)
        --- PASS: TestAccSageMaker_serial/Domain/directDeploySettings (259.52s)
        --- PASS: TestAccSageMaker_serial/Domain/rSessionAppSettings (262.61s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings (288.06s)
        --- PASS: TestAccSageMaker_serial/Domain/code (249.66s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (248.66s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (259.94s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (250.77s)
        --- PASS: TestAccSageMaker_serial/Domain/workspaceSettings (251.12s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/securityGroup (278.87s)
        --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (262.21s)
        --- PASS: TestAccSageMaker_serial/Domain/canvas (250.40s)
        --- PASS: TestAccSageMaker_serial/Domain/modelRegisterSettings (251.77s)
        --- PASS: TestAccSageMaker_serial/Domain/kendraSettings (260.63s)
        --- PASS: TestAccSageMaker_serial/Domain/domainSettings (283.67s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (248.94s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (306.83s)
        --- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (302.49s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (259.62s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (262.04s)
        --- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated (294.39s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (298.36s)
        --- PASS: TestAccSageMaker_serial/Domain/tags (258.99s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2186.81s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (264.24s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (270.23s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (287.65s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (266.77s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (265.56s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (265.52s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (303.43s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (263.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	8343.216s

@ewbankkit
r/aws_sagemaker_user_profile: Change `default_user_settings.canvas_ap…
346b142 
…p_settings.identity_provider_oauth_settings` from TypeSet to TypeList, preventing `interface conversion: interface {} is *schema.Set, not []interface {}` panics.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. size/S Managed by automation to categorize the size of a PR. labels Nov 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 15, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Nov 15, 2023
jar-b
jar-b approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit merged commit 6df0cc3 into main Nov 15, 2023
63 checks passed
@ewbankkit ewbankkit deleted the b-aws_sagemaker_domain.canvas_app_settings branch November 15, 2023 18:23
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 15, 2023
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Update CHANGELOG.md for #34418
2ffccb4
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.26.0
Development

Successfully merging this pull request may close these issues.

[Bug]: sagemaker.expandCanvasAppSettings exception in AWS 5.25 provider
3 participants
@ewbankkit @jar-b @justinretzolk