Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New]: AWS Cost Optimization Hub #34588

Closed
bebold-jhr opened this issue Nov 28, 2023 · 8 comments · Fixed by #36526
Closed

[New]: AWS Cost Optimization Hub #34588

bebold-jhr opened this issue Nov 28, 2023 · 8 comments · Fixed by #36526
Assignees
Labels
new-service Introduces a new service.
Milestone

Comments

@bebold-jhr
Copy link

Description

Cost Optimization Hub is a new AWS Billing and Cost Management feature that helps you consolidate and prioritize cost optimization recommendations across your AWS Organizations member accounts and AWS Regions, so that you can get the most out of your AWS spend.

Requested Resource(s) and/or Data Source(s)

  • aws_cost_optimization_hub_config

Potential Terraform Configuration

No response

References

Announcement: https://aws.amazon.com/about-aws/whats-new/2023/11/cost-optimization-hub/
Product Page: https://aws.amazon.com/aws-cost-management/cost-optimization-hub/
AWS CLI since 1.30.7: https://github.com/aws/aws-cli/blob/0f81aeeda03b78d9b6eb9d439cc6213c49ad15b9/.changes/1.30.7.json#L14

Would you like to implement a fix?

No

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2023
@justinretzolk justinretzolk added new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2024
@madhavvishnubhatta
Copy link
Contributor

madhavvishnubhatta commented Feb 15, 2024

I am trying to work on creating resources for this, but I feel it is better to have two different resources. One for EnrollmentStatus and one for Preferences as that is how the API is structured - https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_Operations_Cost_Optimization_Hub.html

Something like

  • aws_costoptimiztionhub_enrollment_status
  • aws_costoptimizationhub_preferences

@madhavvishnubhatta
Copy link
Contributor

madhavvishnubhatta commented Feb 22, 2024

After working on this a bit more and thinking about it, I feel a single resource makes more sense. But calling the resource aws_costoptimizationhub_enrollment seems more appropriate as that aligns neatly with the idea that the resource creation, "creates" an "enrollment". That is, when the enrollment resource is "Created" then the account enrolls for cost optimization hub, with the provided preferences. When the enrollment resource is "Destroyed" and then the account unenrolls.

But if the enrollment_status is a resource, then that is not accurate, as destroying the resource, does not mean there is no status. It just means that the status is Inactive.

Moreover, combining them also goes well with the fact that the concept of "preferences" does not exist for an account not enrolled into Cost Optimization Hub. So it is more logical to make the preferences be the attributes of the "enrollment" resource rather than as preferences being a separate resource by itself.

@lblazewski
Copy link

Looking forward for this one!

@vponoikoait
Copy link

@YakDriver YakDriver self-assigned this Sep 10, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 10, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.