aws_batch_job_queue add compute_environment_order and deprecate compute_environments

[drewmullen]

Description

• compute_environments (CEs) and compute_environment_order (CEOs) are mutually exclusive
• In order to preserve schema migration, compute_environments must stay as the "default" or it will cause breaking changes when a users schema is migrated from CEs in state without requiring them to update their HCL to use CEOs.
• Because import requires CEs it is impossible to migrate to CEOs parameter :/ You must have done the initial Create with it

Relations

Closes #34760
Closes #19247
Closes #20764

Does not close or resolve #34794 however, migration does appear to work as expected

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccBatchJobQueue_ PKG=batch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobQueue_'  -timeout 360m
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== RUN   TestAccBatchJobQueue_basicCEO
=== PAUSE TestAccBatchJobQueue_basicCEO
=== RUN   TestAccBatchJobQueue_disappears
=== PAUSE TestAccBatchJobQueue_disappears
=== RUN   TestAccBatchJobQueue_disappearsCEO
=== PAUSE TestAccBatchJobQueue_disappearsCEO
=== RUN   TestAccBatchJobQueue_MigrateFromPluginSDK
=== PAUSE TestAccBatchJobQueue_MigrateFromPluginSDK
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== RUN   TestAccBatchJobQueue_priority
=== PAUSE TestAccBatchJobQueue_priority
=== RUN   TestAccBatchJobQueue_schedulingPolicy
=== PAUSE TestAccBatchJobQueue_schedulingPolicy
=== RUN   TestAccBatchJobQueue_state
=== PAUSE TestAccBatchJobQueue_state
=== RUN   TestAccBatchJobQueue_tags
=== PAUSE TestAccBatchJobQueue_tags
=== CONT  TestAccBatchJobQueue_basic
=== CONT  TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== CONT  TestAccBatchJobQueue_disappearsCEO
=== CONT  TestAccBatchJobQueue_disappears
=== CONT  TestAccBatchJobQueue_tags
=== CONT  TestAccBatchJobQueue_priority
=== CONT  TestAccBatchJobQueue_MigrateFromPluginSDK
=== CONT  TestAccBatchJobQueue_schedulingPolicy
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_multiple
=== CONT  TestAccBatchJobQueue_state
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== CONT  TestAccBatchJobQueue_basicCEO
=== NAME  TestAccBatchJobQueue_MigrateFromPluginSDK
    testing_new.go:80: Error retrieving state, there may be dangling resources: exit status 1
        Failed to marshal state to json: schema version 0 for aws_batch_job_queue.test in state does not match version 1 from the provider
--- FAIL: TestAccBatchJobQueue_MigrateFromPluginSDK (225.20s)
--- PASS: TestAccBatchJobQueue_disappearsCEO (533.22s)
--- PASS: TestAccBatchJobQueue_disappears (533.37s)
--- PASS: TestAccBatchJobQueue_basic (542.01s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate (543.04s)
--- PASS: TestAccBatchJobQueue_basicCEO (547.48s)
--- PASS: TestAccBatchJobQueue_priority (705.88s)
--- PASS: TestAccBatchJobQueue_state (716.18s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple (767.04s)
--- PASS: TestAccBatchJobQueue_schedulingPolicy (770.29s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_multiple (778.00s)
--- PASS: TestAccBatchJobQueue_tags (801.21s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/batch      803.366s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[AdamTylerLynch]

LGTM 🚀

[nithinvenugopal]

@danquack @drewmullen any update on this?

[drewmullen]

@nithinvenugopal just waiting for it to be merged and released. Not up to me /shrug

[gdavison]

Looks good! 🚀

--- FAIL: TestAccBatchJobQueue_MigrateFromPluginSDK (56.11s)
--- PASS: TestAccBatchJobQueue_disappears (96.94s)
--- PASS: TestAccBatchJobQueue_disappearsCEO (100.21s)
--- PASS: TestAccBatchJobQueue_basic (101.46s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate (109.78s)
--- PASS: TestAccBatchJobQueue_basicCEO (110.14s)
--- PASS: TestAccBatchJobQueue_tags (115.58s)
--- PASS: TestAccBatchJobQueue_priority (148.34s)
--- PASS: TestAccBatchJobQueue_schedulingPolicy (148.96s)
--- PASS: TestAccBatchJobQueue_state (148.96s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_multiple (151.33s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple (166.04s)

TestAccBatchJobQueue_MigrateFromPluginSDK is a pre-existing failure

[github-actions]

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.