Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fsx_lustre_file_system - support modification of per_unit_storage_throughput parameter #34932

Conversation

sasidhar-aws
Copy link
Contributor

Description

aws_fsx_lustre_file_system supports modification of per_unit_storage_throughput parameter without recreation and destruction of the filesystem.

Relations

Closes #34862

References

https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-fsx-lustre-adjust-throughput-tier-file-systems/

Output from Acceptance Testing

make testacc TESTS=TestAccFSxLustreFileSystem_deploymentTypePersistent PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxLustreFileSystem_deploymentTypePersistent'  -timeout 360m
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent1_perunitstoragethroughput
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent1_perunitstoragethroughput
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2_perunitstoragethroughput
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2_perunitstoragethroughput
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2_perunitstoragethroughput
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent1_perunitstoragethroughput
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2 (613.61s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent1 (674.79s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2_perunitstoragethroughput (925.38s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent1_perunitstoragethroughput (958.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	968.041s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. labels Dec 14, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 14, 2023
@sasidhar-aws sasidhar-aws changed the title Updation of per_unit_storage_throughput parameter for existing file system r/aws_fsx_lustre_file_system - support modification of per_unit_storage_throughput parameter Dec 14, 2023
@sasidhar-aws sasidhar-aws force-pushed the f-aws_fsx_lustre_file_system_per_unit_storage_throughput branch from d70b4a8 to a77fa4c Compare December 14, 2023 22:41
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2023
@ewbankkit ewbankkit self-assigned this Jan 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 4, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxLustreFileSystem_dataCompression\|TestAccFSxLustreFileSystem_basic\|TestAccFSxLustreFileSystem_deploymentTypePersistent1_per\|TestAccFSxLustreFileSystem_deploymentTypePersistent2_per' PKG=fsx ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2  -run=TestAccFSxLustreFileSystem_dataCompression\|TestAccFSxLustreFileSystem_basic\|TestAccFSxLustreFileSystem_deploymentTypePersistent1_per\|TestAccFSxLustreFileSystem_deploymentTypePersistent2_per -timeout 360m
=== RUN   TestAccFSxLustreFileSystem_basic
=== PAUSE TestAccFSxLustreFileSystem_basic
=== RUN   TestAccFSxLustreFileSystem_dataCompression
=== PAUSE TestAccFSxLustreFileSystem_dataCompression
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent1_perUnitStorageThroughput
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent1_perUnitStorageThroughput
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2_perUnitStorageThroughput
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2_perUnitStorageThroughput
=== CONT  TestAccFSxLustreFileSystem_basic
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent1_perUnitStorageThroughput
--- PASS: TestAccFSxLustreFileSystem_basic (607.46s)
=== CONT  TestAccFSxLustreFileSystem_dataCompression
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent1_perUnitStorageThroughput (982.52s)
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2_perUnitStorageThroughput
--- PASS: TestAccFSxLustreFileSystem_dataCompression (737.10s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2_perUnitStorageThroughput (899.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1887.529s

@ewbankkit
Copy link
Contributor

@sasidhar-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2e9d2e5 into hashicorp:main Jan 4, 2024
55 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 4, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/fsx Issues and PRs that pertain to the fsx service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for resizing throughput requirements for FSx Lustre
4 participants