Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging_config in aws_lambda_function resource #35050

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Add support for logging_config in aws_lambda_function resource #35050

merged 4 commits into from
Dec 22, 2023

Conversation

JamesJJ
Copy link
Contributor

@JamesJJ JamesJJ commented Dec 22, 2023

Description

Add logging_config configuration block in support of AWS Lambda advanced logging controls.

Relations

Closes #34455

References

Output from Acceptance Testing

% make testacc 'TESTS=TestAccLambdaFunction(DataSource)?_(basic|loggingConfig)'  PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction(DataSource)?_(basic|loggingConfig)'  -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_loggingConfig
=== PAUSE TestAccLambdaFunctionDataSource_loggingConfig
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_loggingConfig
=== PAUSE TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_loggingConfig
--- PASS: TestAccLambdaFunctionDataSource_basic (46.67s)
--- PASS: TestAccLambdaFunction_basic (66.52s)
--- PASS: TestAccLambdaFunctionDataSource_loggingConfig (82.18s)
--- PASS: TestAccLambdaFunction_loggingConfig (99.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	102.569s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. labels Dec 22, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 22, 2023
@JamesJJ JamesJJ marked this pull request as ready for review December 22, 2023 16:54
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 22, 2023
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 22, 2023
@ewbankkit ewbankkit self-assigned this Dec 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_loggingConfig\|TestAccLambdaFunctionDataSource_basic\|TestAccLambdaFunctionDataSource_loggingConfig' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2  -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_loggingConfig\|TestAccLambdaFunctionDataSource_basic\|TestAccLambdaFunctionDataSource_loggingConfig -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_loggingConfig
=== PAUSE TestAccLambdaFunctionDataSource_loggingConfig
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_loggingConfig
=== PAUSE TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunction_basic
--- PASS: TestAccLambdaFunctionDataSource_basic (32.02s)
=== CONT  TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_loggingConfig
--- PASS: TestAccLambdaFunction_basic (46.50s)
--- PASS: TestAccLambdaFunctionDataSource_loggingConfig (50.22s)
--- PASS: TestAccLambdaFunction_loggingConfig (65.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	103.402s

@ewbankkit
Copy link
Contributor

@JamesJJ Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e1e5dcd into hashicorp:main Dec 22, 2023
72 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 22, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Michagogo
Copy link
Contributor

It seems the optional arguments aren’t handled properly in terms of default values being read on refresh, see above bug

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lambda Issues and PRs that pertain to the lambda service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Lambda advanced logging controls
3 participants