-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for logging_config in aws_lambda_function
resource
#35050
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Signed-off-by: JamesJJ <[email protected]>
Signed-off-by: JamesJJ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_loggingConfig\|TestAccLambdaFunctionDataSource_basic\|TestAccLambdaFunctionDataSource_loggingConfig' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2 -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_loggingConfig\|TestAccLambdaFunctionDataSource_basic\|TestAccLambdaFunctionDataSource_loggingConfig -timeout 360m
=== RUN TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN TestAccLambdaFunctionDataSource_loggingConfig
=== PAUSE TestAccLambdaFunctionDataSource_loggingConfig
=== RUN TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN TestAccLambdaFunction_loggingConfig
=== PAUSE TestAccLambdaFunction_loggingConfig
=== CONT TestAccLambdaFunctionDataSource_basic
=== CONT TestAccLambdaFunction_basic
--- PASS: TestAccLambdaFunctionDataSource_basic (32.02s)
=== CONT TestAccLambdaFunction_loggingConfig
=== CONT TestAccLambdaFunctionDataSource_loggingConfig
--- PASS: TestAccLambdaFunction_basic (46.50s)
--- PASS: TestAccLambdaFunctionDataSource_loggingConfig (50.22s)
--- PASS: TestAccLambdaFunction_loggingConfig (65.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 103.402s
@JamesJJ Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
It seems the optional arguments aren’t handled properly in terms of default values being read on refresh, see above bug |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
logging_config
configuration block in support of AWS Lambda advanced logging controls.Relations
Closes #34455
References
Output from Acceptance Testing