Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate kinesis resources to AWS SDK for Go v2 #35167

Merged
merged 24 commits into from
Jan 8, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 5, 2024

Description

Also adds aws_kinesis_resource_policy.

Relations

Closes #34684.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccKinesis' PKG=kinesis ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 3  -run=TestAccKinesis -timeout 360m
=== RUN   TestAccKinesisStreamConsumerDataSource_basic
=== PAUSE TestAccKinesisStreamConsumerDataSource_basic
=== RUN   TestAccKinesisStreamConsumerDataSource_name
=== PAUSE TestAccKinesisStreamConsumerDataSource_name
=== RUN   TestAccKinesisStreamConsumerDataSource_arn
=== PAUSE TestAccKinesisStreamConsumerDataSource_arn
=== RUN   TestAccKinesisStreamConsumer_basic
=== PAUSE TestAccKinesisStreamConsumer_basic
=== RUN   TestAccKinesisStreamConsumer_disappears
=== PAUSE TestAccKinesisStreamConsumer_disappears
=== RUN   TestAccKinesisStreamConsumer_maxConcurrentConsumers
=== PAUSE TestAccKinesisStreamConsumer_maxConcurrentConsumers
=== RUN   TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
=== PAUSE TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_disappears
=== PAUSE TestAccKinesisStream_disappears
=== RUN   TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN   TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN   TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN   TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN   TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN   TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN   TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN   TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== RUN   TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStreamConsumerDataSource_basic
=== CONT  TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== CONT  TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (39.88s)
=== CONT  TestAccKinesisStreamConsumer_basic
--- PASS: TestAccKinesisStreamConsumerDataSource_basic (63.80s)
=== CONT  TestAccKinesisStreamConsumer_maxConcurrentConsumers
--- PASS: TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers (86.40s)
=== CONT  TestAccKinesisStreamConsumer_disappears
--- PASS: TestAccKinesisStreamConsumer_basic (65.25s)
=== CONT  TestAccKinesisStreamConsumerDataSource_arn
--- PASS: TestAccKinesisStreamConsumer_maxConcurrentConsumers (66.31s)
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStreamConsumer_disappears (59.68s)
=== CONT  TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
--- PASS: TestAccKinesisStreamConsumerDataSource_arn (64.01s)
=== CONT  TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (55.39s)
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_updateKMSKeyID
--- PASS: TestAccKinesisStream_tags (73.75s)
--- PASS: TestAccKinesisStream_basicOnDemand (50.67s)
=== CONT  TestAccKinesisStreamConsumerDataSource_name
--- PASS: TestAccKinesisStream_updateKMSKeyID (82.74s)
=== CONT  TestAccKinesisStream_disappears
--- PASS: TestAccKinesisStreamConsumerDataSource_name (62.91s)
=== CONT  TestAccKinesisStream_createMultipleConcurrentStreams
--- PASS: TestAccKinesisStream_disappears (48.48s)
=== CONT  TestAccKinesisStream_retentionPeriod
--- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (180.70s)
=== CONT  TestAccKinesisStream_enforceConsumerDeletion
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (50.80s)
=== CONT  TestAccKinesisStream_shardLevelMetrics
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (100.72s)
=== CONT  TestAccKinesisStream_shardCount
--- PASS: TestAccKinesisStream_retentionPeriod (94.51s)
=== CONT  TestAccKinesisStream_encryption
--- PASS: TestAccKinesisStream_shardLevelMetrics (107.31s)
=== CONT  TestAccKinesisStream_basic
--- PASS: TestAccKinesisStream_encryption (117.74s)
=== CONT  TestAccKinesisStreamDataSource_basic
--- PASS: TestAccKinesisStream_basic (51.64s)
--- PASS: TestAccKinesisStreamDataSource_basic (102.21s)
--- PASS: TestAccKinesisStream_shardCount (779.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	1201.139s
% make testacc TESTARGS='-run=TestAccKinesisResourcePolicy_' PKG=kinesis     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20  -run=TestAccKinesisResourcePolicy_ -timeout 360m
=== RUN   TestAccKinesisResourcePolicy_basic
=== PAUSE TestAccKinesisResourcePolicy_basic
=== RUN   TestAccKinesisResourcePolicy_disappears
--- PASS: TestAccKinesisResourcePolicy_disappears (55.58s)
=== CONT  TestAccKinesisResourcePolicy_basic
--- PASS: TestAccKinesisResourcePolicy_basic (58.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	120.236s

% make testacc TESTARGS='-run=TestAccKinesis' PKG=kinesis ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 3  -run=TestAccKinesis -timeout 360m
=== RUN   TestAccKinesisStreamConsumerDataSource_basic
=== PAUSE TestAccKinesisStreamConsumerDataSource_basic
=== RUN   TestAccKinesisStreamConsumerDataSource_name
=== PAUSE TestAccKinesisStreamConsumerDataSource_name
=== RUN   TestAccKinesisStreamConsumerDataSource_arn
=== PAUSE TestAccKinesisStreamConsumerDataSource_arn
=== RUN   TestAccKinesisStreamConsumer_basic
=== PAUSE TestAccKinesisStreamConsumer_basic
=== RUN   TestAccKinesisStreamConsumer_disappears
=== PAUSE TestAccKinesisStreamConsumer_disappears
=== RUN   TestAccKinesisStreamConsumer_maxConcurrentConsumers
=== PAUSE TestAccKinesisStreamConsumer_maxConcurrentConsumers
=== RUN   TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
=== PAUSE TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_disappears
=== PAUSE TestAccKinesisStream_disappears
=== RUN   TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN   TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN   TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN   TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN   TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN   TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN   TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN   TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== RUN   TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStreamConsumerDataSource_basic
=== CONT  TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== CONT  TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (39.88s)
=== CONT  TestAccKinesisStreamConsumer_basic
--- PASS: TestAccKinesisStreamConsumerDataSource_basic (63.80s)
=== CONT  TestAccKinesisStreamConsumer_maxConcurrentConsumers
--- PASS: TestAccKinesisStreamConsumer_exceedMaxConcurrentConsumers (86.40s)
=== CONT  TestAccKinesisStreamConsumer_disappears
--- PASS: TestAccKinesisStreamConsumer_basic (65.25s)
=== CONT  TestAccKinesisStreamConsumerDataSource_arn
--- PASS: TestAccKinesisStreamConsumer_maxConcurrentConsumers (66.31s)
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStreamConsumer_disappears (59.68s)
=== CONT  TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
--- PASS: TestAccKinesisStreamConsumerDataSource_arn (64.01s)
=== CONT  TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (55.39s)
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_updateKMSKeyID
--- PASS: TestAccKinesisStream_tags (73.75s)
--- PASS: TestAccKinesisStream_basicOnDemand (50.67s)
=== CONT  TestAccKinesisStreamConsumerDataSource_name
--- PASS: TestAccKinesisStream_updateKMSKeyID (82.74s)
=== CONT  TestAccKinesisStream_disappears
--- PASS: TestAccKinesisStreamConsumerDataSource_name (62.91s)
=== CONT  TestAccKinesisStream_createMultipleConcurrentStreams
--- PASS: TestAccKinesisStream_disappears (48.48s)
=== CONT  TestAccKinesisStream_retentionPeriod
--- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (180.70s)
=== CONT  TestAccKinesisStream_enforceConsumerDeletion
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (50.80s)
=== CONT  TestAccKinesisStream_shardLevelMetrics
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (100.72s)
=== CONT  TestAccKinesisStream_shardCount
--- PASS: TestAccKinesisStream_retentionPeriod (94.51s)
=== CONT  TestAccKinesisStream_encryption
--- PASS: TestAccKinesisStream_shardLevelMetrics (107.31s)
=== CONT  TestAccKinesisStream_basic
--- PASS: TestAccKinesisStream_encryption (117.74s)
=== CONT  TestAccKinesisStreamDataSource_basic
--- PASS: TestAccKinesisStream_basic (51.64s)
--- PASS: TestAccKinesisStreamDataSource_basic (102.21s)
--- PASS: TestAccKinesisStream_shardCount (779.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	1201.139s
Copy link

github-actions bot commented Jan 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kinesis Issues and PRs that pertain to the kinesis service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jan 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 5, 2024
@ewbankkit ewbankkit added new-resource Introduces a new resource. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jan 5, 2024
@ewbankkit ewbankkit changed the title [WIP] Tech debt: Migratekinesis resources to AWS SDK for Go v2 Tech debt: Migratekinesis resources to AWS SDK for Go v2 Jan 8, 2024
@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Jan 8, 2024
@ewbankkit ewbankkit merged commit 84af1c1 into main Jan 8, 2024
61 checks passed
@ewbankkit ewbankkit deleted the td-migrate-kinesis-to-aws-sdk-v2 branch January 8, 2024 13:12
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 8, 2024
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
@ewbankkit ewbankkit changed the title Tech debt: Migratekinesis resources to AWS SDK for Go v2 Tech debt: Migrate kinesis resources to AWS SDK for Go v2 Jan 8, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/kinesis Issues and PRs that pertain to the kinesis service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Kinesis data stream resource policies
2 participants