Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assorted S3 bucket configuration resources #35775

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 12, 2024

Description

Fixes bugs or acceptance test errors in various S3 bucket configuration resources:

  • aws_s3_bucket_acl
  • aws_s3_bucket_analytics_configuration
  • aws_s3_bucket_cors_configuration
  • aws_s3_bucket_lifecycle_configuration
  • aws_s3_bucket_server_side_encryption_configuration

Output from Acceptance Testing

% make testacc PKG=s3 TESTS=TestAccS3BucketACL_

--- PASS: TestAccS3BucketACL_directoryBucket (12.46s)
--- PASS: TestAccS3BucketACL_disappears (17.78s)
--- PASS: TestAccS3BucketACL_basic (21.57s)
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (27.91s)
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (28.14s)
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (30.32s)
--- PASS: TestAccS3BucketACL_grantToACL (31.11s)
--- PASS: TestAccS3BucketACL_ACLToGrant (31.31s)
--- PASS: TestAccS3BucketACL_updateACL (32.40s)
--- PASS: TestAccS3BucketACL_updateGrant (34.03s)
% make testacc PKG=s3 TESTS=TestAccS3BucketAnalyticsConfiguration_

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (3.09s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (3.25s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_directoryBucket (13.88s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_disappears (23.13s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (26.55s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (26.64s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (26.64s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (38.10s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (38.20s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (38.31s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (38.32s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (38.33s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (45.81s)
% make testacc PKG=s3 TESTS=TestAccS3BucketCORSConfiguration_

--- PASS: TestAccS3BucketCORSConfiguration_directoryBucket (12.27s)
--- PASS: TestAccS3BucketCORSConfiguration_disappears (24.13s)
--- PASS: TestAccS3BucketCORSConfiguration_SingleRule (28.52s)
--- PASS: TestAccS3BucketCORSConfiguration_MultipleRules (28.79s)
--- PASS: TestAccS3BucketCORSConfiguration_basic (28.95s)
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleNoChange (34.23s)
--- PASS: TestAccS3BucketCORSConfiguration_migrate_corsRuleWithChange (34.63s)
--- PASS: TestAccS3BucketCORSConfiguration_update (47.20s)
% make testacc PKG=s3 TESTS=TestAccS3BucketLifecycleConfiguration_

--- PASS: TestAccS3BucketLifecycleConfiguration_directoryBucket (19.17s)
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_noChange (81.11s)
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_withChange (81.26s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (82.11s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (82.24s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix (92.62s)
--- PASS: TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions (93.38s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan (97.15s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (97.37s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (97.37s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix (97.37s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (97.46s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan (97.55s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero (97.58s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (97.82s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange (98.24s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (79.16s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix (139.18s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (49.85s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (68.67s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (68.47s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (68.51s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (69.74s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (165.34s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (169.12s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (211.65s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (141.91s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (200.19s)
% make testacc PKG=s3 TESTS=TestAccS3BucketServerSideEncryptionConfiguration_

--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket (13.27s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (25.51s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyARN (26.79s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (26.79s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (27.06s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (27.12s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSDSSE (27.23s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_withChange (32.71s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_migrate_noChange (33.52s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (52.44s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (52.49s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (52.74s)

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Feb 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 12, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 12, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 12, 2024
@gdavison gdavison marked this pull request as ready for review February 12, 2024 22:05
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 12, 2024
@gdavison gdavison changed the title [WIP] Fix assorted S3 bucket configuration resources Fix assorted S3 bucket configuration resources Feb 12, 2024
.changelog/35775.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Co-authored-by: Kit Ewbank <[email protected]>
@gdavison gdavison merged commit 08c6e19 into main Feb 13, 2024
44 checks passed
@gdavison gdavison deleted the b-s3-bucket-config branch February 13, 2024 19:58
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 13, 2024
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants