Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support custom_time_zone and file_extension in extended_s3_configuration block for kinesis_firehose_delivery_stream #35957

Closed
visit1985 opened this issue Feb 23, 2024 · 6 comments · Fixed by #35969
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@visit1985
Copy link
Contributor

visit1985 commented Feb 23, 2024

Description

Please support custom_time_zone and file_extension in extended_s3_configuration block for kinesis_firehose_delivery_stream.

Affected Resource(s) and/or Data Source(s)

  • kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "example" {
  # ... other configuration ...

  extended_s3_configuration {
    prefix           = "some-custom-prefix/!{timestamp:yyyy/MM/dd}/"
    custom_time_zone = "America/Los_Angeles"

    compression_format = "GZIP"
    file_extension     = ".gz"

    # ... other configuration ...
  }
}

References

https://docs.aws.amazon.com/firehose/latest/APIReference/API_ExtendedS3DestinationConfiguration.html
https://aws.amazon.com/about-aws/whats-new/2024/02/amazon-data-firehose-time-zone-bucket-prefixes/

Would you like to implement a fix?

No

@visit1985 visit1985 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/firehose Issues and PRs that pertain to the firehose service. label Feb 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2024
@acwwat
Copy link
Contributor

acwwat commented Feb 24, 2024

It doesn't seem like aws-sdk-go-v2 has support for the two new attributes yet, which is required before the resource can be updated.

https://github.com/aws/aws-sdk-go-v2/blob/7095341032d4a2b1fe04aa5e96e254321169e114/service/firehose/types/types.go#L1981-L2027

@acwwat
Copy link
Contributor

acwwat commented Feb 25, 2024

@visit1985 Thanks for pointing to the right types. Let me look into it.

Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
3 participants