Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appflow_flow: suppress diff when task_type value of Map_all is used #35993

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

  • Allows source_fields to be an empty list.

Relations

Closes #25095
Closes #35992

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccAppFlowFlow_" PKG=appflow

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 360m
--- PASS: TestAccAppFlowFlow_taskProperties (19.10s)
--- PASS: TestAccAppFlowFlow_disappears (19.59s)
--- PASS: TestAccAppFlowFlow_basic (21.72s)
--- PASS: TestAccAppFlowFlow_task_mapAll (23.49s)
--- PASS: TestAccAppFlowFlow_update (29.12s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (29.65s)
--- PASS: TestAccAppFlowFlow_taskUpdate (29.71s)
--- PASS: TestAccAppFlowFlow_tags (40.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	44.530s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appflow Issues and PRs that pertain to the appflow service. labels Feb 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 27, 2024
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. labels Feb 27, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 3  -run=TestAccAppFlowFlow_ -timeout 360m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_taskProperties
=== PAUSE TestAccAppFlowFlow_taskProperties
=== RUN   TestAccAppFlowFlow_taskUpdate
=== PAUSE TestAccAppFlowFlow_taskUpdate
=== RUN   TestAccAppFlowFlow_task_mapAll
=== PAUSE TestAccAppFlowFlow_task_mapAll
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_taskUpdate
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (30.56s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_taskUpdate (43.85s)
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (23.81s)
=== CONT  TestAccAppFlowFlow_taskProperties
--- PASS: TestAccAppFlowFlow_tags (62.96s)
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_taskProperties (23.55s)
=== CONT  TestAccAppFlowFlow_task_mapAll
--- PASS: TestAccAppFlowFlow_update (40.01s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (39.91s)
--- PASS: TestAccAppFlowFlow_task_mapAll (30.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	119.699s

@johnsonaj johnsonaj merged commit 669b3f9 into main Feb 28, 2024
37 checks passed
@johnsonaj johnsonaj deleted the b-appflow_flow_map_all branch February 28, 2024 15:10
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 28, 2024
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 1, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants