Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for io2 storage type in RDS resources #36252

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

relu
Copy link
Contributor

@relu relu commented Mar 7, 2024

Description

Adds support for io2 storage type in RDS resources.

Relations

Closes #36250

References

Output from Acceptance Testing

% make testacc TESTS="TestAccRDSCluster_storageType" PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_storageType'  -timeout 360m
=== RUN   TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN   TestAccRDSCluster_storageTypeIo2
=== PAUSE TestAccRDSCluster_storageTypeIo2
=== RUN   TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== CONT  TestAccRDSCluster_storageTypeIo1
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== CONT  TestAccRDSCluster_storageTypeIo2
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (195.77s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (220.98s)
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (221.87s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (258.73s)
--- PASS: TestAccRDSCluster_storageTypeIo2 (1588.85s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (1676.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1680.589s

% make testacc TESTS="TestAccRDSInstance_Storage_separateIOPSUpdate" PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_Storage_separateIOPSUpdate'  -timeout 360m
=== RUN   TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== RUN   TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io1 (728.49s)
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io2 (788.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        793.481s

% make testacc TESTS="TestAccRDSInstance_SnapshotIdentifier_io" PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run='TestAccRDSInstance_SnapshotIdentifier_io' -timeout 360m
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io2Storage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io2Storage (1755.08s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1812.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1817.695s

Copy link

github-actions bot commented Mar 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2024
@relu relu force-pushed the feature-rds-io2-storage-type branch from bcd12a2 to e317808 Compare March 7, 2024 09:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @relu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@relu relu marked this pull request as ready for review March 7, 2024 10:34
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Mar 7, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_storageType\|TestAccRDSCluster_basic\|TestAccRDSInstance_SnapshotIdentifier_io\|TestAccRDSInstance_basic\|TestAccRDSInstance_Storage_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_storageType\|TestAccRDSCluster_basic\|TestAccRDSInstance_SnapshotIdentifier_io\|TestAccRDSInstance_basic\|TestAccRDSInstance_Storage_ -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN   TestAccRDSCluster_storageTypeIo2
=== PAUSE TestAccRDSCluster_storageTypeIo2
=== RUN   TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_Storage_maxAllocated
=== PAUSE TestAccRDSInstance_Storage_maxAllocated
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== RUN   TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== RUN   TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== RUN   TestAccRDSInstance_Storage_gp3MySQL
=== PAUSE TestAccRDSInstance_Storage_gp3MySQL
=== RUN   TestAccRDSInstance_Storage_gp3Postgres
=== PAUSE TestAccRDSInstance_Storage_gp3Postgres
=== RUN   TestAccRDSInstance_Storage_gp3SQLServer
=== PAUSE TestAccRDSInstance_Storage_gp3SQLServer
=== RUN   TestAccRDSInstance_Storage_changeThroughput
=== PAUSE TestAccRDSInstance_Storage_changeThroughput
=== RUN   TestAccRDSInstance_Storage_changeIOPSThroughput
=== PAUSE TestAccRDSInstance_Storage_changeIOPSThroughput
=== RUN   TestAccRDSInstance_Storage_changeIOPS
=== PAUSE TestAccRDSInstance_Storage_changeIOPS
=== RUN   TestAccRDSInstance_Storage_throughputSSE
=== PAUSE TestAccRDSInstance_Storage_throughputSSE
=== RUN   TestAccRDSInstance_Storage_typePostgres
=== PAUSE TestAccRDSInstance_Storage_typePostgres
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_basic (134.16s)
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (211.80s)
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (159.62s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (191.99s)
=== CONT  TestAccRDSCluster_storageTypeIo2
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (128.66s)
=== CONT  TestAccRDSCluster_storageTypeIo1
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io1 (703.31s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io1Storage
--- PASS: TestAccRDSCluster_storageTypeIo2 (1705.42s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io2Storage
--- PASS: TestAccRDSCluster_storageTypeIo1 (1744.52s)
=== CONT  TestAccRDSInstance_Storage_changeThroughput
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1863.81s)
=== CONT  TestAccRDSInstance_Storage_typePostgres
--- PASS: TestAccRDSInstance_Storage_changeThroughput (669.43s)
=== CONT  TestAccRDSInstance_Storage_throughputSSE
--- PASS: TestAccRDSInstance_Storage_typePostgres (684.02s)
=== CONT  TestAccRDSInstance_Storage_changeIOPS
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io2Storage (1543.31s)
=== CONT  TestAccRDSInstance_Storage_changeIOPSThroughput
--- PASS: TestAccRDSInstance_Storage_throughputSSE (962.36s)
=== CONT  TestAccRDSInstance_Storage_maxAllocated
--- PASS: TestAccRDSInstance_Storage_changeIOPS (700.85s)
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_Storage_changeIOPSThroughput (684.45s)
=== CONT  TestAccRDSInstance_Storage_gp3Postgres
--- PASS: TestAccRDSInstance_basic (504.46s)
=== CONT  TestAccRDSInstance_Storage_gp3SQLServer
--- PASS: TestAccRDSInstance_Storage_maxAllocated (786.48s)
=== CONT  TestAccRDSInstance_Storage_gp3MySQL
--- PASS: TestAccRDSInstance_Storage_gp3Postgres (828.91s)
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
--- PASS: TestAccRDSInstance_Storage_gp3MySQL (778.96s)
--- PASS: TestAccRDSInstance_Storage_gp3SQLServer (1176.97s)
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io2 (661.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5834.863s

@ewbankkit
Copy link
Contributor

@relu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b540468 into hashicorp:main Mar 7, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 7, 2024
@relu relu deleted the feature-rds-io2-storage-type branch March 7, 2024 16:59
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support IO2 storage type for RDS
2 participants