Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datasource for Cloudfront Origin Access Control #36301

Merged

Conversation

jeremychauvet
Copy link
Contributor

@jeremychauvet jeremychauvet commented Mar 11, 2024

Description

This pull request add a new datasource for Cloudfront Origin Access Control

Relations

Closes #34490
Closes #34489

References

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-restricting-access-to-s3.html

Output from Acceptance Testing

make testacc TESTS=TestAccCloudFrontOriginAccessControlDataSource_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessControlDataSource_'  -timeout 360m
=== RUN   TestAccCloudFrontOriginAccessControlDataSource_description
=== PAUSE TestAccCloudFrontOriginAccessControlDataSource_description
=== RUN   TestAccCloudFrontOriginAccessControlDataSource_noDescription
=== PAUSE TestAccCloudFrontOriginAccessControlDataSource_noDescription
=== CONT  TestAccCloudFrontOriginAccessControlDataSource_description
=== CONT  TestAccCloudFrontOriginAccessControlDataSource_noDescription
--- PASS: TestAccCloudFrontOriginAccessControlDataSource_description (16.36s)
--- PASS: TestAccCloudFrontOriginAccessControlDataSource_noDescription (17.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 17.718s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. generators Relates to code generators. labels Mar 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 11, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 11, 2024
@jeremychauvet
Copy link
Contributor Author

Hello @justinretzolk 👋🏼
Can I have your opinion about the failing test "Semgrep Checks / Code Quality Scan (pull_request)". I'm not sure to understand what need to be fixed here.
Otherwise PR is ready for review :)

@johnsonaj johnsonaj self-assigned this Jul 12, 2024
@johnsonaj johnsonaj requested a review from a team as a code owner July 12, 2024 16:29
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTS=TestAccCloudFrontOriginAccessControlDataSource_ PKG=cloudfront

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessControlDataSource_'  -timeout 360m
=== RUN   TestAccCloudFrontOriginAccessControlDataSource_basic
=== PAUSE TestAccCloudFrontOriginAccessControlDataSource_basic
=== CONT  TestAccCloudFrontOriginAccessControlDataSource_basic
--- PASS: TestAccCloudFrontOriginAccessControlDataSource_basic (12.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	18.970s

@johnsonaj
Copy link
Contributor

@jeremychauvet thank you for the contribution 🎉

@johnsonaj johnsonaj merged commit 6c27298 into hashicorp:main Jul 12, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_cloudfront_origin_access_control
3 participants