Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_vpn_connection removes transit gateway id dependency for IPv6 tunnel options #36405

Conversation

tmatty102
Copy link

Description

Fixes the requirement of transit gateway id when creating IPv6 VPN connection and accelerator. VPN tunnel with ipv6 options should be allowed to created without transit gateway. Such tunnel can attach to core-network, CloudWAN.

Relations

Closes #36075

References

Output from Acceptance Testing

❯ make testacc TESTS=TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR'  -timeout 360m
=== RUN   TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== CONT  TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR (43.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	48.933s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpnsite Issues and PRs that pertain to the vpnsite service. labels Mar 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR\|TestAccSiteVPNConnection_basic' PKG=ec2      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR\|TestAccSiteVPNConnection_basic -timeout 360m
=== RUN   TestAccSiteVPNConnection_basic
=== PAUSE TestAccSiteVPNConnection_basic
=== RUN   TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== CONT  TestAccSiteVPNConnection_basic
=== CONT  TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR (54.99s)
--- PASS: TestAccSiteVPNConnection_basic (242.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	254.882s

@ewbankkit
Copy link
Contributor

@tmatty102 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit dfbf59d into hashicorp:main Mar 20, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 20, 2024
@tmatty102 tmatty102 deleted the b-aws_vpn_connection-inside-ipv6-tgwid-dependency branch March 20, 2024 16:41
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: custom tunnel*_inside_ipv6_cidr should not have dependency on the present of transit_gateway_id
4 participants