Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_record(fix): correctly interpret wildcard record names #36699

Merged
merged 3 commits into from
Apr 3, 2024
Merged

r/aws_route53_record(fix): correctly interpret wildcard record names #36699

merged 3 commits into from
Apr 3, 2024

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Apr 2, 2024

Description

The response for ListResourceRecordSet encodes special characters like * as octal escape sequences. This causes plans to see drift in the alias records where none actually exists.

References

Output from Acceptance Testing

This seems unnecessarily involved and expensive for what this PR is trying to accomplish.

The response for ListResourceRecordSet encodes special characters like
`*` as octal escape sequences. This causes plans to see drift in the
alias records where none actually exists.
Copy link

github-actions bot commented Apr 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 2, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 2, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @skeggse 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 3, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=route53 TESTS=TestAccRoute53Record_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53Record_'  -timeout 360m

--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (140.82s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (143.92s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (151.28s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_failover (153.66s)
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
--- PASS: TestAccRoute53Record_Support_txt (164.86s)
=== CONT  TestAccRoute53Record_Geoproximity_basic
--- PASS: TestAccRoute53Record_empty (172.77s)
=== CONT  TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_longTXTrecord (177.45s)
=== CONT  TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_fqdn (187.09s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_underscored (188.14s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (199.71s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_Allow_overwrite (205.29s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_basic (205.51s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (214.49s)
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (225.33s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (242.66s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (244.44s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_wildcard (252.83s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (263.76s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
--- PASS: TestAccRoute53Record_Alias_changeDualstack (266.13s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
--- PASS: TestAccRoute53Record_generatesSuffix (148.92s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Support_ds (152.54s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_Geoproximity_basic (146.10s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_Alias_change (320.25s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_disappears (120.56s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_Alias_uppercase (187.45s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_Geolocation_basic (175.12s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_Alias_elb (153.36s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_Support_caa (166.79s)
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (232.28s)
--- PASS: TestAccRoute53Record_Alias_s3 (143.32s)
--- PASS: TestAccRoute53Record_Support_spf (122.49s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (230.80s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (194.23s)
--- PASS: TestAccRoute53Record_cidr (277.88s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (230.01s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (203.26s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (202.20s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (185.83s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (222.96s)
--- PASS: TestAccRoute53Record_Weighted_basic (164.45s)
--- PASS: TestAccRoute53Record_Latency_basic (176.59s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (204.18s)
--- PASS: TestAccRoute53Record_Weighted_alias (340.82s)
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (210.13s)
--- PASS: TestAccRoute53Record_nameChange (223.25s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (346.80s)
--- PASS: TestAccRoute53Record_typeChange (211.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    576.010s

@jar-b
Copy link
Member

jar-b commented Apr 3, 2024

Thanks for your contribution, @skeggse! 👍

@jar-b jar-b merged commit 9451a5f into hashicorp:main Apr 3, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.44.0 milestone Apr 3, 2024
@ewbankkit ewbankkit mentioned this pull request Apr 3, 2024
@skeggse
Copy link
Contributor Author

skeggse commented Apr 5, 2024

Thanks for taking it and running with it!

@skeggse skeggse deleted the b-aws_route53_record-alias-name-fix branch April 5, 2024 06:13
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants